From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Robert Pluim Newsgroups: gmane.emacs.bugs Subject: bug#46459: 28.0.50; Shared keymap for Git VC dir "Branch" header? Date: Fri, 12 Feb 2021 10:55:05 +0100 Message-ID: <87h7mhwqyu.fsf@gmail.com> References: <87a6s94vze.fsf@protesilaos.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="18642"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 46459@debbugs.gnu.org To: Protesilaos Stavrou Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Feb 12 10:56:18 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lAVBS-0004lG-CI for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 12 Feb 2021 10:56:18 +0100 Original-Received: from localhost ([::1]:49236 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lAVBQ-0006Yj-Ro for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 12 Feb 2021 04:56:16 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:59548) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lAVBC-0006YP-CS for bug-gnu-emacs@gnu.org; Fri, 12 Feb 2021 04:56:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:48419) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lAVBC-0002hj-4H for bug-gnu-emacs@gnu.org; Fri, 12 Feb 2021 04:56:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lAVBC-0001mW-1j for bug-gnu-emacs@gnu.org; Fri, 12 Feb 2021 04:56:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Robert Pluim Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 12 Feb 2021 09:56:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 46459 X-GNU-PR-Package: emacs Original-Received: via spool by 46459-submit@debbugs.gnu.org id=B46459.16131237156795 (code B ref 46459); Fri, 12 Feb 2021 09:56:01 +0000 Original-Received: (at 46459) by debbugs.gnu.org; 12 Feb 2021 09:55:15 +0000 Original-Received: from localhost ([127.0.0.1]:59965 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lAVAR-0001lX-Fa for submit@debbugs.gnu.org; Fri, 12 Feb 2021 04:55:15 -0500 Original-Received: from mail-wm1-f50.google.com ([209.85.128.50]:51624) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lAVAP-0001lI-2e for 46459@debbugs.gnu.org; Fri, 12 Feb 2021 04:55:14 -0500 Original-Received: by mail-wm1-f50.google.com with SMTP id u16so383031wmq.1 for <46459@debbugs.gnu.org>; Fri, 12 Feb 2021 01:55:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :mime-version:content-transfer-encoding; bh=He4Jym8DCWms0MbOvW4bp/IZzK9GBmHJvEqkv6eOves=; b=rujhZTx7jR7Fj+M1ElZEI2WacHa8pbBmVmJb4Sw2fFASzCupcaVskNTWAWNBlOkBCE Ye8JT050ytAm4K9BYFRUdYg+8ak/mg3837jWAgC29u0jKig8RCZrmMBBH6899DfAlcnG mc+BGWB//YzgJP5X2zBurjadmtVtWwQFNje1+CuvlLfdUOsRdM5BN8iJWBI5eDp642Sl 5B6VL6KCIwuChe6mOL8Bl+7+lH7s+T4mZXt4FQfMHoGswfBzy1vb8B5RP2DorktJGw4+ eteqsNw//vtD1yNxzi7am47P6fb50ReKstxmrCiakqgHI7s+ka8YoQLc97RcqwepMnXI 91bQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:mime-version:content-transfer-encoding; bh=He4Jym8DCWms0MbOvW4bp/IZzK9GBmHJvEqkv6eOves=; b=Ikk1r0B+hwkq4GQ/m5s0LtCXxtaE3VdqXik7i5b2y0BSkQjKT1aOvhYhsbbyu3eLj5 yb0a6Xb+ykT4kQbBhSgQEFesmlPjOrf7jKMvUzdlVy6T9Huo84QlkQT4FZ8twijV1536 l7TuTwgX1zSyp4Jq9r2Eh1T/ZHAwoNsLg8d04OQbKvLjB5+FD+A6P1wxAW+R3WV1uLKH PSOvEzOPnB1B0zaoNhtR7U6c4IeffRmofKA3Ro2r29C7KcCWNCWIpl9TiA2QVhzHfa9x 2hQgYFeLaRUWMPR1Da++WRUEAKxQqVD56PlCYBVdPZnDiWoHLlxIVobVJH7SeIdVOsi5 HfTA== X-Gm-Message-State: AOAM531Dw+UPNcPr5pkZA/M1xDyL+DnlS5oBJD2WtIBl24x0rs/l5cMS V9zxUyk7JCrGVGrF/4H7VwuiOv7lEuC/wA== X-Google-Smtp-Source: ABdhPJwx52s4dKdiP/bRDyW9Xr5yVFcwtHjaqn7dyKIGB7Z74mqRcKHePc4ymEPEWONSFsk3jQv0xw== X-Received: by 2002:a1c:2d48:: with SMTP id t69mr1864388wmt.124.1613123706659; Fri, 12 Feb 2021 01:55:06 -0800 (PST) Original-Received: from rltb ([2a01:e34:ecfc:a861:69b6:6aaf:dbd3:8964]) by smtp.gmail.com with ESMTPSA id n187sm13523145wmf.29.2021.02.12.01.55.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 12 Feb 2021 01:55:06 -0800 (PST) In-Reply-To: <87a6s94vze.fsf@protesilaos.com> (Protesilaos Stavrou's message of "Fri, 12 Feb 2021 08:54:13 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:199850 Archived-At: >>>>> On Fri, 12 Feb 2021 08:54:13 +0200, Protesilaos Stavrou said: Protesilaos> Dear maintainers, Protesilaos> In vc-git.el the header for vc-dir stashes is propertized = with its own Protesilaos> keymap. This means that while point is over the value of = the "Stash:" Protesilaos> header, the specified keymap comes into effect, instead of= the main one Protesilaos> for vc-dir. The latter takes effect when point is anywher= e but that Protesilaos> header's value. Protesilaos> Should this principle be applied to the value of the "Bran= ch" header as Protesilaos> well? The attached patch is a proof-of-concept to that en= d. Protesilaos> If you believe this is worth doing, what else do you think= should go Protesilaos> into such a patch from a usability standpoint? Looks good to me, although I=CA=BCve just noticed the vc and vc-dir have confusingly different bindings for vc-retrieve-tag and vc-create-tag Maybe put vc-create-tag on C-x v c as well? Robert