From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Michael Heerdegen Newsgroups: gmane.emacs.help Subject: Re: A strange issue with buffer-undo-list Date: Wed, 24 Feb 2021 04:33:15 +0100 Message-ID: <87h7m2rvgk.fsf@web.de> References: <87o8gbqs28.fsf@mbork.pl> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="2492"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: Stefan Monnier To: help-gnu-emacs@gnu.org Cancel-Lock: sha1:+May3kigb26r6YFI/rBl+pU8hdI= Original-X-From: help-gnu-emacs-bounces+geh-help-gnu-emacs=m.gmane-mx.org@gnu.org Wed Feb 24 04:33:56 2021 Return-path: Envelope-to: geh-help-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lEkw0-0000ZU-LC for geh-help-gnu-emacs@m.gmane-mx.org; Wed, 24 Feb 2021 04:33:56 +0100 Original-Received: from localhost ([::1]:55896 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lEkvz-0006mj-Ny for geh-help-gnu-emacs@m.gmane-mx.org; Tue, 23 Feb 2021 22:33:55 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:40130) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lEkvU-0006mc-1e for help-gnu-emacs@gnu.org; Tue, 23 Feb 2021 22:33:24 -0500 Original-Received: from ciao.gmane.io ([116.202.254.214]:36166) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lEkvS-0000vV-Dp for help-gnu-emacs@gnu.org; Tue, 23 Feb 2021 22:33:23 -0500 Original-Received: from list by ciao.gmane.io with local (Exim 4.92) (envelope-from ) id 1lEkvQ-000AW3-9G for help-gnu-emacs@gnu.org; Wed, 24 Feb 2021 04:33:20 +0100 X-Injected-Via-Gmane: http://gmane.org/ Received-SPF: pass client-ip=116.202.254.214; envelope-from=geh-help-gnu-emacs@m.gmane-mx.org; helo=ciao.gmane.io X-Spam_score_int: -13 X-Spam_score: -1.4 X-Spam_bar: - X-Spam_report: (-1.4 / 5.0 requ) BAYES_00=-1.9, FREEMAIL_FORGED_FROMDOMAIN=0.25, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.25, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: help-gnu-emacs@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Users list for the GNU Emacs text editor List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: help-gnu-emacs-bounces+geh-help-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "help-gnu-emacs" Xref: news.gmane.io gmane.emacs.help:128221 Archived-At: Marcin Borkowski writes: > (defun move-line-down (count) > "Move the current line down." > (interactive "p") > (let ((position-in-line (current-column))) > (push (point) buffer-undo-list) > (line-move 1) > (transpose-lines count) > (line-move -1) > (move-to-column position-in-line))) > > > which triggers an error. [when invoking undo after using it] Seems the error happens in the code for fixing Bug#33341 by Stefan: (defun activate-change-group (handle) "Activate a change group made with `prepare-change-group' (which see)." (dolist (elt handle) (with-current-buffer (car elt) (if (eq buffer-undo-list t) (setq buffer-undo-list nil) ;; [huge comment here] (when (numberp (caar buffer-undo-list)) ;; <--- here (push (cons (caar buffer-undo-list) (caar buffer-undo-list)) buffer-undo-list)))))) I guess that `caar' should be (car-safe (car buffer-undo-list)) or so - right? Michael.