all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Lars Ingebrigtsen <larsi@gnus.org>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: Matt Armstrong <matt@rfc20.org>, 46819@debbugs.gnu.org
Subject: bug#46819: 28.0.50; Undesireable warning: Empty let body from the `benchmark-run' implementation
Date: Sun, 28 Feb 2021 15:13:24 +0100	[thread overview]
Message-ID: <87h7lwmgaj.fsf@gnus.org> (raw)
In-Reply-To: <jwvwnut5ixb.fsf-monnier+emacs@gnu.org> (Stefan Monnier's message of "Sat, 27 Feb 2021 16:00:21 -0500")

Stefan Monnier <monnier@iro.umontreal.ca> writes:

> It'd be easy to put an explicit nil in the loop's body, but....
>
> The idea was that in actual (non-macroexpanded) source code, empty let
> bodies are usually the result of a misplaced paren.  But it's probably
> more often annoying than useful since we can't easily distinguish a "let
> from source code" from a "let from a macro expansion".
>
> So I'm also voting to revert that change.
> Any objection?

It is a nice and helpful warning, though, so if it could be fixed in
another way, that'd be great.  (But I have no idea how, of course.)

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no





  reply	other threads:[~2021-02-28 14:13 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-27 20:18 bug#46819: 28.0.50; Undesireable warning: Empty let body from the `benchmark-run' implementation Matt Armstrong
2021-02-27 21:00 ` Stefan Monnier
2021-02-28 14:13   ` Lars Ingebrigtsen [this message]
2021-03-01  0:04     ` Matt Armstrong
2021-03-01  0:09       ` Lars Ingebrigtsen
2021-03-01  0:19         ` Lars Ingebrigtsen
2021-03-01  5:04       ` Stefan Monnier
2021-03-02  5:07         ` Matt Armstrong
2021-03-10  4:53     ` Matt Armstrong
2021-03-10 14:54       ` Lars Ingebrigtsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87h7lwmgaj.fsf@gnus.org \
    --to=larsi@gnus.org \
    --cc=46819@debbugs.gnu.org \
    --cc=matt@rfc20.org \
    --cc=monnier@iro.umontreal.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.