From: "Basil L. Contovounesios" <contovob@tcd.ie>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 47234@debbugs.gnu.org, Juri Linkov <juri@linkov.net>
Subject: bug#47234: 28.0.50; frame-inner-height fails without window system on tab-bar-height
Date: Thu, 18 Mar 2021 22:24:18 +0000 [thread overview]
Message-ID: <87h7l8umlp.fsf@tcd.ie> (raw)
In-Reply-To: <83ft0sfcsx.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 18 Mar 2021 22:05:02 +0200")
Eli Zaretskii <eliz@gnu.org> writes:
> After thinking some more about this, I think we should leave the
> frame.el part of 6c5ddf0e0b alone, but augment it with the fboundp
> test, such that on TTY frames the tab bar would be included in the
> frame's inner height, like the menu bar is. This is also consistent
> with what happens on TTY frames in a build with X: tab-bar-height
> returns zero.
>
> Basil, can you please install such a change on the emacs-27 branch? I
> will then make another RC.
Done:
Fix frame-inner-height in non-GUI builds
bd991e3c9b 2021-03-18 22:13:05 +0000
https://git.sv.gnu.org/cgit/emacs.git/commit/?id=bd991e3c9bc9c26e641036f52adf82e052d4319c
Is there anything left to address here on the master branch, or can this
report be closed?
The other --without-x warnings in frame.el are benign, and I'll try to
look into the rest of them soon, but none of them sound too alarming at
first glance (famous last words).
Thanks,
--
Basil
next prev parent reply other threads:[~2021-03-18 22:24 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-18 13:41 bug#47234: 28.0.50; frame-inner-height fails without window system on tab-bar-height Basil L. Contovounesios
2021-03-18 14:30 ` Eli Zaretskii
2021-03-18 14:57 ` Basil L. Contovounesios
2021-03-18 15:12 ` Eli Zaretskii
2021-03-18 15:22 ` Basil L. Contovounesios
2021-03-18 15:53 ` Eli Zaretskii
2021-03-18 17:07 ` Juri Linkov
2021-03-18 17:51 ` martin rudalics
2021-03-18 18:55 ` Eli Zaretskii
2021-03-19 8:14 ` martin rudalics
2021-03-19 8:22 ` Eli Zaretskii
2021-03-18 18:48 ` Eli Zaretskii
2021-03-18 19:00 ` Juri Linkov
2021-03-18 20:05 ` Eli Zaretskii
2021-03-18 22:24 ` Basil L. Contovounesios [this message]
2021-03-19 7:02 ` Eli Zaretskii
2021-03-19 8:15 ` martin rudalics
2021-03-26 17:44 ` Basil L. Contovounesios
2021-03-18 15:51 ` martin rudalics
2021-03-18 17:36 ` Juri Linkov
2021-03-26 17:46 ` Basil L. Contovounesios
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87h7l8umlp.fsf@tcd.ie \
--to=contovob@tcd.ie \
--cc=47234@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=juri@linkov.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.