Re: master b968323: Fix previous face.el change

Re: master b968323: Fix previous face.el change

[Stefan Kangas]

larsi@gnus.org (Lars Ingebrigtsen) writes:

> branch: master
> commit b9683230ecaada87f23bdba59ef044c4b0374216
> Author: Lars Ingebrigtsen <larsi@gnus.org>
> Commit: Lars Ingebrigtsen <larsi@gnus.org>
>
>     Fix previous face.el change
>
>     * lisp/faces.el (require): Fix compilation warning from previous
>     face.el change.
> ---
>  lisp/faces.el | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/lisp/faces.el b/lisp/faces.el
> index 3ea4c94..1067556 100644
> --- a/lisp/faces.el
> +++ b/lisp/faces.el
> @@ -25,6 +25,8 @@
>
>  ;;; Code:
>
> +(eval-when-compile (require 'subr-x))
> +

This commit breaks bootstrap here:

    Loading /home/skangas/wip/emacs/lisp/faces.el (source)...
    Eager macro-expansion failure: (void-variable
read-file-name-completion-ignore-case)
    Eager macro-expansion failure: (void-variable
read-file-name-completion-ignore-case)
    Loading /home/skangas/wip/emacs/lisp/cus-face.el (source)...
    Eager macro-expansion failure: (void-variable
read-file-name-completion-ignore-case)
    Eager macro-expansion failure: (void-variable
read-file-name-completion-ignore-case)
    Loading /home/skangas/wip/emacs/lisp/faces.el (source)...
    Eager macro-expansion failure: (void-variable
read-file-name-completion-ignore-case)
    Eager macro-expansion failure: (void-variable
read-file-name-completion-ignore-case)
    Eager macro-expansion failure: (void-variable
read-file-name-completion-ignore-case)
    [... snip ...]
    Eager macro-expansion failure: (void-variable
read-file-name-completion-ignore-case)
    Eager macro-expansion failure: (void-variable
read-file-name-completion-ignore-case)
    make[3]: *** [Makefile:279: emacs-lisp/autoload.elc] Segmentation fault

I find `string-trim' an obviously useful addition to Emacs Lisp, so I
suggest moving it to subr.el instead.

That might call for adding it to the ELisp Manual as well.

Re: master b968323: Fix previous face.el change

[Lars Ingebrigtsen]

Stefan Kangas <stefan@marxist.se> writes:

> This commit breaks bootstrap here:
>
>     Loading /home/skangas/wip/emacs/lisp/faces.el (source)...

Oops.

> I find `string-trim' an obviously useful addition to Emacs Lisp, so I
> suggest moving it to subr.el instead.
>
> That might call for adding it to the ELisp Manual as well.

OK; done.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Re: master b968323: Fix previous face.el change

[Basil L. Contovounesios]

Lars Ingebrigtsen <larsi@gnus.org> writes:

> Stefan Kangas <stefan@marxist.se> writes:
>
>> I find `string-trim' an obviously useful addition to Emacs Lisp, so I
>> suggest moving it to subr.el instead.
>>
>> That might call for adding it to the ELisp Manual as well.
>
> OK; done.

Does that warrant a NEWS announcement?

Thanks,

-- 
Basil

Re: master b968323: Fix previous face.el change

[Lars Ingebrigtsen]

"Basil L. Contovounesios" <contovob@tcd.ie> writes:

> Does that warrant a NEWS announcement?

It's not really a functional change, so people don't have to do anything
about it (except stop requiring subr-x so much), so it doesn't seem to
warrant a NEWS entry.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no