From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#47616: 27.1; hardening mail-envelope-from Date: Thu, 06 May 2021 12:22:53 +0200 Message-ID: <87h7jgxite.fsf@gnus.org> References: <87v98z60u4.fsf@tucano.isti.cnr.it> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="6516"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 47616@debbugs.gnu.org To: Francesco =?UTF-8?Q?Potort=C3=AC?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu May 06 12:24:10 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lebAv-0001Z3-QM for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 06 May 2021 12:24:09 +0200 Original-Received: from localhost ([::1]:56274 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lebAu-0007T2-UJ for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 06 May 2021 06:24:08 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:54308) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lebAo-0007Sc-O5 for bug-gnu-emacs@gnu.org; Thu, 06 May 2021 06:24:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:53933) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lebAo-0007nj-H5 for bug-gnu-emacs@gnu.org; Thu, 06 May 2021 06:24:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lebAo-0006HN-Cs for bug-gnu-emacs@gnu.org; Thu, 06 May 2021 06:24:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 06 May 2021 10:24:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 47616 X-GNU-PR-Package: emacs Original-Received: via spool by 47616-submit@debbugs.gnu.org id=B47616.162029658424116 (code B ref 47616); Thu, 06 May 2021 10:24:02 +0000 Original-Received: (at 47616) by debbugs.gnu.org; 6 May 2021 10:23:04 +0000 Original-Received: from localhost ([127.0.0.1]:37243 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1leb9s-0006Gu-Cg for submit@debbugs.gnu.org; Thu, 06 May 2021 06:23:04 -0400 Original-Received: from quimby.gnus.org ([95.216.78.240]:46736) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1leb9q-0006GK-HA for 47616@debbugs.gnu.org; Thu, 06 May 2021 06:23:02 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Message-ID :In-Reply-To:Date:References:Subject:Cc:To:From:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=/6hTZoOT8+gFB3a3cLQ4/YihYoGDXBKvUpjvDzWsynA=; b=Rv++jk0j/fGPgSGjQz/SpUf6JN EZHWeI1u7c3ufqj35OGGtIoN1Fu4/N2vbLC0rtg7bcO53dz9KOmAn2ynfvJU3l6rEtuWvpr4/8AU0 9IY+pD6OL3+jNCtyIwehduQ4+OZhcrEOlEybh8SqWmooiJKN4ANA6B8GCzr5iilw6RDk=; Original-Received: from cm-84.212.220.105.getinternet.no ([84.212.220.105] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1leb9h-0005xR-Sg; Thu, 06 May 2021 12:22:56 +0200 X-Now-Playing: Nico's _Do Or Die_: "Saeta" In-Reply-To: <87v98z60u4.fsf@tucano.isti.cnr.it> ("Francesco =?UTF-8?Q?Potort=C3=AC?="'s message of "Tue, 06 Apr 2021 14:42:41 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:205803 Archived-At: Francesco Potort=C3=AC writes: > Hardening mail-envelope-from from sendmail.el by narrowing to the > headers, as the doc says, corrects the problem that I observed. Thanks -- I don't think we should change mail-envelope-from itself here, because it may conceivably be called from other contexts. Instead the callers in sendmail/smtpmail should be altered to narrow to the headers before calling it, and I've now done this in Emacs 28. (This uncovered a similar bug in smtpmail.el, too.) --=20 (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no