From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#47511: 27.1; emacs --daemon should not delete systemd socket on exit Date: Sat, 08 May 2021 14:23:53 +0200 Message-ID: <87h7jdququ.fsf@gnus.org> References: Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="25743"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 47511@debbugs.gnu.org To: Roshan Shariff Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat May 08 14:25:11 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lfM18-0006ZB-Gi for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 08 May 2021 14:25:10 +0200 Original-Received: from localhost ([::1]:58832 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lfM17-0001lK-J5 for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 08 May 2021 08:25:09 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:49070) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lfM10-0001ku-DP for bug-gnu-emacs@gnu.org; Sat, 08 May 2021 08:25:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:38421) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lfM10-0006gL-5q for bug-gnu-emacs@gnu.org; Sat, 08 May 2021 08:25:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1lfM10-0004mt-2b for bug-gnu-emacs@gnu.org; Sat, 08 May 2021 08:25:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 08 May 2021 12:25:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 47511 X-GNU-PR-Package: emacs Original-Received: via spool by 47511-submit@debbugs.gnu.org id=B47511.162047664718373 (code B ref 47511); Sat, 08 May 2021 12:25:02 +0000 Original-Received: (at 47511) by debbugs.gnu.org; 8 May 2021 12:24:07 +0000 Original-Received: from localhost ([127.0.0.1]:49960 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lfM06-0004mH-Ow for submit@debbugs.gnu.org; Sat, 08 May 2021 08:24:06 -0400 Original-Received: from quimby.gnus.org ([95.216.78.240]:42824) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1lfM04-0004lm-Uf for 47511@debbugs.gnu.org; Sat, 08 May 2021 08:24:05 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=wdyXLUcbnZAuoXpj4ATKMPKhOoN+ezdzoXiQuai4nXY=; b=kiAHCr/UqChamPebUuMM+aTBfD 2LZ/X4C7cTSXMpCuZu6fb0GGfSvx8f39bwl7CVTVl2Hq4pfW/iRnejP1uVur1RfRwwHpFMcBzjpUf aSjoecT1bFGoLOWlYEXYbgwrMAXfTw8JZK/Sacu1kk4MeQKoG/DDQP6e80W/FoG/faTk=; Original-Received: from cm-84.212.220.105.getinternet.no ([84.212.220.105] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lfLzw-0004Hc-Le; Sat, 08 May 2021 14:23:59 +0200 X-Now-Playing: King Crimson's _In the Court of the Crimson King (1)_: "The Court Of The Crimson King" In-Reply-To: (Roshan Shariff's message of "Tue, 30 Mar 2021 19:28:28 -0600") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:206006 Archived-At: Roshan Shariff writes: > In my uninformed opinion, the server-sentinel function in server.el (and > possibly other functions) should be patched to avoid deleting the socket > if it was externally created, i.e. when internal--daemon-sockname is > non-nil. My opinion isn't a lot more informed, but poking around at the code, it seems to me like this is indeed the correct thing to do here. So I've now made this change in Emacs 28. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no