From: Alexandre Duret-Lutz <adl@lrde.epita.fr>
To: Lars Ingebrigtsen <larsi@gnus.org>
Cc: 50749@debbugs.gnu.org
Subject: bug#50749: 28.0.50; three gnus-icalendar issues w.r.t. RFC5546 and party crashers
Date: Fri, 01 Oct 2021 17:39:47 +0200 [thread overview]
Message-ID: <87h7e0da9o.fsf@lrde.epita.fr> (raw)
In-Reply-To: <874ka1x7or.fsf@gnus.org> (Lars Ingebrigtsen's message of "Fri, 01 Oct 2021 14:15:16 +0200")
Lars Ingebrigtsen <larsi@gnus.org> writes:
> I forgot to check whether there were any test regressions.
Sorry, I should have known better a looked for that.
> gnus-icalendar-parse fails, but the following change makes it pass.
>
> I'm not very familiar with this code -- was this change intended?
>
> diff --git a/test/lisp/gnus/gnus-icalendar-tests.el b/test/lisp/gnus/gnus-icalendar-tests.el
> index 90c3a34a5c..61fe9701fe 100644
> --- a/test/lisp/gnus/gnus-icalendar-tests.el
> +++ b/test/lisp/gnus/gnus-icalendar-tests.el
> @@ -103,7 +103,7 @@ gnus-icalendar-parse
> (should (string= (format-time-string "%Y-%m-%d %H:%M" end-time) "2020-12-08 16:00"))
> (should (string= uid "iipdt88slddpeu7hheuu09sfmd@google.com"))
> (should (not rsvp))
> - (should (eq participation-type 'non-participant))))
> + (should (eq participation-type 'required))))
> (setenv "TZ" tz))))
Reading the test case, it looks like an event that does not list any
attendee. So I'd expect 'non-participant.
Looks my third patch is wrong then.
In
(let* (...
(role (or (plist-get (cadr attendee) 'ROLE) "REQ-PARTICIPANT"))
I meant to set REQ-PARTICIPANT only when the attendee list is non-empty
but the 'ROLE property is not found (= I have been listed as an attendee
of the event without being given a role). But the above code will set
REQ-PARTICIPANT even if attendee is empty (= I'm not listed, as in the
test case).
Let me learn from my mistake and see if I can find how to run these tests
and add a test case for for what I intended to fix.
next prev parent reply other threads:[~2021-10-01 15:39 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-23 7:47 bug#50749: 28.0.50; three gnus-icalendar issues w.r.t. RFC5546 and party crashers Alexandre Duret-Lutz
2021-09-23 21:49 ` Lars Ingebrigtsen
2021-09-23 23:57 ` Alexandre Duret-Lutz
2021-09-25 0:45 ` Lars Ingebrigtsen
2021-10-01 8:15 ` Alexandre Duret-Lutz
2021-10-01 12:09 ` Lars Ingebrigtsen
2021-10-01 12:15 ` Lars Ingebrigtsen
2021-10-01 15:39 ` Alexandre Duret-Lutz [this message]
2021-10-01 16:00 ` Alexandre Duret-Lutz
2021-10-02 8:56 ` Lars Ingebrigtsen
2021-10-02 8:56 ` Lars Ingebrigtsen
2021-09-24 14:35 ` Jan Tatarik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87h7e0da9o.fsf@lrde.epita.fr \
--to=adl@lrde.epita.fr \
--cc=50749@debbugs.gnu.org \
--cc=larsi@gnus.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.