all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Juri Linkov <juri@linkov.net>
To: "Mattias Engdegård" <mattiase@acm.org>
Cc: Dmitry Gutov <dgutov@yandex.ru>, yyoncho <yyoncho@gmail.com>,
	38797@debbugs.gnu.org
Subject: bug#38797: 27.0.50; Feature request: provide the opposite of xref-pop-marker-stack
Date: Mon, 25 Oct 2021 20:05:33 +0300	[thread overview]
Message-ID: <87h7d5xcf6.fsf@mail.linkov.net> (raw)
In-Reply-To: <B000C18C-DFEF-4D5D-86D1-2964710E5AAE@acm.org> ("Mattias Engdegård"'s message of "Mon, 25 Oct 2021 17:49:52 +0200")

>> LGTM, please install.
>
> Thank you Dmitry, now pushed to master.

I took a look at your change, and noticed an asymmetry
between the names xref-pop-marker-stack and xref-go-forward.
Shouldn't the name xref-pop-marker-stack be obsoleted,
and replaced with a new name xref-go-back?  (I see now
that you added FIXME for this.)

Another question is that in the menu bar currently the order is
"Forward" and "Back".  But more natural order would be
"Back" and "Forward".

> Juri, would you help out with adding (or not) `xref-go-forward` to the
> context menu? I wasn't sure if we had agreed on good names for this and the
> go-back entries. The current "Back Definition" is a bit nonsensical in
> English.

I completely agree that the current title is inappropriate.

> I favour (lightly) "Go Back" / "Go Forward" because they make sense in
> context with the other Xref operations in that separator-delimited group of
> entries in the menu, and because it's a wording often used for these
> operations elsewhere such as in web browsers and IDEs (though often it's
> just "Back" and "Forward").
>
> "Xref {Back,Forward}" or "{Back,Forward} Xref" would also do and displays
> the link to Xref up front, but the English is decidedly less natural.

With such a test case:

0. emacs -Q
1. click mouse-3 on any word in *scratch*, and select from the context menu
   "Find Definition".  It should fail with the error
   "No definitions found for: This".  This is correct.
2. now click mouse-3 at the end of *scratch*, not on a word.

The menu contains the item "Back Definition".  (BTW, why if the search failed?)

This menu item is too ambiguous.  Renaming it to "Go Back" or "Go Forward"
doesn't make the menu item clearer.  Only adding a word "Xref" somewhere
will disambiguate it.  Maybe then "Go Back in Xref" or "Go Back with Xref"?
We need more opinions.





  reply	other threads:[~2021-10-25 17:05 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-29 18:11 bug#38797: 27.0.50; Feature request: provide the opposite of xref-pop-marker-stack yyoncho
2020-01-23 14:13 ` Dmitry Gutov
2021-10-20 19:12 ` Mattias Engdegård
2021-10-24  1:40   ` Dmitry Gutov
2021-10-24  7:54     ` Juri Linkov
2021-10-24 12:39       ` Dmitry Gutov
2021-10-24 19:10         ` Juri Linkov
2021-10-24 23:22           ` Dmitry Gutov
2021-10-25  7:44             ` Juri Linkov
2021-10-25 15:18               ` Dmitry Gutov
2021-10-25 17:07                 ` Juri Linkov
2021-10-24 13:24     ` Mattias Engdegård
2021-10-25  2:13       ` Dmitry Gutov
2021-10-25 15:49         ` Mattias Engdegård
2021-10-25 17:05           ` Juri Linkov [this message]
2021-10-25 18:53             ` Mattias Engdegård
2021-10-25 19:38             ` Dmitry Gutov
2021-10-25 21:29           ` Glenn Morris
2021-10-26  8:06             ` Mattias Engdegård
2021-11-08 18:23           ` Juri Linkov
2021-11-09  8:30             ` Juri Linkov
2021-11-09 13:08               ` Mattias Engdegård
2021-11-09 13:09                 ` Dmitry Gutov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87h7d5xcf6.fsf@mail.linkov.net \
    --to=juri@linkov.net \
    --cc=38797@debbugs.gnu.org \
    --cc=dgutov@yandex.ru \
    --cc=mattiase@acm.org \
    --cc=yyoncho@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.