all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Lars Ingebrigtsen <larsi@gnus.org>
To: Drew Adams <drew.adams@oracle.com>
Cc: 51469@debbugs.gnu.org
Subject: bug#51469: 27.2; Mismatch: `set-face-attribute' and `face-all-attributes'
Date: Fri, 29 Oct 2021 15:12:40 +0200	[thread overview]
Message-ID: <87h7d0ynxz.fsf@gnus.org> (raw)
In-Reply-To: <SJ0PR10MB5488AD9A66A1299ECA542E6BF3869@SJ0PR10MB5488.namprd10.prod.outlook.com> (Drew Adams's message of "Thu, 28 Oct 2021 23:03:35 +0000")

Drew Adams <drew.adams@oracle.com> writes:

> Why is the &rest argument ARGUMENTS of `set-face-attribute' a plist of
> attributes, but `face-all-attributes' returns an alist of attributes?

It's not essentially a plist, but a list of :keyword value pairs, but
that's splitting hairs.

face-all-attributes could return such a plist, but we usually prefer to
return alists from functions instead of plists.

> Is there a good reason for this status quo?  If not, can we change it to
> get a better fit and not require conversion?

We can't change the output of face-all-attributes (because that would
break code), so I don't think there's anything to do here, and I'm
closing this bug report.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no





  reply	other threads:[~2021-10-29 13:12 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-28 23:03 bug#51469: 27.2; Mismatch: `set-face-attribute' and `face-all-attributes' Drew Adams
2021-10-29 13:12 ` Lars Ingebrigtsen [this message]
2021-10-29 18:01   ` bug#51469: [External] : " Drew Adams

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87h7d0ynxz.fsf@gnus.org \
    --to=larsi@gnus.org \
    --cc=51469@debbugs.gnu.org \
    --cc=drew.adams@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.