all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Po Lu via "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
To: dick <dick.r.chiang@gmail.com>
Cc: 52676-done@debbugs.gnu.org
Subject: bug#52676: 28.0.50; [PATCH] Rationalize window-text-pixel-size
Date: Mon, 20 Dec 2021 11:26:32 +0800	[thread overview]
Message-ID: <87h7b43qjb.fsf@yahoo.com> (raw)
In-Reply-To: <87wnk0xaz4.fsf@dick> (dick's message of "Sun, 19 Dec 2021 21:32:15 -0500")

dick <dick.r.chiang@gmail.com> writes:

> Even if 43c4cc2 did anything (it doesn't), it was obviously the wrong
> way to go about it.

On the contrary, it does.  The pixel-scrolling code works on a line with
a line-prefix because of it.

> +	    (car (window-text-pixel-size
> +                  nil (line-beginning-position) (line-end-position)))))))))

This suggests that it will not work for the usecase that the option was
intended to support, because the position `line-beginning-position'
might not be on the start of the visual line.  Trust me, I tried quite a
few options including precisely this before implementing this option.

Closing.





  reply	other threads:[~2021-12-20  3:26 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-20  2:32 bug#52676: 28.0.50; [PATCH] Rationalize window-text-pixel-size dick
2021-12-20  3:26 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors [this message]
2021-12-20  5:20   ` dick
2021-12-20 17:11     ` Eli Zaretskii
2021-12-21  1:36       ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-12-21  3:30         ` Eli Zaretskii
2021-12-21  3:38           ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-12-21 12:12             ` Eli Zaretskii
2021-12-21 12:19               ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-12-21 17:56                 ` dick
2021-12-21 18:05                   ` Robert Pluim
2021-12-22  0:59                     ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-12-21 18:06                   ` Eli Zaretskii
2021-12-22  0:58                   ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-12-21  1:34     ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-12-20 15:19 ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87h7b43qjb.fsf@yahoo.com \
    --to=bug-gnu-emacs@gnu.org \
    --cc=52676-done@debbugs.gnu.org \
    --cc=dick.r.chiang@gmail.com \
    --cc=luangruo@yahoo.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.