* Re: master 291085a2a6: (Fmake_finalizer): Check the arg is a function
[not found] ` <20211231051612.BC467C002EE@vcs2.savannah.gnu.org>
@ 2021-12-31 12:24 ` Michael Albinus
2021-12-31 15:51 ` Lars Ingebrigtsen
0 siblings, 1 reply; 2+ messages in thread
From: Michael Albinus @ 2021-12-31 12:24 UTC (permalink / raw)
To: emacs-devel; +Cc: Stefan Monnier
Stefan Monnier via Mailing list for Emacs changes <emacs-diffs@gnu.org>
writes:
Hi Stefan,
> branch: master
> commit 291085a2a61d7596e6f3e3152247198fdf85da26
> Author: Stefan Monnier <monnier@iro.umontreal.ca>
> Commit: Stefan Monnier <monnier@iro.umontreal.ca>
>
> (Fmake_finalizer): Check the arg is a function
>
> * src/eval.c (syms_of_eval): Add `Qfunctionp`.
> * src/alloc.c (Fmake_finalizer): Check the arg is a function.
This fires an error:
--8<---------------cut here---------------start------------->8---
$ make -C test alloc-tests
make: Entering directory '/usr/local/src/emacs/test'
make[1]: Entering directory '/usr/local/src/emacs/test'
GEN src/alloc-tests.log
Running 5 tests (2021-12-31 13:19:55+0100, selector `(not (or (tag :unstable) (tag :nativecomp)))')
passed 1/5 aset-nbytes-change (0.000107 sec)
Test finalizer-object-type backtrace:
signal(wrong-type-argument (functionp nil))
apply(signal (wrong-type-argument (functionp nil)))
(setq value-2 (apply fn-0 args-1))
(unwind-protect (setq value-2 (apply fn-0 args-1)) (setq form-descri
(if (unwind-protect (setq value-2 (apply fn-0 args-1)) (setq form-de
(let (form-description-4) (if (unwind-protect (setq value-2 (apply f
(let ((value-2 'ert-form-evaluation-aborted-3)) (let (form-descripti
(let* ((fn-0 #'equal) (args-1 (condition-case err (let ((signal-hook
(closure (t) nil (let* ((fn-0 #'equal) (args-1 (condition-case err (
ert--run-test-internal(#s(ert--test-execution-info :test #s(ert-test
ert-run-test(#s(ert-test :name finalizer-object-type :documentation
ert-run-or-rerun-test(#s(ert--stats :selector (not (or (tag :unstabl
ert-run-tests((not (or (tag :unstable) (tag :nativecomp))) #f(compil
ert-run-tests-batch((not (or (tag :unstable) (tag :nativecomp))))
ert-run-tests-batch-and-exit((not (or (tag :unstable) (tag :nativeco
eval((ert-run-tests-batch-and-exit '(not (or (tag :unstable) (tag :n
command-line-1(("-L" ":." "-L" "./../../elpa/packages/url-http-ntlm/
command-line()
normal-top-level()
Test finalizer-object-type condition:
(wrong-type-argument functionp nil)
FAILED 2/5 finalizer-object-type (0.000099 sec)
passed 3/5 record-1 (0.000070 sec)
passed 4/5 record-2 (0.000042 sec)
passed 5/5 record-3 (0.000050 sec)
Ran 5 tests, 4 results as expected, 1 unexpected (2021-12-31 13:19:55+0100, 0.111531 sec)
1 unexpected results:
FAILED finalizer-object-type
--8<---------------cut here---------------end--------------->8---
Best regards, Michael.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-12-31 15:51 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <164092777246.5319.12726126534253040404@vcs2.savannah.gnu.org>
[not found] ` <20211231051612.BC467C002EE@vcs2.savannah.gnu.org>
2021-12-31 12:24 ` master 291085a2a6: (Fmake_finalizer): Check the arg is a function Michael Albinus
2021-12-31 15:51 ` Lars Ingebrigtsen
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.