From: Robert Pluim <rpluim@gmail.com>
To: "João Távora" <joaotavora@gmail.com>
Cc: Brian Leung <leungbk@posteo.net>,
Lars Ingebrigtsen <larsi@gnus.org>,
53853@debbugs.gnu.org
Subject: bug#53853: [PATCH] Don't use string-replace in flymake
Date: Tue, 08 Feb 2022 16:07:33 +0100 [thread overview]
Message-ID: <87h7995rd6.fsf@gmail.com> (raw)
In-Reply-To: <CALDnm51NKYpzCp6aWcWKcOm59SZ48GZpp3aOpj4uPdQ55ejPvw@mail.gmail.com> ("João Távora"'s message of "Tue, 8 Feb 2022 14:09:34 +0000")
[-- Attachment #1: Type: text/plain, Size: 779 bytes --]
>>>>> On Tue, 8 Feb 2022 14:09:34 +0000, João Távora <joaotavora@gmail.com> said:
João> Well, technically, I did "show the patch" even though I didn't author said
João> patch myself. I answered:
>> It would seem that the right thing to do is to keep 26.1 dep and do what
João> Guillaume Pasquet suggests:
>> "or substitute the `string-replace` call with `replace-regexp-in-string`
João> to maintain compatibility as I have done here:
>>
João> https://github.com/Etenil/flymake/commit/9f5f76907b1c258645f65728dd71e7cacffe6d22
João> Anyway, all good now, just bring the Emacs dep down to 26.1. Thanks.
Just so weʼre all clear, we want this in emacs-28 (on top of Lars's
change to use `replace-regexp-in-string'?
[-- Attachment #2: 0001-Mark-flymake-as-compatible-with-emacs-26.1.patch --]
[-- Type: text/x-diff, Size: 1111 bytes --]
From 31af9bca99fa88350271e1a905c9b435eaec28cf Mon Sep 17 00:00:00 2001
From: Robert Pluim <rpluim@gmail.com>
Date: Tue, 8 Feb 2022 16:04:15 +0100
Subject: [PATCH] Mark flymake as compatible with emacs-26.1
To: emacs-devel@gnu.org
* lisp/progmodes/flymake.el: Bump package version and set
emacs version in Package-Requires to 26.1 (Bug#53853).
---
lisp/progmodes/flymake.el | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/lisp/progmodes/flymake.el b/lisp/progmodes/flymake.el
index e369cb1f21..83d7bc8641 100644
--- a/lisp/progmodes/flymake.el
+++ b/lisp/progmodes/flymake.el
@@ -4,9 +4,9 @@
;; Author: Pavel Kobyakov <pk_at_work@yahoo.com>
;; Maintainer: João Távora <joaotavora@gmail.com>
-;; Version: 1.2.1
+;; Version: 1.2.2
;; Keywords: c languages tools
-;; Package-Requires: ((emacs "28.1") (eldoc "1.1.0") (project "0.7.1"))
+;; Package-Requires: ((emacs "26.1") (eldoc "1.1.0") (project "0.7.1"))
;; This is a GNU ELPA :core package. Avoid functionality that is not
;; compatible with the version of Emacs recorded above.
--
2.34.0
[-- Attachment #3: Type: text/plain, Size: 12 bytes --]
Robert
--
next prev parent reply other threads:[~2022-02-08 15:07 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-07 16:11 bug#53853: [PATCH] Don't use string-replace in flymake Brian Leung
2022-02-07 17:32 ` Robert Pluim
2022-02-08 2:17 ` Brian Leung
2022-02-08 6:16 ` Lars Ingebrigtsen
2022-02-08 8:21 ` Robert Pluim
2022-02-08 8:28 ` Brian Leung
2022-02-08 8:35 ` Robert Pluim
2022-02-08 9:20 ` João Távora
2022-02-08 9:50 ` Robert Pluim
2022-02-08 9:54 ` João Távora
2022-02-08 9:58 ` João Távora
2022-02-08 13:03 ` Eli Zaretskii
2022-02-08 13:18 ` João Távora
2022-02-08 13:54 ` Eli Zaretskii
2022-02-08 14:09 ` João Távora
2022-02-08 15:07 ` Robert Pluim [this message]
2022-02-08 15:30 ` João Távora
2022-02-08 15:47 ` Robert Pluim
2022-02-08 15:51 ` João Távora
2022-02-08 16:02 ` Robert Pluim
2022-02-08 16:43 ` João Távora
2022-02-08 17:02 ` Robert Pluim
2022-02-08 17:55 ` Dmitry Gutov
2022-02-08 17:08 ` Dmitry Gutov
2022-02-09 8:55 ` Robert Pluim
2022-02-08 9:52 ` João Távora
2022-02-08 10:19 ` Robert Pluim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87h7995rd6.fsf@gmail.com \
--to=rpluim@gmail.com \
--cc=53853@debbugs.gnu.org \
--cc=joaotavora@gmail.com \
--cc=larsi@gnus.org \
--cc=leungbk@posteo.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.