[NonGNU] New package: ctrlf and Questions

[NonGNU] New package: ctrlf and Questions

[Jai Flack]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: 0001-elpa-packages-ctrlf-New-package.patch --]
[-- Type: text/x-diff, Size: 760 bytes --]

From 6ed94e13b3536ad6adc14c8be62971a004a64bdd Mon Sep 17 00:00:00 2001
From: Jai Flack <jflack@disroot.org>
Date: Wed, 23 Feb 2022 12:53:28 +1000
Subject: [PATCH] * elpa-packages (ctrlf): New package

---
 elpa-packages | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/elpa-packages b/elpa-packages
index fc0a508ae9..520e553dbb 100644
--- a/elpa-packages
+++ b/elpa-packages
@@ -81,6 +81,11 @@
   :readme "README.md"
   :news "CHANGELOG.md")
 
+ ("ctrlf"		:url "https://github.com/raxod502/ctrlf"
+  :readme "README.md"
+  :news "CHANGELOG.md"
+  :ignored-files ("scripts" "Dockerfile" "Makefile"))
+
  ("cyberpunk-theme"	:url "https://github.com/n3mo/cyberpunk-theme.el"
   :ignored-files ("cyberpunk-theme.png" "example-org-file.org"))
 
-- 
2.30.2


[-- Attachment #2: Type: text/plain, Size: 437 bytes --]

Greetings emacs-devel.

Apologies if these questions have been answered before.

I would like to submit a package `ctrlf' [1] for NonGNU ELPA (patch
attached). Previously I completed the copyright assignment for Emacs, is
a different assignment required for this?

Also I have many more packages to submit; is it preferable for me to
bulk-attach these patches into a single email?

[1] https://github.com/raxod502/ctrlf

-- 
Thanks,
Jai

[NonGNU] New package: ctrlf and Questions

[jflack]

[-- Attachment #1: Type: text/plain, Size: 453 bytes --]

Greetings emacs-devel.

Apologies if these questions have been answered before.

I would like to submit a package `ctrlf' [1] for NonGNU ELPA (patch
attached). Previously I completed the copyright assignment for Emacs, is
a different assignment required for this?

Also I have many more packages to submit; is it preferable for me to
bulk-attach these patches into a single email?

[1] https://github.com/raxod502/ctrlf

-- 
Thanks,
Jai

[-- Attachment #2: 0001-elpa-packages-ctrlf-New-package.patch --]
[-- Type: application/octet-stream, Size: 760 bytes --]

From 6ed94e13b3536ad6adc14c8be62971a004a64bdd Mon Sep 17 00:00:00 2001
From: Jai Flack <jflack@disroot.org>
Date: Wed, 23 Feb 2022 12:53:28 +1000
Subject: [PATCH] * elpa-packages (ctrlf): New package

---
 elpa-packages | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/elpa-packages b/elpa-packages
index fc0a508ae9..520e553dbb 100644
--- a/elpa-packages
+++ b/elpa-packages
@@ -81,6 +81,11 @@
   :readme "README.md"
   :news "CHANGELOG.md")
 
+ ("ctrlf"		:url "https://github.com/raxod502/ctrlf"
+  :readme "README.md"
+  :news "CHANGELOG.md"
+  :ignored-files ("scripts" "Dockerfile" "Makefile"))
+
  ("cyberpunk-theme"	:url "https://github.com/n3mo/cyberpunk-theme.el"
   :ignored-files ("cyberpunk-theme.png" "example-org-file.org"))
 
-- 
2.30.2

Re: [NonGNU] New package: ctrlf and Questions

[Augusto Stoffel]

FWIW, a similar package already exists on ELPA:

    https://elpa.gnu.org/packages/isearch-mb.html

The main difference to Ctrlf being that isearch-mb integrates with
isearch instead of reinventing it (and therefore is much smaller than
Ctrlf).

On Wed, 23 Feb 2022 at 11:56, jflack@disroot.org wrote:

> Greetings emacs-devel.
>
> Apologies if these questions have been answered before.
>
> I would like to submit a package `ctrlf' [1] for NonGNU ELPA (patch
> attached). Previously I completed the copyright assignment for Emacs, is
> a different assignment required for this?
>
> Also I have many more packages to submit; is it preferable for me to
> bulk-attach these patches into a single email?
>
> [1] https://github.com/raxod502/ctrlf

Re: [NonGNU] New package: ctrlf and Questions

[Philip Kaludercic]

Augusto Stoffel <arstoffel@gmail.com> writes:

> FWIW, a similar package already exists on ELPA:
>
>     https://elpa.gnu.org/packages/isearch-mb.html
>
> The main difference to Ctrlf being that isearch-mb integrates with
> isearch instead of reinventing it (and therefore is much smaller than
> Ctrlf).

Is there any advantage that Ctrlf has over isearch-mb?  If not, I don't
see why the more complex package is needed at all?

> On Wed, 23 Feb 2022 at 11:56, jflack@disroot.org wrote:
>
>> Greetings emacs-devel.
>>
>> Apologies if these questions have been answered before.
>>
>> I would like to submit a package `ctrlf' [1] for NonGNU ELPA (patch
>> attached). Previously I completed the copyright assignment for Emacs, is
>> a different assignment required for this?
>>
>> Also I have many more packages to submit; is it preferable for me to
>> bulk-attach these patches into a single email?
>>
>> [1] https://github.com/raxod502/ctrlf
>
>

-- 
	Philip Kaludercic

Re: [NonGNU] New package: ctrlf and Questions

[Augusto Stoffel]

On Wed, 23 Feb 2022 at 19:40, Philip Kaludercic <philipk@posteo.net> wrote:

> Augusto Stoffel <arstoffel@gmail.com> writes:
>
>> FWIW, a similar package already exists on ELPA:
>>
>>     https://elpa.gnu.org/packages/isearch-mb.html
>>
>> The main difference to Ctrlf being that isearch-mb integrates with
>> isearch instead of reinventing it (and therefore is much smaller than
>> Ctrlf).
>
> Is there any advantage that Ctrlf has over isearch-mb?  If not, I don't
> see why the more complex package is needed at all?

I'm not aware of any advantages (otherwise I could extend isearch-mb or,
more likely, isearch itself).  OTOH there is nothing wrong with
providing (a sensible number of) alternative implementations of the same
idea; in fact, isearch-mb was inspired by Ctrlf.  So I don't have a
strong opinion about this.

>
>> On Wed, 23 Feb 2022 at 11:56, jflack@disroot.org wrote:
>>
>>> Greetings emacs-devel.
>>>
>>> Apologies if these questions have been answered before.
>>>
>>> I would like to submit a package `ctrlf' [1] for NonGNU ELPA (patch
>>> attached). Previously I completed the copyright assignment for Emacs, is
>>> a different assignment required for this?
>>>
>>> Also I have many more packages to submit; is it preferable for me to
>>> bulk-attach these patches into a single email?
>>>
>>> [1] https://github.com/raxod502/ctrlf
>>
>>

Re: [NonGNU] New package: ctrlf and Questions

[Jai Flack]

Augusto Stoffel <arstoffel@gmail.com> writes:

> On Wed, 23 Feb 2022 at 19:40, Philip Kaludercic <philipk@posteo.net> wrote:
>
>> Augusto Stoffel <arstoffel@gmail.com> writes:
>>
>>> FWIW, a similar package already exists on ELPA:
>>>
>>>     https://elpa.gnu.org/packages/isearch-mb.html
>>>
>>> The main difference to Ctrlf being that isearch-mb integrates with
>>> isearch instead of reinventing it (and therefore is much smaller than
>>> Ctrlf).

Thanks for pointing me to isearch-mb.

>> Is there any advantage that Ctrlf has over isearch-mb?  If not, I don't
>> see why the more complex package is needed at all?

It's nice how ctrlf presents the count at the end of the matching line
(not just in the minibuffer) but apart from that they seem to have the
same feature set.

> I'm not aware of any advantages (otherwise I could extend isearch-mb or,
> more likely, isearch itself).  OTOH there is nothing wrong with
> providing (a sensible number of) alternative implementations of the same
> idea; in fact, isearch-mb was inspired by Ctrlf.  So I don't have a
> strong opinion about this.

I no longer wish for ctrlf to be added but feel free to add it if
someone else wants it.

-- 
Thanks,
Jai

Re: [NonGNU] New package: ctrlf and Questions

[Augusto Stoffel]

On Thu, 24 Feb 2022 at 20:36, Jai Flack <jflack@disroot.org> wrote:

> It's nice how ctrlf presents the count at the end of the matching line
> (not just in the minibuffer) but apart from that they seem to have the
> same feature set.

This feature is unrelated to isearch-mb, which focuses narrowly on how
the search string is read.  It's also probably too eccentric to include
in isearch itself (but I don't know what others actually think).  And it
seems a bit too small to become a package by itself.

I'm not quite sure what then answer is to these considerations.  But let
me mention that there's a wiki on the isearch-mb Github repo that can be
used to share tips and tricks like this one.

Re: [NonGNU] New package: ctrlf and Questions

[Stefan Monnier]

Augusto Stoffel [2022-02-26 12:02:37] wrote:
> On Thu, 24 Feb 2022 at 20:36, Jai Flack <jflack@disroot.org> wrote:
>> It's nice how ctrlf presents the count at the end of the matching line
>> (not just in the minibuffer) but apart from that they seem to have the
>> same feature set.
> This feature is unrelated to isearch-mb, which focuses narrowly on how
> the search string is read.  It's also probably too eccentric to include
> in isearch itself (but I don't know what others actually think).  And it
> seems a bit too small to become a package by itself.

If it's not for everyone, then it should arguably be provided under the
control of the config var, but that doesn't mean it should be in
a separate package or relegated to some ELisp snippets for people to
copy&paste into their init file.

Whether it better belongs alongside `isearch` or `isearch-mb` will
probably depend on details of how it's implemented.


        Stefan

Re: [NonGNU] New package: ctrlf and Questions

[Jai Flack]

Augusto Stoffel <arstoffel@gmail.com> writes:

> I'm not quite sure what then answer is to these considerations.  But let
> me mention that there's a wiki on the isearch-mb Github repo that can be
> used to share tips and tricks like this one.

When I have time I'll look at how this could be implemented. If it's
short maybe it could be included as one of those tricks.

-- 
Thanks,
Jai