From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Augusto Stoffel Newsgroups: gmane.emacs.devel Subject: Re: ELPA package submission: buffer-env Date: Mon, 28 Feb 2022 20:54:17 +0100 Message-ID: <87h78iu5qu.fsf@gmail.com> References: <87sfs2u8jh.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="34715"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.91 (gnu/linux) Cc: emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Feb 28 20:56:09 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nOm7t-0008mE-R6 for ged-emacs-devel@m.gmane-mx.org; Mon, 28 Feb 2022 20:56:09 +0100 Original-Received: from localhost ([::1]:52886 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nOm7s-0000Ry-K5 for ged-emacs-devel@m.gmane-mx.org; Mon, 28 Feb 2022 14:56:08 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:44096) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nOm69-0007sK-QN for emacs-devel@gnu.org; Mon, 28 Feb 2022 14:54:23 -0500 Original-Received: from [2a00:1450:4864:20::632] (port=43655 helo=mail-ej1-x632.google.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nOm68-0003cf-AZ for emacs-devel@gnu.org; Mon, 28 Feb 2022 14:54:21 -0500 Original-Received: by mail-ej1-x632.google.com with SMTP id d10so27026475eje.10 for ; Mon, 28 Feb 2022 11:54:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=mdJQiHh4GFemavO7dS2kxFR7SWHPPnv2bZvNHKOi03s=; b=WDR89GqgxxZ8gtYh70NHxx5TJ8Ehzglh3kaICtmZBdvjGvV/ILl1reIW7TQTq38DDN JK3ljnSfphotuQXzGUPnKRp2z7Vo7gwAnCbt2WIVbGhoFY4RibIuvZO+E8Jy1VjHRkHa D96KgenlJ/6qMREPafWsEhTRu8x+Qc+m3AkZzEoIhemskhQNoAOFfdBQtv2MvRxBAdVY QCAJrlyu1xz9SAPsdWZ+fCOYt+Yi33azFHLPLeaAWSiWHZM0d1Ut/aRj0lB94GyGamax pfyXrZpzr3aUQfSOauI1nYGKniRgSQxukeuqukmoDxQ6Tz3Y6wCPc9TNfnqyqAj8fdD+ ZeVQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=mdJQiHh4GFemavO7dS2kxFR7SWHPPnv2bZvNHKOi03s=; b=0UedhomC6NmszQH2IVWExMbIQGXtucvmuM+ch67KrPs1Bw55Sb14eSBRyWZ1kkWtVG EruCVwxsnMHcfljPr3xPzHomiNlsgwUvjwrfMV+32dw4m1b23m5l1VnPeeHt34/N2p64 QXLdruq8rpiky3wbb3lEzzPnqHJ7urDQHuIK3HWgJkMdflVizuX8qRUXzsd38ftiDaFG /u36S3p4qoeNU+G4AbmEvW+y2nuTHG268poUG0EmCiagA6M09BBCr3tjxV+s03OnTp+b 1ijl3B79SH+9ND7ZPqtGmqnP2ecsOn0YyMz8ddzSvy8Zs3MvDRWg/ffzvgK+uheuSq65 5IBA== X-Gm-Message-State: AOAM532+WI+XK3QRX31LeqCYOgOCb9c/+0VzblgGzNaDwhQREOaTpucB 3rE5Gbskst4N15sQmHBccgrSMWT11wc= X-Google-Smtp-Source: ABdhPJxsO9PNjGLzrAmhH52T2wd8oP02VWZrJfImIz4O3Qd/IxlIrrCXzOakA+egs6cEEkEqKMexEw== X-Received: by 2002:a17:906:4cd2:b0:6c8:7a90:9c7 with SMTP id q18-20020a1709064cd200b006c87a9009c7mr16345034ejt.439.1646078058570; Mon, 28 Feb 2022 11:54:18 -0800 (PST) Original-Received: from ars3 ([2a02:8109:8ac0:56d0::758e]) by smtp.gmail.com with ESMTPSA id a25-20020a50ff19000000b0040f84cd806csm6330255edu.59.2022.02.28.11.54.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 28 Feb 2022 11:54:18 -0800 (PST) In-Reply-To: (Stefan Monnier's message of "Mon, 28 Feb 2022 14:40:43 -0500") X-Host-Lookup-Failed: Reverse DNS lookup failed for 2a00:1450:4864:20::632 (failed) Received-SPF: pass client-ip=2a00:1450:4864:20::632; envelope-from=arstoffel@gmail.com; helo=mail-ej1-x632.google.com X-Spam_score_int: -6 X-Spam_score: -0.7 X-Spam_bar: / X-Spam_report: (-0.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, PDS_HP_HELO_NORDNS=0.659, RCVD_IN_DNSWL_NONE=-0.0001, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:286736 Archived-At: On Mon, 28 Feb 2022 at 14:40, Stefan Monnier wrote: > The default value for `buffer-env-command` is a gaping security hole, tho. > Any hope we can make this a bit less dangerous? I think it's already made sufficiently tame: before running any given version of an .envrc script, you have to explicitly say yes. Then a hash of the script contents is saved in a custom variable, so the second time you run the same script you don't need to confirm. I copied that idea from the direnv program, so I want to believe that any security holes should be due to bad implementation rather than a bad concept.