From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Michael Heerdegen Newsgroups: gmane.emacs.devel Subject: Re: [ELPA] propose to add vundo.el to ELPA Date: Fri, 08 Apr 2022 00:58:11 +0200 Message-ID: <87h774xzzw.fsf@web.de> References: <15F35A7C-7A15-4B1E-8959-612C10166242@gmail.com> <875ynonqmc.fsf@web.de> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="17278"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: emacs-devel@gnu.org To: Yuan Fu Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Apr 08 00:58:57 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ncb5d-0004Mo-ES for ged-emacs-devel@m.gmane-mx.org; Fri, 08 Apr 2022 00:58:57 +0200 Original-Received: from localhost ([::1]:48626 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ncb5c-0003qg-F8 for ged-emacs-devel@m.gmane-mx.org; Thu, 07 Apr 2022 18:58:56 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:56108) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ncb4z-00039o-VA for emacs-devel@gnu.org; Thu, 07 Apr 2022 18:58:17 -0400 Original-Received: from mout.web.de ([212.227.15.4]:40623) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ncb4y-0000o3-5k for emacs-devel@gnu.org; Thu, 07 Apr 2022 18:58:17 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de; s=dbaedf251592; t=1649372292; bh=ROZNq9/BiVgH0//UM+QUcMrpKMZLsgBWPu3ukA+OWo0=; h=X-UI-Sender-Class:From:To:Cc:Subject:References:Date:In-Reply-To; b=AfJhUfx56pgNRIjnwjzxPN4QfdugONqwIEE3j1uQIMO+ordfsmeDRqDwx4T8LXFpi DvZWWpkazutzZmQSH5od+fx8/kXBV+LymVGEkBLGLt1LA8SsQeKp6y9fGdfirBZzc9 zSo4LxMJMhMEiKTUyLbuecgxMBb3DpFJX4DQQgsU= X-UI-Sender-Class: c548c8c5-30a9-4db5-a2e7-cb6cb037b8f9 Original-Received: from drachen.dragon ([84.59.210.63]) by smtp.web.de (mrweb006 [213.165.67.108]) with ESMTPSA (Nemesis) id 1MqqPN-1oOq8o3K65-00mSan; Fri, 08 Apr 2022 00:58:11 +0200 In-Reply-To: (Yuan Fu's message of "Tue, 5 Apr 2022 21:20:35 -0700") X-Provags-ID: V03:K1:SKQSAlQycQX403GMDVAhlZ4k/9xLw/0nthhJdksJpjz0IjTkUq0 tfyWTcifTYSDUC2osRljJuBYhTW5SKOnkh8+lDzrfCUjLRwNoBDan/zPl7wVlrD/3ZEQvK0 fHMMVJjNudXSBNDKRglLLoDEwFsgKTiaHB2PTdGCvkagRftbH90zTIBu5Lmqhvl5QDSGBA5 SsBjZ7Ru/rtxVkT/wurxg== X-UI-Out-Filterresults: notjunk:1;V03:K0:fdsuzj8amt0=:0osSN2e/3b8q6au5rOGK3/ imXTkLhPVRNwYrINsIJLk/FuxM1DMmwBMzRSbRsWUxNRhdUax6yUHrIUqjJ28u/DceCMtZDyy /WTKzL5gqw5UzbWwJdr/x1dAs5duvxbuDLgzNgqtT7XuET+qM9YGUHTZt1Kjz1aQaRUje2l2k QrYgGMO/swOkcljI9XxQWX/SYqud+JyKYtx3xPFgSXopnpMDryBe1fRaWMVfuw5/817R/rTCJ X+jwyMyWC6Cz39fDEJmsi2J78z1kP4Jw7VcbTU5qRPXmO5yo3+ph88Z/LRwo86ZGdkuInjHC6 o33sYGwTr6LyqJb05kplFGkeCf0kBGxi78kz7T9a8Oviae50HcZBq96IeoAyJyBAdT17otbvh LXjR/bVliFjv/UREe3ruEATNStxRIu4hC0d6/P3XhsMBEnkGUpRnlgkk1zKrl4BXIORvBeLcE 9kIyQeoHGIBd2CtC9uXUyZmjxBPPhiDC3sK5DGRAQkp7fRKpY6GuW01xtaMmr1+yxyc02saLf 2wawDUiR1GvGkCWQFUmrYkdYy/2o8hGNHJEGhL/dsuz1rnRksVV5iuUPhHxB0zM9rwku6Pjyn e9mfOBpVw4KTib5U2N/8Y5So2dqInxkSBw/Uy7YUCTvNK1Ix6aAowTuFKmDTj+Ox88Vi5715v sSlc6CJDbx+bJHyadM96Ga+5oA9c3ZRJj0zZNhHo43/HQS+Ry0PGGSgFckmgHc20rgHyk8Mxr MoDM2CNoax+OtsbYdTazlFXVNbb497tvgWL2W2kQwRDWcsdFgnZjwV4BCVO67C3ZkiwPGxXY Received-SPF: pass client-ip=212.227.15.4; envelope-from=michael_heerdegen@web.de; helo=mout.web.de X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:287906 Archived-At: --=-=-= Content-Type: text/plain Yuan Fu writes: > Thanks, applied! Ok, 3 little more: --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=0001-Three-more-tyos.patch Content-Transfer-Encoding: quoted-printable =46rom 2820d87b9d10f87921677560aae141a8dd43f6d4 Mon Sep 17 00:00:00 2001 From: Michael Heerdegen Date: Fri, 8 Apr 2022 00:43:20 +0200 Subject: [PATCH] Three more tyos =2D-- vundo.el | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/vundo.el b/vundo.el index f16df2e..4de45de 100644 =2D-- a/vundo.el +++ b/vundo.el @@ -91,12 +91,12 @@ ;; `vundo-m' object corresponding to it. Once we have the mod-list and ;; hash table, we connect the nodes in mod-list to form a tree in ;; `vundo--build-tree'. We build the tree by a simple observation: -;; only non-undo modifications creates new unique buffer states and +;; Only non-undo modifications create new unique buffer states and ;; need to be drawn in the tree. For undo modifications, they -;; associates equivalent nodes. +;; associate equivalent nodes. ;; ;; Once we have generated the data structure and drawn the tree, vundo -;; commands can move around on that tree by calling +;; commands can move around in that tree by calling ;; `vundo--move-to-node'. It will construct the correct undo-list and ;; feed it to `primitive-undo'. `vundo--trim-undo-list' can trim the ;; undo list when possible. =2D- 2.30.2 --=-=-= Content-Type: text/plain Some more ideas/thoughts: (1) If you use `vundo' for the first time in a buffer with an already very large undo list, do you expect a delay? Would it make sense to limit the processing of `buffer-undo-list' to the last N entries to avoid such a delay (N would probably be a user option)? (2) I wonder which setup I will prefer in the future. I'm using the commands that already "fold" the undo list (AFAIU, in the same or a similar sense as vundo does): `undo-only' and `undo-redo'. Do these commands directly correspond to hitting right and left in the vundo buffer? If yes, I think it would be cool to setup stuff that the keys I use for `undo-only' and `undo-redo' would work like now but additionally start vundo. And the same keys would still work in vundo and call vundo-backward and vundo-forwar, additionally to the existing bindings. I think that could feel convenient. Would such a setup make sense to you? Thanks, Michael. --=-=-=--