From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Andreas Schwab Newsgroups: gmane.emacs.bugs Subject: bug#54921: eww/url mishandles IDN over proxy Date: Thu, 14 Apr 2022 19:39:18 +0200 Message-ID: <87h76vy37d.fsf@igel.home> References: <87bkx44q3v.fsf@igel.home> <87czhko3xg.fsf@gnus.org> <87bkx4yw98.fsf@igel.home> <87tuavn6vx.fsf@gnus.org> <877d7rzs92.fsf@igel.home> <87wnfrlqfx.fsf@gnus.org> <8735ifzr9q.fsf@igel.home> <874k2vlpim.fsf@gnus.org> <87tuavy8a8.fsf@igel.home> <87mtgnk6dn.fsf@gnus.org> <87pmljy7mt.fsf@igel.home> <87h76vk5m9.fsf@gnus.org> <87lew7y5po.fsf@igel.home> <874k2vk2p3.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="23839"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux) Cc: 54921@debbugs.gnu.org To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Apr 14 19:40:39 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nf3SI-0005cp-Bd for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 14 Apr 2022 19:40:30 +0200 Original-Received: from localhost ([::1]:57748 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nf3SH-0007Ad-BX for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 14 Apr 2022 13:40:29 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:53850) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nf3Rq-0007AC-VZ for bug-gnu-emacs@gnu.org; Thu, 14 Apr 2022 13:40:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:35162) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nf3Rq-0002rd-Ew for bug-gnu-emacs@gnu.org; Thu, 14 Apr 2022 13:40:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nf3Rq-0006Ox-AD for bug-gnu-emacs@gnu.org; Thu, 14 Apr 2022 13:40:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Andreas Schwab Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 14 Apr 2022 17:40:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 54921 X-GNU-PR-Package: emacs Original-Received: via spool by 54921-submit@debbugs.gnu.org id=B54921.164995796324550 (code B ref 54921); Thu, 14 Apr 2022 17:40:02 +0000 Original-Received: (at 54921) by debbugs.gnu.org; 14 Apr 2022 17:39:23 +0000 Original-Received: from localhost ([127.0.0.1]:57292 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nf3RC-0006Ns-OU for submit@debbugs.gnu.org; Thu, 14 Apr 2022 13:39:22 -0400 Original-Received: from mail-out.m-online.net ([212.18.0.9]:48832) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nf3RB-0006Nf-3R for 54921@debbugs.gnu.org; Thu, 14 Apr 2022 13:39:21 -0400 Original-Received: from frontend01.mail.m-online.net (unknown [192.168.8.182]) by mail-out.m-online.net (Postfix) with ESMTP id 4KfRXl4FDTz1qy4d; Thu, 14 Apr 2022 19:39:19 +0200 (CEST) Original-Received: from localhost (dynscan1.mnet-online.de [192.168.6.70]) by mail.m-online.net (Postfix) with ESMTP id 4KfRXl42RCz1qqkB; Thu, 14 Apr 2022 19:39:19 +0200 (CEST) X-Virus-Scanned: amavisd-new at mnet-online.de Original-Received: from mail.mnet-online.de ([192.168.8.182]) by localhost (dynscan1.mail.m-online.net [192.168.6.70]) (amavisd-new, port 10024) with ESMTP id JUm2blo281L5; Thu, 14 Apr 2022 19:39:18 +0200 (CEST) X-Auth-Info: E3gWNZiiGoTgJVbQ7Tkdojfn1gwjQmuL4UMDTd4eNc+s6J2IhqlVci+HGJfDXJEL Original-Received: from igel.home (ppp-46-244-164-67.dynamic.mnet-online.de [46.244.164.67]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.mnet-online.de (Postfix) with ESMTPSA; Thu, 14 Apr 2022 19:39:18 +0200 (CEST) Original-Received: by igel.home (Postfix, from userid 1000) id 630C52C39B0; Thu, 14 Apr 2022 19:39:18 +0200 (CEST) X-Yow: ..Wait 'til those ITALIAN TEENAGERS get back to their HONDAS & discover them to be FILLED to the BRIM with MAZOLA!! In-Reply-To: <874k2vk2p3.fsf@gnus.org> (Lars Ingebrigtsen's message of "Thu, 14 Apr 2022 19:14:00 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:229894 Archived-At: On Apr 14 2022, Lars Ingebrigtsen wrote: > So it is. Then I have no idea where the Host in the http case is coming > from. I'd have thought that the proxy would just look at the Host > header (which should be puny-encoded), but I don't know much about http > proxying. The proxy just receives the full URL in the GET request. Something like this, but puny-encode-domain must only be called with the domain name. diff --git a/lisp/url/url-http.el b/lisp/url/url-http.el index daeba17031..c59613da62 100644 --- a/lisp/url/url-http.el +++ b/lisp/url/url-http.el @@ -332,7 +332,8 @@ url-http-create-request (if (and using-proxy ;; Bug#35969. (not (equal "https" (url-type url-http-target-url)))) - (url-recreate-url url-http-target-url) real-fname)) + (puny-encode-domain (url-recreate-url url-http-target-url)) + real-fname)) " HTTP/" url-http-version "\r\n" ;; Version of MIME we speak "MIME-Version: 1.0\r\n" -- Andreas Schwab, schwab@linux-m68k.org GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1 "And now for something completely different."