Re: master b38c3fe863: Check whether we can restart in Fkill_emacs

Re: master b38c3fe863: Check whether we can restart in Fkill_emacs

[Po Lu]

Lars Ingebrigtsen <larsi@gnus.org> writes:

> branch: master
> commit b38c3fe8632ec0ee4f180dae2938959bd8b4c46e
> Author: Lars Ingebrigtsen <larsi@gnus.org>
> Commit: Lars Ingebrigtsen <larsi@gnus.org>
>
>     Check whether we can restart in Fkill_emacs
>     
>     * src/emacs.c (Fkill_emacs): Report an error if we can't restart.
> ---
>  src/emacs.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/src/emacs.c b/src/emacs.c
> index 50b1628d20..173e8e8923 100644
> --- a/src/emacs.c
> +++ b/src/emacs.c
> @@ -2807,7 +2807,8 @@ killed.  */
>  
>    if (!NILP (restart))
>      {
> -      execvp (*initial_argv, initial_argv);
> +      if (execvp (*initial_argv, initial_argv) < 1)
> +	error ("Unable to re-execute Emacs");
>      }
>  
>    if (FIXNUMP (arg))

What if initial_argc was set to 0?  Linux and several other Unix-like
kernels allow executing binaries without any arguments at all.

Re: master b38c3fe863: Check whether we can restart in Fkill_emacs

[Lars Ingebrigtsen]

Po Lu <luangruo@yahoo.com> writes:

> What if initial_argc was set to 0?  Linux and several other Unix-like
> kernels allow executing binaries without any arguments at all.

Yes, that's true.  I've now added a check.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no