From: James N. V. Cash <james.nvc@gmail.com>
To: emacs-devel@gnu.org
Subject: Re: [PATCH] Handle case where `beg` and `end` are strings instead of markers
Date: Thu, 28 Apr 2022 21:10:32 -0400 [thread overview]
Message-ID: <87h76c4ruf.fsf@occasionallycogent.com> (raw)
In-Reply-To: <87k0b84tfr.fsf@occasionallycogent.com>
"James N. V. Cash" <james.nvc@gmail.com> writes:
> With the changes to pass affixes to the completion functions, the
> begin and end points passed to the completion function are now
> sometimes strings instead of numbers or markers. This handles that
> case by searching for said prefix and suffix.
>
> Without this, completion functions that call `completion--replace` error
> out -- for example, completing tags in org-mode.
Hm, while my patch does fix the error I was seeing, it makes completing
multiple items with completing-read-multiple not properly insert
subsequent completions.
I also note that I only saw the aberrant behaviour while using functions
that used CRM, so perhaps there's a more underlying cause and/or better
place to fix this.
James
next prev parent reply other threads:[~2022-04-29 1:10 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-29 0:36 [PATCH] Handle case where `beg` and `end` are strings instead of markers James N. V. Cash
2022-04-29 1:10 ` James N. V. Cash [this message]
2022-04-29 7:05 ` Juri Linkov
2022-04-29 12:10 ` James N. V. Cash
2022-04-29 12:55 ` Stefan Monnier
2022-04-29 14:07 ` James N. V. Cash
2022-04-29 16:18 ` Stefan Monnier
2022-04-29 17:20 ` James N. V. Cash
2022-04-29 17:29 ` Juri Linkov
2022-04-29 21:05 ` Stefan Monnier
2022-04-30 12:41 ` James N. V. Cash
2022-04-30 13:44 ` Stefan Monnier
2022-04-30 15:48 ` James N. V. Cash
2022-05-01 18:06 ` Juri Linkov
2022-05-02 15:32 ` James N. V. Cash
2022-05-02 19:11 ` Juri Linkov
2022-05-04 12:08 ` James N. V. Cash
2022-05-04 19:27 ` Juri Linkov
2022-05-04 21:09 ` James N. V. Cash
2022-05-05 18:16 ` Juri Linkov
2022-05-01 18:03 ` Juri Linkov
2022-05-01 18:37 ` Stefan Monnier
2022-05-05 18:19 ` Juri Linkov
2022-05-05 18:30 ` Exiting completion-in-region-mode (was: Handle case where `beg` and `end` are strings instead of markers) Juri Linkov
2022-05-19 18:52 ` Exiting completion-in-region-mode Juri Linkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87h76c4ruf.fsf@occasionallycogent.com \
--to=james.nvc@gmail.com \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.