From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Visuwesh Newsgroups: gmane.emacs.bugs Subject: bug#55393: describe-keymap: suggest symbol at point Date: Fri, 13 May 2022 12:05:42 +0530 Message-ID: <87h75u0wjl.fsf@gmail.com> References: <87pmki13i2.fsf@gmail.com> <83fslene7p.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="4572"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: 55393@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri May 13 09:28:54 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1npPjJ-00012o-Kc for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 13 May 2022 09:28:53 +0200 Original-Received: from localhost ([::1]:56478 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1npPjI-00078W-6J for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 13 May 2022 03:28:52 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:44164) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1npOv8-0004cG-2M for bug-gnu-emacs@gnu.org; Fri, 13 May 2022 02:37:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:48915) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1npOv7-0001nQ-Om for bug-gnu-emacs@gnu.org; Fri, 13 May 2022 02:37:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1npOv7-0002DL-In for bug-gnu-emacs@gnu.org; Fri, 13 May 2022 02:37:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Visuwesh Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 13 May 2022 06:37:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 55393 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 55393-submit@debbugs.gnu.org id=B55393.16524237648425 (code B ref 55393); Fri, 13 May 2022 06:37:01 +0000 Original-Received: (at 55393) by debbugs.gnu.org; 13 May 2022 06:36:04 +0000 Original-Received: from localhost ([127.0.0.1]:42812 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1npOuB-0002Bp-Se for submit@debbugs.gnu.org; Fri, 13 May 2022 02:36:04 -0400 Original-Received: from mail-pl1-f196.google.com ([209.85.214.196]:43747) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1npOuA-0002BJ-53 for 55393@debbugs.gnu.org; Fri, 13 May 2022 02:36:02 -0400 Original-Received: by mail-pl1-f196.google.com with SMTP id i17so7039524pla.10 for <55393@debbugs.gnu.org>; Thu, 12 May 2022 23:36:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=QBQmOxTzBhQKdXxz8WhK1ZrLuujDebEwpkA0am0VyQw=; b=ZNeE4YKWwL05BL0/OIG4/AHRY8BZ35weGyyEmwiOncu9SCd/qfAfcVwsXirxRJzzR7 Z/q48xQAJwT4CXVbSIc5nBGcZz7SbvIH53WAXIKT7cKaCNmGrYYbBgjKVyc18SZWRrmX SCFueydyfnuykI/uoBbOWooHtDUwHlltaTUlEIs/IaQwk5O8IgXrrvPV3QL9rG466s9u fbPDDBlK4wspkmYKCxnaIIzC9wFgQ5lZXQI3wQekkEYHYwxtIpRsx/a9ntREVBGmHLjY Ip8wdxC7dyM1g5OKjXpD0mzXFgedWTbu0AohzB4HbcoE+52cT+E5QKUCviP88wBGc4k4 RQyw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=QBQmOxTzBhQKdXxz8WhK1ZrLuujDebEwpkA0am0VyQw=; b=0I5yRc9o4RtkgI0a47cCTl977GiA8S6COr1atJKHTCw0pi9woeKbAFX1LL43Umwjl+ X0cPLn2LaSESR1wTO7MaWi7OIGQ82KwLzxlUkmM1s/YzkPcFafdyHi0QbuMJztH3DHhs 1H5OViN0xjYnWKK/bsIIrS4kW/Al3eKajDKgOKjrW5pYB/qPdqj0gX1sTOpvD3kmQ32V LeNwcUZBIROv5A0VnHHfAzKbwFqo8Tj6R89vySD//aczE2yzivY83htfK/hzWqoAavub XAl52gYuvZXUHq9AtMBuBnKhhHqyU7f5d1IphjUv3wI9s8dZ+S/LV7pnPXCUEXo2Yvpw xSSQ== X-Gm-Message-State: AOAM532SG0DDWV7W6DVU4uYgCgj/A04ljTn1eX3+R6PPkLxIVGF9AA1P oAplezLU3Uz+bApgF+H9EBc= X-Google-Smtp-Source: ABdhPJxFkT9yNCJHRe3tpPsPnkGEt89nAxyopMs44cRG2XP5U3t36c50oTm2Ed4TlPonaupxr4ucEA== X-Received: by 2002:a17:90b:164f:b0:1dc:199c:56cc with SMTP id il15-20020a17090b164f00b001dc199c56ccmr3352003pjb.177.1652423756002; Thu, 12 May 2022 23:35:56 -0700 (PDT) Original-Received: from localhost ([49.204.118.33]) by smtp.gmail.com with ESMTPSA id m13-20020a170902db0d00b0015e8d4eb2d2sm981375plx.284.2022.05.12.23.35.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 May 2022 23:35:55 -0700 (PDT) In-Reply-To: <83fslene7p.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 13 May 2022 09:23:06 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:232111 Archived-At: [=E0=AE=B5=E0=AF=86=E0=AE=B3=E0=AF=8D=E0=AE=B3=E0=AE=BF =E0=AE=AE=E0=AF=87 = 13, 2022] Eli Zaretskii wrote: >> From: Visuwesh >> Date: Fri, 13 May 2022 09:35:25 +0530 >>=20 >> describe-keymap differs from other describe-* commands in that it does >> not suggest the symbol at point which always annoyed me. This patch >> makes describe-keymap consider the symbol at point first. >>=20 >> [ I hope it is okay to use if-let family of macros in these files now? ] > > Yes, but I think a cleaner solution would be to do this kind of stuff > in the 'interactive' form of describe-keymap, instead of this > subroutine. The DWIM-ish operation of describe-SOMETHING commands is > better done there, because it doesn't really belong to non-interactive > invocations. > > Thanks. The 'interactive' form of describe-keymap uses this function. I don't see this function being used anywhere else either.