all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Michael Heerdegen <michael_heerdegen@web.de>
To: Juri Linkov <juri@linkov.net>
Cc: Paulo Sousa <de.sousa.paulus@gmail.com>, 55234@debbugs.gnu.org
Subject: bug#55234: 28.1; replace-string in rectangle regio
Date: Sat, 04 Jun 2022 15:20:45 +0200	[thread overview]
Message-ID: <87h750va36.fsf@web.de> (raw)
In-Reply-To: <86wndxwqgk.fsf@mail.linkov.net> (Juri Linkov's message of "Fri,  03 Jun 2022 21:09:31 +0300")

Juri Linkov <juri@linkov.net> writes:

>  (defun rectangle--extract-region (orig &optional delete)
>    (cond
>     ((not rectangle-mark-mode)
>      (funcall orig delete))
>     ((eq delete 'bounds)
> -    (extract-rectangle-bounds (region-beginning) (region-end)))
> +    (extract-rectangle-bounds
> +     ;; Avoid recursive calls
> +     (let (rectangle-mark-mode) (region-beginning))
> +     (let (rectangle-mark-mode) (region-end))))
>     (t
>      (let* ((strs (funcall (if delete
>                                #'delete-extract-rectangle
>                              #'extract-rectangle)
> -                          (region-beginning) (region-end)))
> +                          ;; Avoid recursive calls
> +                          (let (rectangle-mark-mode) (region-beginning))
> +                          (let (rectangle-mark-mode) (region-end))))
>             (str (mapconcat #'identity strs "\n")))
>        (when (eq last-command 'kill-region)
>          ;; Try to prevent kill-region from appending this to some

Is it intended to - at the end - call the original functions here?

TIA,

Michael.





  reply	other threads:[~2022-06-04 13:20 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-02 22:36 bug#55234: 28.1; replace-string in rectangle regio Paulo Sousa
2022-05-03  6:57 ` Juri Linkov
2022-06-01 11:42   ` Michael Heerdegen
2022-06-01 19:23     ` Juri Linkov
2022-06-02 12:20       ` Michael Heerdegen
2022-06-02 17:19         ` Juri Linkov
2022-06-03  7:46           ` Juri Linkov
2022-06-03 18:09             ` Juri Linkov
2022-06-04 13:20               ` Michael Heerdegen [this message]
2022-06-06  7:43                 ` Juri Linkov
2022-06-09 11:12                   ` Michael Heerdegen
2022-06-09 17:05                     ` Juri Linkov
2022-06-02 17:23         ` Juri Linkov
2022-06-03  9:37           ` Michael Heerdegen
2022-06-08 17:10 ` Juri Linkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87h750va36.fsf@web.de \
    --to=michael_heerdegen@web.de \
    --cc=55234@debbugs.gnu.org \
    --cc=de.sousa.paulus@gmail.com \
    --cc=juri@linkov.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.