From: Po Lu via "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 55970@debbugs.gnu.org, lumarzeli30@gmail.com
Subject: bug#55970: 29.0.50; Emacs crashes when dragging the scroll bar with "--with-pgtk" and "--without-toolkit-scroll-bars" configure flags
Date: Wed, 15 Jun 2022 21:14:16 +0800 [thread overview]
Message-ID: <87h74m6pcn.fsf@yahoo.com> (raw)
In-Reply-To: <83edzqru4o.fsf@gnu.org> (Eli Zaretskii's message of "Wed, 15 Jun 2022 15:25:27 +0300")
Eli Zaretskii <eliz@gnu.org> writes:
> Then how come the code which aborted got executed contrary to what you
> say?
Because USE_TOOLKIT_SCROLL_BARS was not defined. The reporter passed
`--without-toolkit-scroll-bars' to configure, which is not supported on
PGTK.
The configure script is supposed to prohibit that combination of
options, but somehow that did not happen.
> And given that it did, would it do any harm to install the fix I
> proposed?
Yes, since the events generated would also still be broken, but more
subtly. USE_TOOLKIT_SCROLL_BARS should always be defined on window
systems other than X, since no other window system implements "native"
scroll bars.
> More importantly, does it really make sense to "fix" events in
> keyboard.c, rather than generate them correctly in low-level
> toolkit-specific code to begin with? I mean this part:
>
> /* Always treat scroll bar events as clicks. */
> event->modifiers |= click_modifier;
> event->modifiers &= ~up_modifier;
>
> Why do we override the modifiers of the event, and why in keyboard.c
> of all places? Can we do this cleaner, or at least in
> toolkit-specific code?
I don't really understand that piece of code. It seems wrong to me,
since toolkit scroll bar events should not have modifiers at all.
But it's probably there for a reason, which I will look into.
next prev parent reply other threads:[~2022-06-15 13:14 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-14 14:08 bug#55970: 29.0.50; Emacs crashes when dragging the scroll bar with "--with-pgtk" and "--without-toolkit-scroll-bars" configure flags समीर सिंह Sameer Singh
2022-06-14 17:44 ` Eli Zaretskii
2022-06-14 17:48 ` समीर सिंह Sameer Singh
2022-06-14 18:30 ` Eli Zaretskii
2022-06-14 18:44 ` समीर सिंह Sameer Singh
2022-06-14 18:48 ` Eli Zaretskii
2022-06-15 0:59 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-06-15 2:28 ` Eli Zaretskii
2022-06-15 3:29 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-06-15 8:23 ` समीर सिंह Sameer Singh
2022-06-15 12:25 ` Eli Zaretskii
2022-06-15 13:14 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors [this message]
2022-06-15 13:50 ` Robert Pluim
2022-06-15 14:01 ` समीर सिंह Sameer Singh
2022-06-16 0:53 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-06-16 7:39 ` Robert Pluim
2022-06-15 0:56 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87h74m6pcn.fsf@yahoo.com \
--to=bug-gnu-emacs@gnu.org \
--cc=55970@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=luangruo@yahoo.com \
--cc=lumarzeli30@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.