From: Robert Pluim <rpluim@gmail.com>
To: Lars Ingebrigtsen <larsi@gnus.org>
Cc: "Iñigo Serna" <inigoserna@gmx.com>,
emacs-devel@gnu.org, "Eli Zaretskii" <eliz@gnu.org>
Subject: Re: PROPOSAL: New function ffap-ip-at-point
Date: Sat, 23 Jul 2022 09:31:16 +0200 [thread overview]
Message-ID: <87h7389tff.fsf@gmail.com> (raw)
In-Reply-To: <875yjoaoxq.fsf@gnus.org> (Lars Ingebrigtsen's message of "Fri, 22 Jul 2022 22:10:41 +0200")
>>>>> On Fri, 22 Jul 2022 22:10:41 +0200, Lars Ingebrigtsen <larsi@gnus.org> said:
Lars> Iñigo Serna <inigoserna@gmx.com> writes:
>> 'textsec--ipvx-address-p' current implementation is not perfect.
>> It returns a wrong result when some octet is greater than 255.
>>
>> (textsec--ipvx-address-p "343.1.2.3")
>> 0
>>
>> (ffap-ipv4-p "343.1.2.3")
>> nil
>>
>> So IMO it's not as useful for my purposes, reports from network tools.
Lars> Well, we could trivially fix that in that function.
How far down the rabbit hole do we want to go, knowing that libc has
already done this? Note: "0343.1.2.3" is a valid representation of an
IPv4 address, as is "0", or "1".
Robert
--
next prev parent reply other threads:[~2022-07-23 7:31 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-22 8:49 PROPOSAL: New function ffap-ip-at-point Iñigo Serna
2022-07-22 9:36 ` Robert Pluim
2022-07-22 11:20 ` Eli Zaretskii
2022-07-22 14:46 ` Iñigo Serna
2022-07-22 15:01 ` Eli Zaretskii
2022-07-22 15:04 ` Brian Cully via Emacs development discussions.
2022-07-22 15:28 ` Iñigo Serna
2022-07-22 15:09 ` Lars Ingebrigtsen
2022-07-22 15:34 ` Iñigo Serna
2022-07-22 15:55 ` Robert Pluim
2022-07-22 20:10 ` Lars Ingebrigtsen
2022-07-23 7:31 ` Robert Pluim [this message]
2022-07-23 7:37 ` Lars Ingebrigtsen
2022-07-23 7:46 ` Robert Pluim
2022-07-23 7:47 ` Lars Ingebrigtsen
2022-07-26 12:21 ` Robert Pluim
2022-07-26 12:48 ` Eli Zaretskii
2022-07-26 12:54 ` Robert Pluim
2022-07-23 7:39 ` Andreas Schwab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87h7389tff.fsf@gmail.com \
--to=rpluim@gmail.com \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=inigoserna@gmx.com \
--cc=larsi@gnus.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.