From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#50431: revert-buffer doesn't preserve read-onlyness Date: Wed, 24 Aug 2022 13:35:06 +0200 Message-ID: <87h721oowl.fsf@gnus.org> References: <87mtopkj2a.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="15327"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: 50431@debbugs.gnu.org To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Aug 24 13:44:14 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oQont-0003ld-PS for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 24 Aug 2022 13:44:13 +0200 Original-Received: from localhost ([::1]:51638 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oQons-0005zm-Nw for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 24 Aug 2022 07:44:12 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:37116) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oQog2-0002uy-Pz for bug-gnu-emacs@gnu.org; Wed, 24 Aug 2022 07:36:09 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:56046) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oQofy-0003vr-Ft for bug-gnu-emacs@gnu.org; Wed, 24 Aug 2022 07:36:06 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oQofy-000207-BD for bug-gnu-emacs@gnu.org; Wed, 24 Aug 2022 07:36:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 24 Aug 2022 11:36:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 50431 X-GNU-PR-Package: emacs Original-Received: via spool by 50431-submit@debbugs.gnu.org id=B50431.16613409197594 (code B ref 50431); Wed, 24 Aug 2022 11:36:02 +0000 Original-Received: (at 50431) by debbugs.gnu.org; 24 Aug 2022 11:35:19 +0000 Original-Received: from localhost ([127.0.0.1]:45786 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oQofH-0001yP-EV for submit@debbugs.gnu.org; Wed, 24 Aug 2022 07:35:19 -0400 Original-Received: from quimby.gnus.org ([95.216.78.240]:48616) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oQofE-0001y3-4B for 50431@debbugs.gnu.org; Wed, 24 Aug 2022 07:35:17 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:Date:References: In-Reply-To:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=7fWNib0ZNtyA/oOF+onkL96ELQoZC0HJNX1S45aOfno=; b=s66KO/s2PyjS3bKAYTmnACQQVC vW4AEtgLTSQ30NZSwpmfSdrvU4txs4vGEmwYatPLwcReMlNgXp1v7NpZH+L+I7MS5Oi87bZ2/oNF8 GHduBBFwqt6nR6bQVvCGkyuTh0FnaCa+VmQCoXlb5FpVGQJInZcI1vZktndqsU2tSG70=; Original-Received: from [84.212.220.105] (helo=joga) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oQof4-0004sB-W0; Wed, 24 Aug 2022 13:35:09 +0200 In-Reply-To: <87mtopkj2a.fsf@mail.linkov.net> (Juri Linkov's message of "Mon, 06 Sep 2021 18:03:09 +0300") X-Now-Playing: Loma's _Don't Shy Away_: "Breaking Waves Like a Stone" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:240600 Archived-At: Juri Linkov writes: > I don't know at what moment this regression occurred, > but now M-x revert-buffer in a read-only file buffer > doesn't keep it read-only. I've now fixed this in Emacs 29 -- `C-x C-q' records what the user actually did, so we can restore that state. If the user hasn't used that command, then reverting works as before -- it uses the permission bits on the file and updates the readedness state. I considered only heeding the user-set readedness state if it was different from the default one -- that is, if the user used the `C-x C-q' command twice, then readedness state would not be preserved by reverting, but I think that's too subtle.