all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Visuwesh <visuweshm@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: arunisaac@systemreboot.net, 58070@debbugs.gnu.org
Subject: bug#58070: [PATCH] Add tamil99 input method
Date: Tue, 27 Sep 2022 15:41:33 +0530	[thread overview]
Message-ID: <87h70tdt4a.fsf@gmail.com> (raw)
In-Reply-To: <83h70tjls4.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 27 Sep 2022 10:53:31 +0300")

[செவ்வாய் செப்டம்பர் 27, 2022] Eli Zaretskii wrote:

>> From: Visuwesh <visuweshm@gmail.com>
>> Cc: arunisaac@systemreboot.net,  58070@debbugs.gnu.org
>> Date: Tue, 27 Sep 2022 13:04:48 +0530
>> 
>> In delete-forward-char, we use find-composition to get the extend of the
>> current glyphs in terms of characters.  AFAICT, find-composition does a
>> forward search for the 'composition' text property.  My proposal was
>> that we write a find-composition variant that would do a backward search
>> for the 'composition' text property which we then can make of use in
>> delete-backward-char.
>
> You are looking at the wrong branch of the code.  There's no
> 'composition' text property in the case that is of interest to you;
> the characters are composed by the so-called "automatic composition",
> whereby Emacs decides which characters to compose without any special
> text property.  The relevant code is in find_automatic_composition,
> which is called by find-composition-internal.

My recollection of the find-composition-internal was that it eventually
fell back to a text property search even for automatic compositions but
I see now that's not the case.  Thanks for setting me straight.

> In any case, my suggestion for finding composition backward is to
> incrementally go back and call find-composition-internal, until it
> fails to find a composition at or before point.

Thanks, I will see what I can do.

> The next question will be: what would be the key to which you'd bind
> this new command?

I thought a user option that would make DEL delete by grapheme clusters
would do the job.

>> We cannot simply do backward-char then delete-forward-char and bind it
>> to a command since IIRC the grapheme cluster movement happens in the
>> display code?
>
> No, it happens in the command loop.  See adjust_point_for_property,
> which calls composition_adjust_point.  I don't think this is important
> for the issue at hand, because the point adjustment happens only after
> interactive commands.





  parent reply	other threads:[~2022-09-27 10:11 UTC|newest]

Thread overview: 41+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-25 10:00 bug#58070: [PATCH 0/1] Add tamil99 input method Arun Isaac
2022-09-25 10:02 ` bug#58070: [PATCH] " Arun Isaac
2022-09-25 11:38   ` Visuwesh
2022-09-25 13:59     ` Eli Zaretskii
2022-09-25 14:14       ` Visuwesh
2022-09-25 14:23         ` Eli Zaretskii
2022-09-25 14:38           ` Visuwesh
2022-09-25 15:55             ` Eli Zaretskii
2022-09-26 20:59               ` Arun Isaac
2022-09-27  6:25                 ` Eli Zaretskii
2022-09-27 20:34                   ` Arun Isaac
2022-09-26 20:55     ` Arun Isaac
2022-09-27  1:49       ` Visuwesh
2022-09-27  2:29         ` Visuwesh
2022-09-27  6:37         ` Eli Zaretskii
2022-09-27  7:34           ` Visuwesh
2022-09-27  7:53             ` Eli Zaretskii
2022-09-27  9:24               ` Robert Pluim
2022-09-27  9:40                 ` Eli Zaretskii
2022-09-27 10:11               ` Visuwesh [this message]
2022-09-27 20:32         ` Arun Isaac
2022-09-27  6:23       ` Eli Zaretskii
2022-09-27  7:52         ` Visuwesh
2022-09-27  8:03           ` Eli Zaretskii
2022-09-27 10:15             ` Visuwesh
2022-10-12  8:40             ` Arun Isaac
2022-10-12 14:00               ` Eli Zaretskii
2022-10-15  8:23                 ` Arun Isaac
2022-09-27 20:19           ` Arun Isaac
2022-09-27 20:26         ` Arun Isaac
2022-09-28  2:30           ` Eli Zaretskii
2022-09-25 10:13 ` bug#58070: [PATCH 0/1] " Eli Zaretskii
2022-09-25 11:16   ` Arun Isaac
2022-10-12  8:41     ` Arun Isaac
2022-10-12 13:55       ` Eli Zaretskii
2022-10-15  8:34         ` Arun Isaac
2022-10-15  9:16           ` bug#58070: [PATCH v2] " Arun Isaac
2022-10-15 14:42           ` bug#58070: [PATCH 0/1] " Visuwesh
2022-10-18  7:11             ` Arun Isaac
2022-10-18 18:00               ` bug#58070: [PATCH v3] " Arun Isaac
2022-10-19 11:41                 ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87h70tdt4a.fsf@gmail.com \
    --to=visuweshm@gmail.com \
    --cc=58070@debbugs.gnu.org \
    --cc=arunisaac@systemreboot.net \
    --cc=eliz@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.