From: Lars Ingebrigtsen <larsi@gnus.org>
To: Jonas Bernoulli <jonas@bernoul.li>
Cc: 58278@debbugs.gnu.org
Subject: bug#58278: Add new function seq-keep
Date: Tue, 04 Oct 2022 15:47:16 +0200 [thread overview]
Message-ID: <87h70j7laz.fsf@gnus.org> (raw)
In-Reply-To: <87v8ozu50r.fsf@bernoul.li> (Jonas Bernoulli's message of "Tue, 04 Oct 2022 14:50:28 +0200")
Jonas Bernoulli <jonas@bernoul.li> writes:
> Yes, that would be an improvement. Some (but certainly not all)
> uses of dash's `-keep' look something like
>
> (-keep (lambda (elt)
> (and (symbolp elt)
> (symbol-name elt)))
> sequence)
>
> and
>
> (seq-keep #'symbol-name sequence #'symbolp)
>
> would be much nicer in those situations.
Hm... That's not exactly what I was thinking here. I was thinking
(cl-defgeneric seq-keep (func sequence &optional pred)
(if pred
(seq-filter pred (seq-mapcar func sequence))
(delq nil (seq-mapcar func sequence))))
which is the traditional "keep" semantics, but allows extending the
concept of "keep" to more than "is non-nil".
But that may well be an overcomplication -- in the unusual cases where
it's not nil that people want to keep, they can just type
(seq-filter pred (seq-mapcar func sequence))
themselves, which has very clear semantics.
So I think, on second consideration, I'd rather just go with
(cl-defgeneric seq-keep (func sequence)
(delq nil (seq-mapcar func sequence)))
like you originally suggested (but with just an argument name change).
next prev parent reply other threads:[~2022-10-04 13:47 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-03 21:30 bug#58278: Add new function seq-keep Jonas Bernoulli
2022-10-03 23:47 ` Lars Ingebrigtsen
2022-10-04 10:05 ` Robert Pluim
2022-10-04 10:13 ` Lars Ingebrigtsen
2022-10-04 10:27 ` Robert Pluim
2022-10-04 10:42 ` Lars Ingebrigtsen
2022-10-04 10:50 ` Robert Pluim
2022-10-04 11:10 ` Lars Ingebrigtsen
2022-10-04 11:21 ` Robert Pluim
2022-10-04 11:23 ` Lars Ingebrigtsen
2022-10-04 11:37 ` Robert Pluim
2022-10-04 12:50 ` Jonas Bernoulli
2022-10-04 13:47 ` Lars Ingebrigtsen [this message]
2022-10-04 13:56 ` Lars Ingebrigtsen
2022-10-04 13:59 ` Lars Ingebrigtsen
2022-10-04 19:46 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87h70j7laz.fsf@gnus.org \
--to=larsi@gnus.org \
--cc=58278@debbugs.gnu.org \
--cc=jonas@bernoul.li \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.