From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Robert Pluim Newsgroups: gmane.emacs.devel Subject: Re: Stylistic changes to tree-sitter code Date: Thu, 27 Oct 2022 15:56:12 +0200 Message-ID: <87h6zptloj.fsf@gmail.com> References: <87h6zp75nt.fsf.ref@yahoo.com> <87h6zp75nt.fsf@yahoo.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="28427"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Po Lu To: Po Lu via "Emacs development discussions." Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Oct 27 16:04:15 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oo3UU-0007A1-3f for ged-emacs-devel@m.gmane-mx.org; Thu, 27 Oct 2022 16:04:14 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oo3Mv-0002Ql-DB; Thu, 27 Oct 2022 09:56:25 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oo3Ms-0002QQ-UZ for emacs-devel@gnu.org; Thu, 27 Oct 2022 09:56:22 -0400 Original-Received: from mail-wr1-x431.google.com ([2a00:1450:4864:20::431]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oo3Ml-0004AU-3I for emacs-devel@gnu.org; Thu, 27 Oct 2022 09:56:18 -0400 Original-Received: by mail-wr1-x431.google.com with SMTP id a14so2313995wru.5 for ; Thu, 27 Oct 2022 06:56:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:date :gmane-reply-to-list:references:in-reply-to:subject:cc:to:from:from :to:cc:subject:date:message-id:reply-to; bh=C9+afI63hhc6368nWW3ffGhsZWovJOysgJkmpL6M8xY=; b=ojS4V65gRRCHY2AmjAoZ43Gwh9L8ituZpyQrw2R2J0IJxJaWUVWMJkagi1fSG4ML5l II0lGZ3IjMiTl7SBIMjM9JNwM9TRgjIrt44lMoNMeraGFE21wePWO/ktz4khT5tnZ/D3 yt/0PbQp/pg+LAn7PFFO0uXSJKmvjjQTdgmD9cfZ58/8LyVDayvIwi2BfVsX7kfX035Z W6EbdSoMg/ghCn5FKvLuUZuq0fWx2i9pIUSDKHomNf7AASFmZKCnPQg6OQu41Nc0ZzIn bMBiuXu7PWr8VDbzZdqTlDHf9zvMaZ3eDVS7hmOdzNEciOkJ5oAbvEe5gJc7d6PIgAi/ WuHw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date :gmane-reply-to-list:references:in-reply-to:subject:cc:to:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=C9+afI63hhc6368nWW3ffGhsZWovJOysgJkmpL6M8xY=; b=OIzNGKlt2tc3+p74GBf/UHpIjS8ScrjowYc0P4Z27Chd24w8tjFCPCmAIW8x5wfXiQ jjIWymriZYQKCc4XX+gmtVFukjDvcTTCIDkvhOg6JKF0uV6b/aInCFOG6Y4k2pTKCcDq HYAdEJ5tSF4ozAReXBKciLrd7CL30BGHLq/9671xnYwE/Vh2bENAlAruxJmBykgDnZmQ B8IYEhb2PMvOblARuKmsv1UgGh2R/4kDa8NH8ZypPzHWc7udqXVW3hatrdlZA+YOx5Zb nweSDa4AULrjoOX82jC5FIgCY04xF5YgWDZfsK+QgcBuL6PBlipcQ+zOlkwLuJX1ppHy Q5OA== X-Gm-Message-State: ACrzQf2N/PJDaB5hrUbE2n8I4BPcp8QasNT/co9RFtCpmW5P6HhLJBSf pAIbr9XgwUT7v55hX9j3z3Xy8ZaEx3s= X-Google-Smtp-Source: AMsMyM7N2OJAFk/2w5raOP6Aa7yTvWzCHXRGops39ROXFsdsyx7mpfmTwxhYqZabuOalLZXHs89hXQ== X-Received: by 2002:a05:6000:1ac8:b0:231:90f0:217e with SMTP id i8-20020a0560001ac800b0023190f0217emr31917139wry.525.1666878973232; Thu, 27 Oct 2022 06:56:13 -0700 (PDT) Original-Received: from rltb ([82.66.8.55]) by smtp.gmail.com with ESMTPSA id bs1-20020a056000070100b002345cb2723esm1335705wrb.17.2022.10.27.06.56.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 27 Oct 2022 06:56:12 -0700 (PDT) In-Reply-To: <87h6zp75nt.fsf@yahoo.com> (Po Lu via's message of "Thu, 27 Oct 2022 21:33:10 +0800") Gmane-Reply-To-List: yes Received-SPF: pass client-ip=2a00:1450:4864:20::431; envelope-from=rpluim@gmail.com; helo=mail-wr1-x431.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: "Emacs-devel" Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:298618 Archived-At: >>>>> On Thu, 27 Oct 2022 21:33:10 +0800, Po Lu via "Emacs development disc= ussions." said: Po Lu> Unfortunately, I don't have tree-sitter installed, so would some= one Po Lu> please do a smoke test on the changes before I install them? I have it installed, but I don=CA=BCt use it yet, so all I can offer is a compile test: CC treesit.o treesit.c: In function =E2=80=98treesit_find_override_name=E2=80=99: treesit.c:467:41: error: =E2=80=98list=E2=80=99 undeclared (first use in th= is function); did you mean =E2=80=98listn=E2=80=99? 467 | *name =3D Fnth (make_fixnum (1), XCAR (list)); | ^~~~ | listn treesit.c:467:41: note: each undeclared identifier is reported only once fo= r each function it appears in treesit.c:476:57: error: expected =E2=80=98;=E2=80=99 before =E2=80=98retur= n=E2=80=99 476 | CHECK_LIST_END (tem, Vtreesit_load_name_override_list) | ^ | ; 477 |=20 478 | return false; | ~~~~~~=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20= =20=20=20=20=20 treesit.c: In function =E2=80=98treesit_load_language=E2=80=99: treesit.c:555:15: error: redeclaration of =E2=80=98tail=E2=80=99 with no li= nkage 555 | Lisp_Object tail; | ^~~~ treesit.c:539:15: note: previous declaration of =E2=80=98tail=E2=80=99 was = here 539 | Lisp_Object tail; | ^~~~ treesit.c: In function =E2=80=98treesit_find_override_name=E2=80=99: treesit.c:479:1: warning: control reaches end of non-void function [-Wretur= n-type] 479 | } | ^ make[2]: *** [Makefile:424: treesit.o] Error 1 Robert --=20