From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Theodor Thornhill via "Emacs development discussions." Newsgroups: gmane.emacs.devel Subject: Re: Remove js--treesit-backward-up-list or fix it Date: Sat, 29 Oct 2022 20:31:32 +0200 Message-ID: <87h6zmscqj.fsf@thornhill.no> References: <8B978AF7-B1CA-4C8A-9E89-84D0DEC7884C@gmail.com> <87h6znxkr0.fsf@thornhill.no> <0849BE6B-B5B4-47E0-B4EA-F93F6947C2B7@gmail.com> Reply-To: Theodor Thornhill Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="37212"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Yuan Fu Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Oct 29 20:33:12 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ooqds-0009Vb-24 for ged-emacs-devel@m.gmane-mx.org; Sat, 29 Oct 2022 20:33:12 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ooqcR-0004QZ-P4; Sat, 29 Oct 2022 14:31:43 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ooqcP-0004NK-OH for emacs-devel@gnu.org; Sat, 29 Oct 2022 14:31:42 -0400 Original-Received: from out0.migadu.com ([94.23.1.103]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ooqcN-0000Mw-ST for emacs-devel@gnu.org; Sat, 29 Oct 2022 14:31:41 -0400 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. In-Reply-To: <0849BE6B-B5B4-47E0-B4EA-F93F6947C2B7@gmail.com> Received-SPF: pass client-ip=94.23.1.103; envelope-from=theo@thornhill.no; helo=out0.migadu.com X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: "Emacs-devel" Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:298774 Archived-At: (added back in emacs-devel) Hi! >>=20 >> ``` >> const fooClient =3D new Foo(() =3D> ({ >> | // <---- point is there=20=20 >> }));=20 >> ``` >> Which is not what we want. If we can keep that correct behavior in any >> case I say we remove the hack. We could make an anchor helper named >> something like 'parent-then-bol', but because there is no node here, we >> cannot find the parent. >>=20 >> What do you think? > > I added a rule that fixes it. Actually, when there is no node at > point, parent is set to the smaller node that spans point, kind of > like the immediate =E2=80=9Cparent=E2=80=9D of that point. I=E2=80=99ve a= dded some explanation > in the manual. > Yes, It's probably a remnant from when the semantics were a bit different between the treesit-node-on and treesit-node-at. I see it was never there in ts-mode ;-) >>=20 >> However, there are some problems with the newest revisions. During >> }) >> .catch((r) =3D> { >> if (r.status < 200 || r.status >=3D 300) { >> console.log(r); >> } >> }); >> }; >> ``` > > Yes, sorry. I was naive with my implementation. Now it should be fixed. > Absolutely! Great work! However... Try creating a js-mode buffer and type: ``` const foo =3D foo(() =3D> {}); ``` Because of all the stuff we set before we init tree sitter we get a super unwanted behavior of the cursor jumping back to indentation for every () {} etc. This is because of these settings, which are IMO pretty bad defaults: ``` (setq-local electric-indent-chars (append "{}():;," electric-indent-chars)) ;FIXME: js2-mode adds "[]*= ". (setq-local electric-layout-rules '((?\; . after) (?\{ . after) (?\} . before))) ``` This could just be something forgotten in the indent implementation, but in my book this is yet another example for why we shouldn't init like this ;-) --=20 Theo