From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Po Lu Newsgroups: gmane.emacs.devel Subject: Re: scratch/comp-static-data 87a249440f 1/2: src/comp.c: Use `long' rvalues for storing values with GC bits. Date: Sun, 20 Nov 2022 08:45:04 +0800 Message-ID: <87h6yu8ne7.fsf@yahoo.com> References: <166887624274.20851.208849360159299364@vcs2.savannah.gnu.org> <20221119164403.530B7C009EC@vcs2.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="17031"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Vibhav Pant To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Nov 20 01:45:43 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1owYSt-0004Gm-0R for ged-emacs-devel@m.gmane-mx.org; Sun, 20 Nov 2022 01:45:43 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1owYSY-0001Wn-Fo; Sat, 19 Nov 2022 19:45:22 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1owYSW-0001WL-P4 for emacs-devel@gnu.org; Sat, 19 Nov 2022 19:45:20 -0500 Original-Received: from sonic312-25.consmr.mail.ne1.yahoo.com ([66.163.191.206]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1owYST-0006KU-FC for emacs-devel@gnu.org; Sat, 19 Nov 2022 19:45:20 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1668905113; bh=DxESJHAPn0GdCwztY5zb01qPztcE73tQ0FQYXxPv4uo=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From:Subject:Reply-To; b=DywwTApboycM2i8+tKh7mZE4GtGj1A1VojsUbzXASG5/wTXTalypSD+T48Jr/sujh7lFfazFsk4CD0TZ+aywhKZ0ZevroP3mZhh4iIFA49Jd3AKXthWndgDN1lL+iyE0/WCXUuuE4izLGfqc56PRkRjOd7lYtnga0KunOMSxIOHVNMlePBBKqJji9O0NfhI7CBKDTQsQYicax9Ji1Ul5ET4i2aZQhQ50ytqyF9GPNqHgBH6uvlwPEIB3WiExwX04lYBy1vbiIkdzmEPalYr7+QvtBJXGkxy2WFW7KQK9f+sivQxtfyJ3Kanc6mWfB3r2zBB6/heIvjKhTIDD39Jcbg== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1668905113; bh=XLb6Q43fGAaORRPTvNDCWIrbcih//Hr14JL0Xv3u+V8=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=mqtRQrIEuMKWVWURj1awGMzL7XMBlJ8BTH8uVOmZ25kPJPxzGDLkkbB85ye25oziKn9EyVEp9Hjy+X0T2IHBni8PjBf+uwPVftX2SGVbMg98xGjTgwF0ecW39OEPmLh9X2hy0UAqwdd+2tCL5KIUq8l5QlV/GU24jNn+WuqHGNzmzObOIokIdaIu+dC2g0gjmnm2bPfx1mM2TDHjvEKvyZpjSX7XvgtJ4aX375Sy+92MnAl4Zn4S9aMUqjdUnn0Sf4giIUoXvEP678yjRIb434Kuf8LNu2TQkfBlyHWf8IRNEAS4L6Jzz52J62d3uWpwZZWB0kDG3t0nwZCPqJO0ow== X-YMail-OSG: KFTSpqcVM1mNEPOv9KGjFCNZBtdvvBzl6ipA03RO4rY4PhORGq2ssPNC96Fd1nU zli1skhbUg7VwrFTpimgjwwlvXZLSlYHdLWqLYqj0tBls6QZT8bxhx6i2XGXRf3AJVjuH6Feiac4 qzzIEztXDB6dJKiDnpvq5Xqhwu0ZDXlh_Rk0naN9RZT3j8eTBya3Cl_Ak92u2Qh4zEt1VRy9geFM WkKyzCXXbHFkAarDun3V8CR.CNbwXplm9R_n3sZbBP331llk8kwqW3GpTxkyqZP1W.ktsx4hgTAj TmHMO2umLqe4kFvUR1UkLzM_BuRYRX1YIKqKVSXRu_V059EQRvxZ.qDfGE.vcpwZDd.X9PIkxPmQ PT.IZWmjSAtiUW_saCTuSWEblqV0Vf5YLN3LlZCwYOjLeQqUoO46agRwK8hTN8kYCikGUzggoLwv 96yoHqSA0dzNnfzmxNaTiMOUQamXWqLVHqdyNGdPb40ZxkdKwIH_ohBVQz6NCW5rieM8NpoUKxhJ uBJQxhGzg6l2updicb7PhD1qd_9lAA9ES29L1td.pARdqVwKEetFcDis0CeSphqsy0QVI0HxVYgY W5TLPjNEf.pcZATRPyPtEQZ15NkCxRBe5zmh5YBpPx7xBQe2k7QsrDQYQN4kVe1pyVKfkj8FXvjY HAOV.FSVvsjvu2Zi7Jw9ynNoIKb1pXb._RPHFDe.Hikbox9RBkBjwjpsxXlnvEI.CoSz2KCyQyVQ GslM0RjBXqT23FexVVrNXn02G4ljxd0Ck_KvCG.lnJ2GfruE_9YKPKMEW89N4z98NshYiEAvqAMt M2I05B8rxwFCWr8i_Bl4951DBkNo1rdH34oL3_Uz.3 X-Sonic-MF: Original-Received: from sonic.gate.mail.ne1.yahoo.com by sonic312.consmr.mail.ne1.yahoo.com with HTTP; Sun, 20 Nov 2022 00:45:13 +0000 Original-Received: by hermes--production-sg3-6c8895b545-66t5n (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID d956f2923e502130c73c1d0a7b3c66ee; Sun, 20 Nov 2022 00:45:10 +0000 (UTC) In-Reply-To: <20221119164403.530B7C009EC@vcs2.savannah.gnu.org> (Vibhav Pant's message of "Sat, 19 Nov 2022 11:44:03 -0500 (EST)") X-Mailer: WebService/1.1.20863 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo Received-SPF: pass client-ip=66.163.191.206; envelope-from=luangruo@yahoo.com; helo=sonic312-25.consmr.mail.ne1.yahoo.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:300221 Archived-At: Vibhav Pant writes: > * src/comp.c (emit_lisp_string_constructor_rval, > float_block_emit_constructor, emit_comp_lisp_obj): Use > `gcc_jit_context_new_rvalue_from_long' to ensure that GC bits are > correctly encoded in any ptrdiff_t rvalue. Here, you wrapped the files _inside_ the parentheses in the first line of the commit message. Not OK! It should be: * src/comp.c (emit_lisp_string_constructor_rval) (float_block_emit_constructor, emit_comp_lisp_obj): Use `gcc_jit_context_new_rvalue_from_long' to ensure that GC bits are correctly encoded in any ptrdiff_t value. In addition, did you check this on a build with wide ints on a 32 bit machine? Maybe even one with 68000 byte order? > gcc_jit_rvalue *size_bytes > = STRING_MULTIBYTE (str) > - ? gcc_jit_context_new_rvalue_from_int (comp.ctxt, > + ? gcc_jit_context_new_rvalue_from_long (comp.ctxt, > comp.ptrdiff_type, > SBYTES (str)) > // Mark unibyte strings as immovable, so that pin_string does > // not attempt to modify them. > - : gcc_jit_context_new_rvalue_from_int (comp.ctxt, > + : gcc_jit_context_new_rvalue_from_long (comp.ctxt, > comp.ptrdiff_type, -3); Would you please place parentheses around the whole ternary, and indent accordingly? Thanks.