From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Robert Pluim Newsgroups: gmane.emacs.bugs Subject: bug#59305: 29.0.50; keymap-global-set handling of string bindings different from global-set-key Date: Tue, 22 Nov 2022 17:58:07 +0100 Message-ID: <87h6yrexk0.fsf@gmail.com> References: <87edu3cml8.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="28242"; mail-complaints-to="usenet@ciao.gmane.io" To: 59305@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Nov 22 17:59:14 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oxWc5-00079i-IQ for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 22 Nov 2022 17:59:13 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oxWbx-0000Gx-0z; Tue, 22 Nov 2022 11:59:05 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oxWbv-0000GZ-EZ for bug-gnu-emacs@gnu.org; Tue, 22 Nov 2022 11:59:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oxWbv-0004z4-6b for bug-gnu-emacs@gnu.org; Tue, 22 Nov 2022 11:59:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oxWbu-0002Wq-En for bug-gnu-emacs@gnu.org; Tue, 22 Nov 2022 11:59:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Robert Pluim Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 22 Nov 2022 16:59:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59305 X-GNU-PR-Package: emacs Original-Received: via spool by 59305-submit@debbugs.gnu.org id=B59305.16691362989668 (code B ref 59305); Tue, 22 Nov 2022 16:59:02 +0000 Original-Received: (at 59305) by debbugs.gnu.org; 22 Nov 2022 16:58:18 +0000 Original-Received: from localhost ([127.0.0.1]:52434 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oxWbC-0002Vs-0b for submit@debbugs.gnu.org; Tue, 22 Nov 2022 11:58:18 -0500 Original-Received: from mail-wr1-f52.google.com ([209.85.221.52]:33597) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oxWb9-0002Vd-Gx for 59305@debbugs.gnu.org; Tue, 22 Nov 2022 11:58:16 -0500 Original-Received: by mail-wr1-f52.google.com with SMTP id i12so21795218wrb.0 for <59305@debbugs.gnu.org>; Tue, 22 Nov 2022 08:58:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=R0MgBe4i1TvDCH3d8+BaICfLGkHJCRyBgdxNfU/7i+w=; b=lcJYMsyozTast6Hw4QxjpTReD5Vz+JOsoIfH6hh53F7CJEv9YDFtBw/yLb1fhjmQuj 2pWJIm8knputL21gllPHJ/Cb6hicLbmrL9y1PaQVWZEjx2avEaPX/MKsaPB3cYs4NJXH BsNZ4dej2CpOMY+nzhTSWyJRWGolYMVFfY1W5ixhq1Do+63UmyF0JLIvemVahnWoh1Tb Uc/N+bfr8spgK7Yo9kGInw7zEUNcaMPk05bANPHUnPdhN4DuHGM/C6Sp7hDSGDn6f09b rBwv29XQ7IicDUXATw8Xy/LcDbsj+0DcpZHc7VciHInBtaNPjKHKxKzYgnNFXM00OFvk KFfA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:to:from:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=R0MgBe4i1TvDCH3d8+BaICfLGkHJCRyBgdxNfU/7i+w=; b=MRq9XgNG40WXwTpj7tCIPMt04kLrHOma/pYdhLS8U3Yhb230OB3SFPM4PPu+CEuMs0 F7bAxfiF2w/A+c6Fi4Wc7GS1z0O52NWfcQ4c9cT7iYQ/K0JqCE0gmqktpJNIQJih8d+5 92YVmBYN/EJEVBWYWGb5fSZ/d7KRIeHPasRom3T2SohjhF9MUxlO7aMWTwaxE3o2aUWW ruI1a6HPNy5/iObn8xYCCEyz3fmXgxn2YVzGT3npTMVl3QLanrrWT+KMW03in5nsJKTG jscs8MRz6qyNufVqecVd3XO9oWVYNqDyMtEPPc+MaBKk8NNNXR3D+Nnpq8bgwkrwuFO+ ARxQ== X-Gm-Message-State: ANoB5plLMuqbC4XkWrAPgNgKTPs3AChWIVtVzL0siuvV5oby5hAFiyZy J/78oopP/7lWqFh/hejbgocl+HG1Yl8= X-Google-Smtp-Source: AA0mqf5CnKlmyIDhFUKizN0XZPVriWs9+7u4IG/bSiUQr2cJQyvtqWAZMIjxFTJePPus64reWaGnTw== X-Received: by 2002:a05:6000:78d:b0:22e:3d63:80bc with SMTP id bu13-20020a056000078d00b0022e3d6380bcmr15548907wrb.30.1669136289004; Tue, 22 Nov 2022 08:58:09 -0800 (PST) Original-Received: from rltb ([82.66.8.55]) by smtp.gmail.com with ESMTPSA id o2-20020a05600c510200b003cf5ec79bf9sm20101263wms.40.2022.11.22.08.58.08 for <59305@debbugs.gnu.org> (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 22 Nov 2022 08:58:08 -0800 (PST) In-Reply-To: <87edu3cml8.fsf@gmail.com> (Robert Pluim's message of "Wed, 16 Nov 2022 09:47:31 +0100") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:248661 Archived-At: >>>>> On Wed, 16 Nov 2022 09:47:31 +0100, Robert Pluim s= aid: Robert> 1. Change `kbd' to always return a vector even if the input is Robert> ascii-only, which makes [4] work I tried that, and it seems to work, but I guess it=CA=BCs kind of risky. Just what we need to see if people are testing the pre-test properly =F0=9F=98=B8 Robert> 2. Change `keymap-set' to convert ascii-only strings to the for= mat in Robert> [5] or [6]. Probably just a call to `string-to-vector' is enoug= h. This is less invasive. Something like this: diff --git a/lisp/keymap.el b/lisp/keymap.el index eaeba96644..deb44844fb 100644 --- a/lisp/keymap.el +++ b/lisp/keymap.el @@ -61,7 +61,23 @@ keymap-set ;; If we're binding this key to another key, then parse that other ;; key, too. (when (stringp definition) - (keymap--check definition) + ;; For backwards compatibility, we want people to be able to say + ;; "hello" instead of forcing them to say "h e l l o", and to fix + ;; the common mistake of specifying a string with non-ascii + ;; characters, we convert to a vector instead. + (cond + ((let ((case-fold-search nil)) ;; no special chars or keywords + (not (string-match-p + (rx (or " " "^" "<" ">" "-" "\\" + "NUL" "RET" "TAB" "LFD" + "ESC" "SPC" "DEL"))))) + (setq definition (string-join (seq-split definition 1) " ")) + (keymap--check definition)) + ((string-match-p ;; non-ascii characters + "[[:nonascii:]]" definition) + (setq definition (string-to-vector definition))) + (t ;; kbd syntax + (keymap--check definition))) (setq definition (key-parse definition))) (define-key keymap (key-parse key) definition)) Robert --=20