From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Philip Kaludercic Newsgroups: gmane.emacs.bugs Subject: bug#59404: 29.0.50; Init-debug error when package-vc-install package and run older emacs Date: Wed, 23 Nov 2022 07:46:28 +0000 Message-ID: <87h6yq3ygb.fsf@posteo.net> References: <877czqtaki.fsf@163.com> <871qpxn11d.fsf@posteo.net> <875yf7rg34.fsf@163.com> <87o7sy4qth.fsf@posteo.net> <87tu2qtsae.fsf@163.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="17596"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 59404@debbugs.gnu.org To: Feng Shu Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Nov 23 08:47:17 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oxkTU-0004LG-N7 for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 23 Nov 2022 08:47:16 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oxkTI-0007Oz-6D; Wed, 23 Nov 2022 02:47:04 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oxkTG-0007OS-31 for bug-gnu-emacs@gnu.org; Wed, 23 Nov 2022 02:47:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oxkTF-0004MN-Ns for bug-gnu-emacs@gnu.org; Wed, 23 Nov 2022 02:47:01 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oxkTF-0006MY-Jr for bug-gnu-emacs@gnu.org; Wed, 23 Nov 2022 02:47:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Philip Kaludercic Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 23 Nov 2022 07:47:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59404 X-GNU-PR-Package: emacs Original-Received: via spool by 59404-submit@debbugs.gnu.org id=B59404.166918960124430 (code B ref 59404); Wed, 23 Nov 2022 07:47:01 +0000 Original-Received: (at 59404) by debbugs.gnu.org; 23 Nov 2022 07:46:41 +0000 Original-Received: from localhost ([127.0.0.1]:53333 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oxkSu-0006Ly-HN for submit@debbugs.gnu.org; Wed, 23 Nov 2022 02:46:40 -0500 Original-Received: from mout01.posteo.de ([185.67.36.65]:52107) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oxkSq-0006Li-JK for 59404@debbugs.gnu.org; Wed, 23 Nov 2022 02:46:39 -0500 Original-Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id 748E9240026 for <59404@debbugs.gnu.org>; Wed, 23 Nov 2022 08:46:30 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1669189590; bh=/M0TkuvKsQIUOtUUOP6PZTsjMyciu842Sd/Nh/poVVk=; h=From:To:Cc:Subject:Date:From; b=RPfXgzny7SQo7SIbBBZyiUji9BQcWcf25Z9m3KQR8pB0OB70LytMexkj9KVm4PhMF ppEpABTYzgfHPXou+WY/UwdUPFR62zm3RlC/yayTUm5zYK+ZqEwTdkqjQwveQpxCSj xcgWsJBv2HJQCaXq06tm8TkBuVqK330PVhHqwk4xI4hBBxtc9IqCM+gFx5k4Z/R/M7 I4IxaDfWToYLjAY7k2oX940EVuJ5CE4Z7LO2CkSFBHiwUjwWr3WXuWboQlYVVyzy4D jGvMKbyGUHzGHv5AY7Vnq4dIottNUDFE1oNVBHjJ+qbsubwpeXVG7UV5Yqp1QHRAQc y9ELF3fnvJgQw== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4NHCqn43jyz9rxN; Wed, 23 Nov 2022 08:46:28 +0100 (CET) In-Reply-To: <87tu2qtsae.fsf@163.com> (Feng Shu's message of "Wed, 23 Nov 2022 08:42:49 +0800") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:248710 Archived-At: --=-=-= Content-Type: text/plain Feng Shu writes: > Philip Kaludercic writes: > >> Feng Shu writes: >> >>> Philip Kaludercic writes: >>> >>>> Feng Shu writes: >>>> >>>>> When I package-vc-install corfu-terminal and run an older version >>>>> emacs >>>> >>>> Does the following fix the issue for you: >>> >>> I have tested and find that when I install this patch and reinstall >>> popon and corfu-terminal, >>> >>> 1. *Packages* buffer do not show packages installed by >>> package-vc-install >>> 2. package-update, package-delete do not show packages installed by >>> package-vc-install. >>> 3. restart emacs has not effect. >> >> Did you re-install the packages? > > Yes, when I apply this patch, packages before installed are dispear, so > I install them with package-vc-install, after install, packages do not > show like above. Sorry about that, I misread your message. There was a minor typo/thinko in the last patch: --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=0001-Don-t-break-when-loading-VC-packages-on-older-Emacs-.patch >From 46d2f3542100efd2019f5f4703e21f5d45baed71 Mon Sep 17 00:00:00 2001 From: Philip Kaludercic Date: Sun, 20 Nov 2022 15:36:24 +0100 Subject: [PATCH 1/2] Don't break when loading VC packages on older Emacs versions * lisp/emacs-lisp/package-vc.el (package-vc--generate-description-file): Append a :kind property instead of modifying the version number. * lisp/emacs-lisp/package.el (package-desc): Remove special handling for "vc annotated" versions. (bug#59404) --- lisp/emacs-lisp/package-vc.el | 3 ++- lisp/emacs-lisp/package.el | 4 +--- 2 files changed, 3 insertions(+), 4 deletions(-) diff --git a/lisp/emacs-lisp/package-vc.el b/lisp/emacs-lisp/package-vc.el index a999596785..bf1ea2bdf4 100644 --- a/lisp/emacs-lisp/package-vc.el +++ b/lisp/emacs-lisp/package-vc.el @@ -334,7 +334,7 @@ package-vc--generate-description-file (nconc (list 'define-package (symbol-name name) - (cons 'vc (package-vc--version pkg-desc)) + (package-vc--version pkg-desc) (package-desc-summary pkg-desc) (let ((requires (package-desc-reqs pkg-desc))) (list 'quote @@ -344,6 +344,7 @@ package-vc--generate-description-file (list (car elt) (package-version-join (cadr elt)))) requires)))) + (list :kind 'vc) (package--alist-to-plist-args (package-desc-extras pkg-desc)))) "\n") diff --git a/lisp/emacs-lisp/package.el b/lisp/emacs-lisp/package.el index c1545a2870..e11c5d693e 100644 --- a/lisp/emacs-lisp/package.el +++ b/lisp/emacs-lisp/package.el @@ -483,9 +483,7 @@ package-vc-p (if (eq 'quote (car requirements)) (nth 1 requirements) requirements))) - (kind (if (eq (car-safe version-string) 'vc) - 'vc - (plist-get rest-plist :kind))) + (kind (plist-get rest-plist :kind)) (archive (plist-get rest-plist :archive)) (extras (let (alist) (while rest-plist -- 2.35.1 --=-=-= Content-Type: text/plain (And thank your for your patience) --=-=-=--