From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Philip Kaludercic Newsgroups: gmane.emacs.bugs Subject: bug#59548: [PATCH] Include the package name in package-vc--unpack's prompt Date: Fri, 25 Nov 2022 07:31:01 +0000 Message-ID: <87h6yn1oei.fsf@posteo.net> References: <8114c20a-148e-7e89-5ad8-a5fb43112cb9@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="36144"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 59548@debbugs.gnu.org, daanturo To: Stefan Kangas Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Nov 25 08:32:23 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oyTCB-0009AC-Gc for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 25 Nov 2022 08:32:23 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oyTBv-0001vP-Hl; Fri, 25 Nov 2022 02:32:07 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oyTBr-0001v7-8h for bug-gnu-emacs@gnu.org; Fri, 25 Nov 2022 02:32:04 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oyTBq-0001E0-8a for bug-gnu-emacs@gnu.org; Fri, 25 Nov 2022 02:32:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oyTBq-00045k-4o for bug-gnu-emacs@gnu.org; Fri, 25 Nov 2022 02:32:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Philip Kaludercic Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 25 Nov 2022 07:32:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59548 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 59548-submit@debbugs.gnu.org id=B59548.166936148315683 (code B ref 59548); Fri, 25 Nov 2022 07:32:02 +0000 Original-Received: (at 59548) by debbugs.gnu.org; 25 Nov 2022 07:31:23 +0000 Original-Received: from localhost ([127.0.0.1]:33313 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oyTB9-00044o-28 for submit@debbugs.gnu.org; Fri, 25 Nov 2022 02:31:23 -0500 Original-Received: from mout02.posteo.de ([185.67.36.66]:45861) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oyTAw-00043m-SK for 59548@debbugs.gnu.org; Fri, 25 Nov 2022 02:31:17 -0500 Original-Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id C2021240103 for <59548@debbugs.gnu.org>; Fri, 25 Nov 2022 08:31:00 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1669361460; bh=SxZGTdH67dkYUjWCD6Mlc28erKr/siI9zGvsFZvWFeY=; h=From:To:Cc:Subject:Date:From; b=O6OQVst3UeJ/zBflSTEAKf60PV4/Nyp8hYHPVNukuJOhKSyC5Fllaci5xhFm70v+N djJvMGn5gMC4Refla+VMehtfmDq8kF0sLCSg+pXnZyP4qW1VRLYfmyD3yQVxlqfyj+ Hk9kZxnRmOq1U1B5Zyif3wLEkLpUQ0DCbp6SblOvBV93455cgldLdmoAibj5hD7nHM xpS18tM7jE9a97d50WcEQNhRCkBGvBCK+PSyTagohuL5H2xXDTyGWtdNHJkMWMbsOi hnWq0dhKt0sPUGMjyNqm6dKIRCknc74gnFYlpXZGJoKp+I0oZ3VFcj2gPxUdTPKDhs 0kEg1Q9bpwg9A== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4NJRP0162vz6tqh; Fri, 25 Nov 2022 08:30:59 +0100 (CET) In-Reply-To: (Stefan Kangas's message of "Thu, 24 Nov 2022 15:27:41 -0800") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:248963 Archived-At: Stefan Kangas writes: > daanturo writes: > >> Tags: patch >> >> Make the prompt a bit more informative, as sometimes I am presented with >> this question at startup without even knowing the cause. > > LGTM. Philip, WDYT? Likewise, can you push the patch? Otherwise I'll do so some time later. >> From dba6787f0cb1e92f3c9eb62b1f7d9ab6599c43a1 Mon Sep 17 00:00:00 2001 >> From: Daanturo >> Date: Fri, 25 Nov 2022 00:06:37 +0700 >> Subject: [PATCH] More informant prompt for package-vc--unpack >> >> * lisp/emacs-lisp/package-vc.el (package-vc--unpack): show the package's >> name while asking whether to overwrite its previous checkout. >> --- >> lisp/emacs-lisp/package-vc.el | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/lisp/emacs-lisp/package-vc.el b/lisp/emacs-lisp/package-vc.el >> index bf1ea2bdf4..a9c1bbfe60 100644 >> --- a/lisp/emacs-lisp/package-vc.el >> +++ b/lisp/emacs-lisp/package-vc.el >> @@ -523,7 +523,7 @@ package-vc--unpack >> (pkg-dir (expand-file-name dirname package-user-dir))) >> (setf (package-desc-dir pkg-desc) pkg-dir) >> (when (file-exists-p pkg-dir) >> - (if (yes-or-no-p "Overwrite previous checkout?") >> + (if (yes-or-no-p (format "Overwrite %s's previous checkout?" name)) >> (package--delete-directory pkg-dir) >> (error "There already exists a checkout for %s" name))) >> (package-vc--clone pkg-desc pkg-spec pkg-dir rev)