* bug#59548: [PATCH] Include the package name in package-vc--unpack's prompt
@ 2022-11-24 17:12 daanturo
2022-11-24 23:27 ` Stefan Kangas
0 siblings, 1 reply; 4+ messages in thread
From: daanturo @ 2022-11-24 17:12 UTC (permalink / raw)
To: 59548
[-- Attachment #1: Type: text/plain, Size: 196 bytes --]
--=-=-=
Content-Type: text/plain
Tags: patch
Make the prompt a bit more informative, as sometimes I am presented with
this question at startup without even knowing the cause.
--
Daanturo.
[-- Attachment #2: 0001-More-informant-prompt-for-package-vc-unpack.patch --]
[-- Type: text/x-patch, Size: 1119 bytes --]
From dba6787f0cb1e92f3c9eb62b1f7d9ab6599c43a1 Mon Sep 17 00:00:00 2001
From: Daanturo <daanturo@gmail.com>
Date: Fri, 25 Nov 2022 00:06:37 +0700
Subject: [PATCH] More informant prompt for package-vc--unpack
* lisp/emacs-lisp/package-vc.el (package-vc--unpack): show the package's
name while asking whether to overwrite its previous checkout.
---
lisp/emacs-lisp/package-vc.el | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lisp/emacs-lisp/package-vc.el b/lisp/emacs-lisp/package-vc.el
index bf1ea2bdf4..a9c1bbfe60 100644
--- a/lisp/emacs-lisp/package-vc.el
+++ b/lisp/emacs-lisp/package-vc.el
@@ -523,7 +523,7 @@ package-vc--unpack
(pkg-dir (expand-file-name dirname package-user-dir)))
(setf (package-desc-dir pkg-desc) pkg-dir)
(when (file-exists-p pkg-dir)
- (if (yes-or-no-p "Overwrite previous checkout?")
+ (if (yes-or-no-p (format "Overwrite %s's previous checkout?" name))
(package--delete-directory pkg-dir)
(error "There already exists a checkout for %s" name)))
(package-vc--clone pkg-desc pkg-spec pkg-dir rev)
--
2.38.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* bug#59548: [PATCH] Include the package name in package-vc--unpack's prompt
2022-11-24 17:12 bug#59548: [PATCH] Include the package name in package-vc--unpack's prompt daanturo
@ 2022-11-24 23:27 ` Stefan Kangas
2022-11-25 7:31 ` Philip Kaludercic
0 siblings, 1 reply; 4+ messages in thread
From: Stefan Kangas @ 2022-11-24 23:27 UTC (permalink / raw)
To: daanturo; +Cc: Philip Kaludercic, 59548
daanturo <daanturo@gmail.com> writes:
> Tags: patch
>
> Make the prompt a bit more informative, as sometimes I am presented with
> this question at startup without even knowing the cause.
LGTM. Philip, WDYT?
> From dba6787f0cb1e92f3c9eb62b1f7d9ab6599c43a1 Mon Sep 17 00:00:00 2001
> From: Daanturo <daanturo@gmail.com>
> Date: Fri, 25 Nov 2022 00:06:37 +0700
> Subject: [PATCH] More informant prompt for package-vc--unpack
>
> * lisp/emacs-lisp/package-vc.el (package-vc--unpack): show the package's
> name while asking whether to overwrite its previous checkout.
> ---
> lisp/emacs-lisp/package-vc.el | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lisp/emacs-lisp/package-vc.el b/lisp/emacs-lisp/package-vc.el
> index bf1ea2bdf4..a9c1bbfe60 100644
> --- a/lisp/emacs-lisp/package-vc.el
> +++ b/lisp/emacs-lisp/package-vc.el
> @@ -523,7 +523,7 @@ package-vc--unpack
> (pkg-dir (expand-file-name dirname package-user-dir)))
> (setf (package-desc-dir pkg-desc) pkg-dir)
> (when (file-exists-p pkg-dir)
> - (if (yes-or-no-p "Overwrite previous checkout?")
> + (if (yes-or-no-p (format "Overwrite %s's previous checkout?" name))
> (package--delete-directory pkg-dir)
> (error "There already exists a checkout for %s" name)))
> (package-vc--clone pkg-desc pkg-spec pkg-dir rev)
^ permalink raw reply [flat|nested] 4+ messages in thread
* bug#59548: [PATCH] Include the package name in package-vc--unpack's prompt
2022-11-24 23:27 ` Stefan Kangas
@ 2022-11-25 7:31 ` Philip Kaludercic
2022-11-25 8:04 ` Stefan Kangas
0 siblings, 1 reply; 4+ messages in thread
From: Philip Kaludercic @ 2022-11-25 7:31 UTC (permalink / raw)
To: Stefan Kangas; +Cc: 59548, daanturo
Stefan Kangas <stefankangas@gmail.com> writes:
> daanturo <daanturo@gmail.com> writes:
>
>> Tags: patch
>>
>> Make the prompt a bit more informative, as sometimes I am presented with
>> this question at startup without even knowing the cause.
>
> LGTM. Philip, WDYT?
Likewise, can you push the patch? Otherwise I'll do so some time later.
>> From dba6787f0cb1e92f3c9eb62b1f7d9ab6599c43a1 Mon Sep 17 00:00:00 2001
>> From: Daanturo <daanturo@gmail.com>
>> Date: Fri, 25 Nov 2022 00:06:37 +0700
>> Subject: [PATCH] More informant prompt for package-vc--unpack
>>
>> * lisp/emacs-lisp/package-vc.el (package-vc--unpack): show the package's
>> name while asking whether to overwrite its previous checkout.
>> ---
>> lisp/emacs-lisp/package-vc.el | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/lisp/emacs-lisp/package-vc.el b/lisp/emacs-lisp/package-vc.el
>> index bf1ea2bdf4..a9c1bbfe60 100644
>> --- a/lisp/emacs-lisp/package-vc.el
>> +++ b/lisp/emacs-lisp/package-vc.el
>> @@ -523,7 +523,7 @@ package-vc--unpack
>> (pkg-dir (expand-file-name dirname package-user-dir)))
>> (setf (package-desc-dir pkg-desc) pkg-dir)
>> (when (file-exists-p pkg-dir)
>> - (if (yes-or-no-p "Overwrite previous checkout?")
>> + (if (yes-or-no-p (format "Overwrite %s's previous checkout?" name))
>> (package--delete-directory pkg-dir)
>> (error "There already exists a checkout for %s" name)))
>> (package-vc--clone pkg-desc pkg-spec pkg-dir rev)
^ permalink raw reply [flat|nested] 4+ messages in thread
* bug#59548: [PATCH] Include the package name in package-vc--unpack's prompt
2022-11-25 7:31 ` Philip Kaludercic
@ 2022-11-25 8:04 ` Stefan Kangas
0 siblings, 0 replies; 4+ messages in thread
From: Stefan Kangas @ 2022-11-25 8:04 UTC (permalink / raw)
To: Philip Kaludercic; +Cc: 59548-done, daanturo
Philip Kaludercic <philipk@posteo.net> writes:
> Likewise, can you push the patch?
Thanks, I pushed it with this modified commit message:
Show package name in package-vc--unpack prompt
* lisp/emacs-lisp/package-vc.el (package-vc--unpack): Display the
package name when asking whether to overwrite its previous
checkout. (Bug#59548)
I also tweaked the message to:
Overwrite previous checkout for package `%s'?
See commit c7a7488c52. Closing the bug.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-11-25 8:04 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-11-24 17:12 bug#59548: [PATCH] Include the package name in package-vc--unpack's prompt daanturo
2022-11-24 23:27 ` Stefan Kangas
2022-11-25 7:31 ` Philip Kaludercic
2022-11-25 8:04 ` Stefan Kangas
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.