From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Theodor Thornhill via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#59660: 29.0.50; typescript-ts-mode consistently fontifies method-names incorrectly Date: Tue, 29 Nov 2022 16:10:06 +0100 Message-ID: <87h6yhajap.fsf@thornhill.no> References: <83k03em05w.fsf@gnu.org> <5c6866bb-c353-58ee-39e4-9d861965e943@secure.kjonigsen.net> Reply-To: Theodor Thornhill Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="21454"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 59660@debbugs.gnu.org, jostein@kjonigsen.net To: Jostein =?UTF-8?Q?Kj=C3=B8nigsen?= , Eli Zaretskii , Yuan Fu Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Nov 29 16:11:29 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1p02Gf-0005OS-0R for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 29 Nov 2022 16:11:29 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p02GH-00014l-H6; Tue, 29 Nov 2022 10:11:05 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p02GE-00012l-No for bug-gnu-emacs@gnu.org; Tue, 29 Nov 2022 10:11:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1p02GE-0006Sa-70 for bug-gnu-emacs@gnu.org; Tue, 29 Nov 2022 10:11:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1p02GD-0003TT-J4 for bug-gnu-emacs@gnu.org; Tue, 29 Nov 2022 10:11:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Theodor Thornhill Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 29 Nov 2022 15:11:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59660 X-GNU-PR-Package: emacs Original-Received: via spool by 59660-submit@debbugs.gnu.org id=B59660.166973461713345 (code B ref 59660); Tue, 29 Nov 2022 15:11:01 +0000 Original-Received: (at 59660) by debbugs.gnu.org; 29 Nov 2022 15:10:17 +0000 Original-Received: from localhost ([127.0.0.1]:54655 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p02FU-0003T9-O5 for submit@debbugs.gnu.org; Tue, 29 Nov 2022 10:10:17 -0500 Original-Received: from out-237.mta0.migadu.com ([91.218.175.237]:64478) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p02FO-0003T1-Qr for 59660@debbugs.gnu.org; Tue, 29 Nov 2022 10:10:15 -0500 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=thornhill.no; s=key1; t=1669734609; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=1RpNUCb1in8XRRrrYOjyXXjfrNQe43vvLwWh12mT1IE=; b=e/DIs+XewtV0xqq0W84v5P/2VC8xWJZe4NY2Nln+ICfrgNRRWxIAL9PxWAAdawul9VKVof efOJ9aMhN9OZaoRVvzoUz/gjXSfgz+PulM9vSR403ultWeu0emdHv3mOij40wlB+meZaOh +QdW8OXUdSVdEHQ6g5AhY4en48iW+vaegTgANLVN+LBXNNGwHMp2Mf4gIPh69eP4ciy8Pd mY9UFO4ByljLJZdaMyw5wQDGF3q9uXOwEjM+HCqmWlXhptYaUOraGTDtPhUpfqVPzuP+Be Tm+JrodrTnJjmha117330xUPgxZ3n8x2rnAsntTD4RWBxGRnvcux2rP4cAeOdQ== In-Reply-To: <5c6866bb-c353-58ee-39e4-9d861965e943@secure.kjonigsen.net> X-Migadu-Flow: FLOW_OUT X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:249407 Archived-At: Jostein Kj=C3=B8nigsen writes: > Cc: 59660@debbugs.gnu.org, theo@thornhill.no >>> From: Yuan Fu >>> Date: Mon, 28 Nov 2022 15:06:30 -0800 >>> >>> Maybe you can remove the :override flag for the property_identifier rul= e, so it doesn=E2=80=99t shadow the function rule? Would that work better? > I plan to test that as quickly as I time permits. If we can make both=20 > behaviours work, that would obviously be the best. >> This could be a personal preference, perhaps? It isn't clear to me that >> only one of the two is definitely correct. So maybe we need a user opti= on >> for which one overrides which? > > I honestly think this is reasonably clear. > > "Properties" with getters and setters are at this point in time almost=20 > entirely unused in EcmaScript/TypeScript space. They are optional and=20 > have complicated syntax, and don't play well with JSON serialization=20 > (and thus can't be used in REST APIs). > > You however cannot write a program without defining or invoking=20 > methods/functions. So not having method-fontification working correctly=20 > will literally impact **all** TypeScript-users. Could you give me a code example, Jostein? I'm just interested in a repro, because I can't reproduce it with the typescript-ts-mode. I tried using this from [0]: ``` class Greeter { greeting: string; constructor(message: string) { this.greeting =3D message; } greet() { return "Hello, " + this.greeting; } } ``` On my end I get no property-face, just function-name-face. Both on constructor and greet. I'm not saying I disagree with you, but what am I missing? Theo [0]: https://www.typescriptlang.org/docs/handbook/classes.html