From: Mickey Petersen <mickey@masteringemacs.org>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 61529@debbugs.gnu.org
Subject: bug#61529: 30.0.50; tree-sitter: weird off-by-one error but only in css-ts-mode(?) with `treesit-node-at'
Date: Wed, 15 Feb 2023 13:42:51 +0000 [thread overview]
Message-ID: <87h6vnjath.fsf@masteringemacs.org> (raw)
In-Reply-To: <83v8k3avv8.fsf@gnu.org>
Eli Zaretskii <eliz@gnu.org> writes:
>> From: Mickey Petersen <mickey@masteringemacs.org>
>> Date: Wed, 15 Feb 2023 08:25:53 +0000
>>
>>
>> With point at '2', then I'd expect `treesit-node-at' to yield that node. But it does not:
>>
>> (cons (point) (treesit-node-at (point)))
>>
>> => (34 . #<treesit-node "(" in 34-35>)
>
> The value of point is the number of the character which _follows_
> point, yes? So when the cursor is on '2', point is actually between
> '(' and '2'. Right? What does this mean in terms of the node that
> should be returned by tree-sitter?
Correct, point is between '(' and '2'. So 34-35 means it occupies
position 34-35 or [34,35). So point is outside the scope of the '('
single-char anonymous node.
Or at least it should be: the problem is that it *is* inside it in
this one weird instance and, near as I can find, only in this mode,
and then only in this place, it isn't. I suspect `treesit-node-at' has
a bug.
Consider:
a {
background: linear-gradient(210deg, rgba(|255,82,41,1) 0%, rgba(251,165,85,1) 54%, rgba(163,73,73,1) 100%);
}
Note the new position of point in rgba. `treesit-node-at` with `(point)` now correctly returns
#<treesit-node integer_value in 48-51>
Move point back one position:
a {
background: linear-gradient(210deg, rgba|(255,82,41,1) 0%, rgba(251,165,85,1) 54%, rgba(163,73,73,1) 100%);
}
And now:
(treesit-node-at (point)) => #<treesit-node "(" in 47-48>
In start contrast to the original example.
next prev parent reply other threads:[~2023-02-15 13:42 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-15 8:25 bug#61529: 30.0.50; tree-sitter: weird off-by-one error but only in css-ts-mode(?) with `treesit-node-at' Mickey Petersen
2023-02-15 13:42 ` Eli Zaretskii
2023-02-15 13:42 ` Mickey Petersen [this message]
2023-02-15 18:35 ` Theodor Thornhill via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-02-15 19:01 ` Mickey Petersen
2023-02-15 19:42 ` Theodor Thornhill via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-02-16 19:48 ` Mickey Petersen
2023-02-16 21:26 ` Dmitry Gutov
2023-02-16 21:34 ` Dmitry Gutov
2023-02-17 6:16 ` Eli Zaretskii
2023-02-17 7:24 ` Mickey Petersen
2023-02-17 15:11 ` Dmitry Gutov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87h6vnjath.fsf@masteringemacs.org \
--to=mickey@masteringemacs.org \
--cc=61529@debbugs.gnu.org \
--cc=eliz@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.