From: "Basil L. Contovounesios" via "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
To: "João Távora" <joaotavora@gmail.com>
Cc: 61637@debbugs.gnu.org
Subject: bug#61637: 30.0.50; Fix Eglot tests that need HOME=~USER
Date: Mon, 20 Feb 2023 09:22:36 +0000 [thread overview]
Message-ID: <87h6vgelnn.fsf@tcd.ie> (raw)
In-Reply-To: <CALDnm53=tsJsqdN9fDezuH56FRc-50Pm0f1s+AXL4MYSBib6SA@mail.gmail.com> ("João Távora"'s message of "Sun, 19 Feb 2023 19:38:47 +0000")
João Távora [2023-02-19 19:38 +0000] wrote:
> Both patches look generally good, though I haven't tested them,
> so I'm trusting you did and they generally add robustness.
Thanks, indeed 'make check' now/still succeeds locally.
> If that's the case, go ahead and push (to emacs-29, presumably
> since this is fixing bugs in the test suite, but master isn't that
> bad either).
The small change in ert-x.el, and the proximity to an emacs-29 RC, are
the reasons I wanted to double check with Eli about where these changes
should go.
Perhaps I should split out the ert-x.el change for master, and the rest
can go to emacs-29?
> The only nit I would point out is that there seems to be some
> unrelated housekeeping already in the first patch that could
> be moved to the second patch, or maybe a separate commit.
You mean, the indentation and commentary fixes? The impression I got is
that these kinds of changes are more welcome in emacs.git when the
surrounding code is already being touched, as opposed to making small
whitespace-only changes to functions that are not otherwise being
changed.
I have little personal preference either way.
> The yasnippet-related fix could also be its own commit. But
> again, that's only a minor nit.
Sure, I can break out the autopep8 and YASnippet changes if that's
preferred.
Thanks,
--
Basil
next prev parent reply other threads:[~2023-02-20 9:22 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-19 19:10 bug#61637: 30.0.50; Fix Eglot tests that need HOME=~USER Basil L. Contovounesios via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-02-19 19:38 ` João Távora
2023-02-20 9:22 ` Basil L. Contovounesios via Bug reports for GNU Emacs, the Swiss army knife of text editors [this message]
2023-02-20 9:30 ` João Távora
2023-02-20 13:02 ` Eli Zaretskii
2023-03-04 1:04 ` João Távora
2023-03-04 7:46 ` Eli Zaretskii
2023-03-04 11:48 ` João Távora
2023-03-04 12:46 ` Eli Zaretskii
2023-03-04 13:23 ` João Távora
2023-03-04 15:04 ` Eli Zaretskii
2023-03-04 17:21 ` Basil Contovounesios via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-03-04 19:35 ` João Távora
2023-03-04 17:28 ` Basil Contovounesios via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-03-04 19:22 ` João Távora
2023-04-10 10:09 ` Basil Contovounesios via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-03-04 17:20 ` Basil Contovounesios via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-03-04 17:26 ` Basil Contovounesios via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-03-04 19:19 ` João Távora
2023-03-04 17:19 ` Basil Contovounesios via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-03-04 18:09 ` Eli Zaretskii
2023-03-04 19:27 ` João Távora
2023-03-04 19:25 ` João Távora
2023-02-20 13:01 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87h6vgelnn.fsf@tcd.ie \
--to=bug-gnu-emacs@gnu.org \
--cc=61637@debbugs.gnu.org \
--cc=contovob@tcd.ie \
--cc=joaotavora@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.