From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id +M2CDAZBKWSVygAASxT56A (envelope-from ) for ; Sun, 02 Apr 2023 10:47:02 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id mElxDAZBKWQ7JwAA9RJhRA (envelope-from ) for ; Sun, 02 Apr 2023 10:47:02 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id CF0214397A for ; Sun, 2 Apr 2023 10:47:01 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pitLs-0002QY-3y; Sun, 02 Apr 2023 04:46:16 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pitLq-0002QO-Hi for emacs-orgmode@gnu.org; Sun, 02 Apr 2023 04:46:14 -0400 Received: from mout02.posteo.de ([185.67.36.66]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pitLo-0000L3-Qm for emacs-orgmode@gnu.org; Sun, 02 Apr 2023 04:46:14 -0400 Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id 597662404B3 for ; Sun, 2 Apr 2023 10:46:08 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1680425168; bh=ZXSDHoYyq1q1xqcGNwBdh3f2RzzpRqsCj+FPTj1tnyk=; h=From:To:Cc:Subject:Date:From; b=Ikl99KeH0qOLKhavJKA3B/FjcYPMvNu/j6BCDikhPjUZYPjeqYlf0OpewMSJB8h0i oUr4XmudYrKQKQL/bfQVT31U03RKVg1NAg6Ogw4I0OFFW2jHm3gK0ShVJ6HNrHradc Xpxa9roxAMgryO6HspjeD6PH5wfbl/dMaw26DI20FzX/X216eIKHl8DEGkCLJAR3FH fvo4UDGoJFcfMf256NVEOlcM4U4v72udKuyhuxjwbKFPkFdpP5s9Jk+pish2wzo7fe f6ISG4T6VuIcrl4gVDLto7CmwQ0odT+RpLoK3bmuFBrr/xxWPNwo7sNxxtERwa1O83 Vsb/LTd+rZ7bQ== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4Pq70b4W2rz9rxD; Sun, 2 Apr 2023 10:46:07 +0200 (CEST) From: Ihor Radchenko To: Jack Kamm Cc: emacs-orgmode@gnu.org, mail@nicolasgoaziou.fr Subject: Re: [RFC] ox-icalendar: Unscheduled tasks & repeating tasks In-Reply-To: <87h6tzjejv.fsf@gmail.com> References: <874jq75okg.fsf@gmail.com> <87o7oetneo.fsf@localhost> <87r0t5jwgy.fsf@gmail.com> <87v8ih9ihw.fsf@localhost> <87o7o8kji5.fsf@gmail.com> <87fs9kajx7.fsf@localhost> <87jzywk1fs.fsf@gmail.com> <87tty0f1i5.fsf@localhost> <87h6tzjejv.fsf@gmail.com> Date: Sun, 02 Apr 2023 08:48:23 +0000 Message-ID: <87h6tymzzc.fsf@localhost> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=185.67.36.66; envelope-from=yantar92@posteo.net; helo=mout02.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: emacs-orgmode-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN ARC-Seal: i=1; s=key1; d=yhetil.org; t=1680425221; a=rsa-sha256; cv=none; b=s4ncBvgNkFsJxb6YuYlQqO9wZqJ+In9Cv7w7aLJ3p8p8MjfxhMtl7+jbmzTH3MscthYMFi n1l3Pa5ysmtIcpoD1QZZYKbMFHozp6aDtOtrMtlk5NM2rBd4RoEdsmUih+f17N70bgDr8Q I5cNqSohB1zaU14zeNLtL1PsBQ0QnB6nOQDvizSXLg5ugqdtYekraa89Xdsfkybj3P/6JR 16X8giqSFxTSZ0GcVnZIApNsXBBtlyL6UviGU5IWxesiVaWPm6fDshOLhsaFACiRmq0e6o 4gHJvf9rs2ASdzJT1dZwZFU0H7K4qWVRHnNE17RG6cKEAMm8RX9Ny2av5UzDmA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=posteo.net header.s=2017 header.b=Ikl99KeH; dmarc=pass (policy=none) header.from=posteo.net; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1680425221; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=TchePg3BfUdj1dmdiJAYReUbSJ+dxs2i4zuy7RoTkjU=; b=Yh3ZyhKl1M9k1+Baw3SqzZTkj33ckyxfoNlIprtnf1pBKd+WWELntgwaqEXoRaME1TB70x vwIGfvWtnjC5Q/m/4DbpwlrbdehrvTVzZ/4bwCEGwkvRSY2F9R/pHXodlo0gEcH8RrZhRR xYA9oUtb/QqPPkI6dAvt0NsPfQXzc7MMtAtWcswZf0YQU8Fz/7DK1EiGzil45k5nD+MCM6 1JHM3JRoWVW5T4fAGfo6yDJmwA0aHgg4kILor+JuPUn9v4Xt1IRMOuwkfiHtOSGjMsGXnp z3C4hUoKnU+0n4nAOfa6Pj9NeRGqjH2MNuc2BB5jVvE5F3ZyS2rO9bFJ47dqjg== X-Migadu-Spam-Score: -4.74 X-Migadu-Scanner: scn1.migadu.com Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=posteo.net header.s=2017 header.b=Ikl99KeH; dmarc=pass (policy=none) header.from=posteo.net; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" X-Spam-Score: -4.74 X-Migadu-Queue-Id: CF0214397A X-TUID: M9OmIF3UGnfP Jack Kamm writes: >> We likely want (according to 34.10.1 Basic Concepts of Coding Systems): > > I attach a new patch, which takes the approach of converting to > utf-8-dos in `org-icalendar-after-save-hook', instead of converting > newlines in `org-icalendar-fold-string'. > > I think this way is simpler, and should be more robust across locales. > > Note, this means the string returned by `org-export-as' won't contain > CRLF. Instead, the newlines are converted during post-process. Looks reasonable, but I have one comment on the code. > +(add-hook 'org-icalendar-after-save-hook #'org-icalendar--convert-eol -90) We should not use user-defined hooks for things that must be executed. Imagine that a user customizes the hook after loading ox-icalendar and removes the call to `org-icalendar--convert-eol'? Instead, we should better explicitly call the necessary functions. I was told this by Emacs devs. -- Ihor Radchenko // yantar92, Org mode contributor, Learn more about Org mode at . Support Org development at , or support my work at