From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Rah Guzar via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#62679: 29.0.60; Bindings on `image-map` cause error on sliced images Date: Sat, 08 Apr 2023 20:29:45 +0200 Message-ID: <87h6tqb4kn.fsf@zohomail.eu> References: <87ttxubahz.fsf@zohomail.eu> <83o7o1qrew.fsf@gnu.org> <87pm8hat4s.fsf@zohomail.eu> <83y1n5ou6l.fsf@gnu.org> <87lej4c0o5.fsf@zohomail.eu> <83zg7in1tc.fsf@gnu.org> Reply-To: Rah Guzar Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="39642"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: mu4e 1.10.1; emacs 29.0.60 Cc: larsi@gnus.org, 62679-done@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Apr 08 20:41:20 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1plDV1-000A6C-SV for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 08 Apr 2023 20:41:20 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1plDUm-0004G7-73; Sat, 08 Apr 2023 14:41:04 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1plDUk-0004Fv-Gc for bug-gnu-emacs@gnu.org; Sat, 08 Apr 2023 14:41:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1plDUk-0004pB-8s for bug-gnu-emacs@gnu.org; Sat, 08 Apr 2023 14:41:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1plDUk-0006Wl-5I for bug-gnu-emacs@gnu.org; Sat, 08 Apr 2023 14:41:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Rah Guzar Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 08 Apr 2023 18:41:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62679 X-GNU-PR-Package: emacs Original-Received: via spool by 62679-done@debbugs.gnu.org id=D62679.168097923825053 (code D ref 62679); Sat, 08 Apr 2023 18:41:02 +0000 Original-Received: (at 62679-done) by debbugs.gnu.org; 8 Apr 2023 18:40:38 +0000 Original-Received: from localhost ([127.0.0.1]:59521 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1plDUM-0006W1-7q for submit@debbugs.gnu.org; Sat, 08 Apr 2023 14:40:38 -0400 Original-Received: from sender11-pp-o93.zoho.eu ([31.186.226.251]:25826) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1plDUK-0006Vs-Sc for 62679-done@debbugs.gnu.org; Sat, 08 Apr 2023 14:40:37 -0400 ARC-Seal: i=1; a=rsa-sha256; t=1680979227; cv=none; d=zohomail.eu; s=zohoarc; b=WQmoGqpbiwN6GzFis0A++P8HJiqfoHVAq2gfQkqoI2TGuuYbp4w+7ogIq5SlBwIP0BGBX1iNlREFt6PS/H6Xfag5lam8/cfPmN40ZxnmRTL5z12t4KWQn/FEsSZfKxQKj6cPXn9t93imFlsApXCLMOj/9TJYJ55tGLyBsoH5mLg= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.eu; s=zohoarc; t=1680979227; h=Content-Type:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=f18hRJGQkLlHocNcpK824h1V+U3+7xHKqDuJ8x07bC4=; b=I2SnXdt5LbYmY5mLjB7G6KTkU40LUfKgZVju+mGWHK+UqDYvygQS1ggDiO9Wi5qKejOBgbJy5y8Fql+WafzJqDppfN36LFn1pMuELvWKq0Qc9oYOiHFKngHhBMFxCORcHawUHFScYH2lqfTCi4RhwzW191VC/OpkcOuD15acJhg= ARC-Authentication-Results: i=1; mx.zohomail.eu; dkim=pass header.i=zohomail.eu; spf=pass smtp.mailfrom=rahguzar@zohomail.eu; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1680979227; s=zoho; d=zohomail.eu; i=rahguzar@zohomail.eu; h=References:From:From:To:To:Cc:Cc:Subject:Subject:Date:Date:In-reply-to:Message-ID:MIME-Version:Content-Type:Message-Id:Reply-To; bh=f18hRJGQkLlHocNcpK824h1V+U3+7xHKqDuJ8x07bC4=; b=IVcDzxnhXV6D6t3P9YEbep6XVtrk3LV+ys2FtoqJOYw1jHv0ZipgwIB39Ae4EJzJ RTnfXj8uLRcItomLgEDjPDaFOMWTbhSAshE+4Qt/WWc94l9CsB0+ntsLm6r1BpyblSs dpm9fkwU3S2qFv5Fk22NwhJhgqMtTchmDDw+dq20= Original-Received: from localhost (81-231-79-170-no600.tbcn.telia.com [81.231.79.170]) by mx.zoho.eu with SMTPS id 1680979226543461.33498706999796; Sat, 8 Apr 2023 20:40:26 +0200 (CEST) In-reply-to: <83zg7in1tc.fsf@gnu.org> X-ZohoMailClient: External X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:259488 Archived-At: Hi Eli, Thanks for the changes. Everything work as expected for me now. However, the new keymap is only partially effective. I cannot use "i r" to rotate a sliced image now but it is possible to do it using "i + r" i.e. the mechanism that is used to allow performing repeated manipulations still uses a map which allows rotations. Eli Zaretskii writes: >> From: Rah Guzar >> Cc: larsi@gnus.org, 62679@debbugs.gnu.org >> Date: Thu, 06 Apr 2023 20:30:19 +0200 >> >> > I cannot reproduce this. On my system, if I move point with the right >> > arrow key, "M-x describe-text-properties" doesn't show the keymap >> > property. >> >> You are right there is no keymap property there but somehow "image-map" >> is still active. I can press "i +" there and see the error while after or >> before the image pressing "i +" will insert the two characters. > > Thanks, I fixed this now on the emacs-29 branch. > >> >> According to the info manual, the advantage of using sliced images is >> >> to get a more intuitive scrolling behavior and that is the reason I am >> >> using them. I think for everything else the image should behave as a >> >> single image. For that reason the behavior of "i r" seems correct to >> >> me. It rotates the image and then slices. >> > >> > If this is what you see, I guess you have Emacs built with >> > ImageMagick? I don't see "rotation followed by slicing", because the >> > code doesn't do that, at least not with rotation that is implemented >> > natively in Emacs on my system. But, as I said, rotation of sliced >> > image is not well defined, so my opinion is that people should not >> > depend on it doing something sensible. >> >> Evaluating "(image-type-available-p 'imagemagick)" returns nil so I >> think Emacs is built without imagemagick support. The sequence of >> command I ran to build it were >> ./configure --with-pgtk >> make >> make bootstrap >> where the first make failed due to some org issue. >> >> But to the broader point about rotation not being sensible I think it >> might be a good idea to put a different keymap on sliced images in that >> case. Maybe "sliced-image-map" which should be the parent of >> "image-map". I don't see any misbehavior though. > > I added a new map, in which some commands that have no meaning for > sliced images are absent. > > And with that, I'm closing this bug. Thanks a lot, Rah Guzar