From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Philip Kaludercic Newsgroups: gmane.emacs.devel Subject: Re: [ELPA] New package: calibre.el Date: Thu, 20 Apr 2023 18:26:42 +0000 Message-ID: <87h6ta2yvx.fsf@posteo.net> References: <87v8ht3etv.fsf@posteo.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="6900"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel To: Kjartan =?utf-8?Q?=C3=93li_=C3=81gustsson?= Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Apr 20 20:27:08 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ppYzr-0001Ya-UP for ged-emacs-devel@m.gmane-mx.org; Thu, 20 Apr 2023 20:27:08 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ppYz2-0004G6-3C; Thu, 20 Apr 2023 14:26:16 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ppYz0-0004ES-Gq for emacs-devel@gnu.org; Thu, 20 Apr 2023 14:26:14 -0400 Original-Received: from mout02.posteo.de ([185.67.36.66]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ppYyy-0002WG-VA for emacs-devel@gnu.org; Thu, 20 Apr 2023 14:26:14 -0400 Original-Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id 842842402CC for ; Thu, 20 Apr 2023 20:26:11 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1682015171; bh=RCLGXuyNpZUEv2PYentO6WpIOToAEEGF11Z9bmJp2Zg=; h=From:To:Cc:Subject:Autocrypt:Date:From; b=S0PQW6frnbkGm1vByRgwFGIgbryrzJ3AGfd2+RN2E6XN2uILc0HowEkaI06DPRNE6 s10F2tI8q+YI4LhmIyZ7g4YIaZcIJ3V0q9Vm6ATFoXyqgnZrws4ZVYNhHn0qZCzZec eBZGGMzMHL9Q59qAQ7zD51yZXdy8vaR7WSqwyQ3Di1fzFLzxWjC1EdNIyBYmzrER4T z1lV9R/lbmww1q5pEVWeAz2lldE1JHGqbk4Iw+ESxehynhABqkdK66ZWawfqxHDMSf Lk/qxehZKdKprrE4ihuuSvR+gj7lC7xl57V4BZ6DOYjEuAJt1MIS4BaDj9PGtIVpCg PO8gPLY4k8Nyw== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4Q2R1b1gw8z6tx3; Thu, 20 Apr 2023 20:26:11 +0200 (CEST) In-Reply-To: ("Kjartan =?utf-8?Q?=C3=93li_=C3=81gustsson=22's?= message of "Tue, 18 Apr 2023 08:19:59 +0000") Autocrypt: addr=philipk@posteo.net; keydata= mDMEZBBQQhYJKwYBBAHaRw8BAQdAHJuofBrfqFh12uQu0Yi7mrl525F28eTmwUDflFNmdui0QlBo aWxpcCBLYWx1ZGVyY2ljIChnZW5lcmF0ZWQgYnkgYXV0b2NyeXB0LmVsKSA8cGhpbGlwa0Bwb3N0 ZW8ubmV0PoiWBBMWCAA+FiEEDg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwMFCQHhM4AFCwkI BwIGFQoJCAsCBBYCAwECHgECF4AACgkQ8xYDWXahwulikAEA77hloUiSrXgFkUVJhlKBpLCHUjA0 mWZ9j9w5d08+jVwBAK6c4iGP7j+/PhbkxaEKa4V3MzIl7zJkcNNjHCXmvFcEuDgEZBBQQhIKKwYB BAGXVQEFAQEHQI5NLiLRjZy3OfSt1dhCmFyn+fN/QKELUYQetiaoe+MMAwEIB4h+BBgWCAAmFiEE Dg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwwFCQHhM4AACgkQ8xYDWXahwukm+wEA8cml4JpK NeAu65rg+auKrPOP6TP/4YWRCTIvuYDm0joBALw98AMz7/qMHvSCeU/hw9PL6u6R2EScxtpKnWof z4oM Received-SPF: pass client-ip=185.67.36.66; envelope-from=philipk@posteo.net; helo=mout02.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:305521 Archived-At: Kjartan =C3=93li =C3=81gustsson writes: >>> This is my first attempt at writing an Emacs package, so I expect to >>> have gotten many things wrong. As such I would welcome reviews from >>> people who know more about Elisp packaging. >> >> The first thing to note is that you don't need a -pkg.el file. ELPA >> will generate one for you using the metadata in the main file and >> overwrite whatever you have written. > > Another good to know. I remember reading that somewhere, but then I > looked at some other packages that seemed to maintain a -pkg.el file. It is a common mistake or a MELPA-ism I don't know about ^^. > As for the usage of eieio, is there a reason not to use it? If you just need a structure then cl-defstruct should be a less-heavy solution.