From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?utf-8?Q?Bj=C3=B6rn?= Bidar Newsgroups: gmane.emacs.devel Subject: Re: New Git hooks for checking file names in commit messages Date: Sun, 23 Apr 2023 12:51:16 +0300 Message-ID: <87h6t7gc4r.fsf@thaodan.de> References: <838rel46ou.fsf@gnu.org> <865y9ptfa3.fsf@aarsen.me> <83354t44kn.fsf@gnu.org> <875y9p2h3u.fsf@thaodan.de> <83h6t82yao.fsf@gnu.org> <0a76fcd4-df69-56e0-ba90-30dc211ad56e@gmail.com> <83v8hnyvou.fsf@gnu.org> <5c8a8bd8-e0b3-42ac-e278-242379b146e6@gmail.com> <83mt2zyrlh.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="1368"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Jim Porter , arsen@aarsen.me, acm@muc.de, emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Apr 23 11:52:02 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pqWO2-000097-OS for ged-emacs-devel@m.gmane-mx.org; Sun, 23 Apr 2023 11:52:02 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pqWNS-0007AD-SA; Sun, 23 Apr 2023 05:51:26 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pqWNN-00079h-GO for emacs-devel@gnu.org; Sun, 23 Apr 2023 05:51:22 -0400 Original-Received: from thaodan.de ([185.216.177.71]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pqWNL-00079P-H1; Sun, 23 Apr 2023 05:51:21 -0400 Original-Received: from odin (unknown [IPv6:2001:2062:2301:f400:642:1aff:fe03:549e]) by thaodan.de (Postfix) with ESMTPSA id C165FD08DB2; Sun, 23 Apr 2023 12:51:17 +0300 (EEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=thaodan.de; s=mail; t=1682243478; bh=QEJc4HcfjCV5Fdcgh4DPEiTFeTWvoqJ0uloK4zuaOFs=; h=From:To:Cc:Subject:In-Reply-To:References:Date; b=kxAupBnQdWfSmLuuFNTRXHvIb1BKWQsVLTNQGe3Gyc2eDXiTaidTGj9WNgufgjqyx pa0o+SOgQhQwcELCQKJOuLowN0UJTfsDysdGx/SZNUtE+M2tMTHNZJBNw2Ea+wVQKm D2UGtEvlIHlLGGXz5fUYtiFZ5EyI2XRQlEGFzpU+dpTAfseBV0IV0x7yPJ+KPMWZw0 79ZUyKppyNgo5tW3T/gU7ldHxyNfwT5NJZ61my8eoy9dT0dXAvQ9IjzQSccjTGkWE4 qQItTbYxJjWnLfbp4oQU0DFjuC7PNYidbfNrEHbx0mykLqyXN3yWI/ohMoMWyQsb+Z u5Lyf4pjZhxW+wrBcXMrkpwfQXOVHcj92FKfDH+a4QFdVcfU4ZZeIXEix/X+VuXZgZ S4jkbzgxX+JSVNNap/gqLRNY05YtFISbiOBiVdfjWoH1LLJ7VXzy3eHenc7HP/GUd9 dcSXGV7qGCYPxnOZAy2rfYdPtg5wAnEc47SpE7fs2y+Dj89WVqtrS+3HHZ6Vlw0oIK wdQ3sMsdAZQJRGQa5up1JiiT3GiTQ63UPLz7v5P+hhncVSol2YVzSHQiKaa8TA7ch3 2L2FYv+GxvIdyMhd186N7/7yxdTwI0jyWhlGvIckq3LNhX/SkbQJyR9RgVzv+P8+mn KH49U43HFe7ZMYItne1Jt8uY= In-Reply-To: <83mt2zyrlh.fsf@gnu.org> (Eli Zaretskii's message of "Sun, 23 Apr 2023 10:39:54 +0300") Received-SPF: pass client-ip=185.216.177.71; envelope-from=bjorn.bidar@thaodan.de; helo=thaodan.de X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:305603 Archived-At: Eli Zaretskii writes: >> This would mean that a committer sees a warning about bad log messages >> (at post-commit time), but it doesn't actually prevent them from doing >> anything. A warning might be too easy to ignore, but maybe it's better >> than being silent about it. I'm not sure what to do here... > > A warning that doesn't preclude a commit from being pushed is much > less useful, IMO. I agree, especially if using a git frontend such as magit where you maybe not see the full message unless you press $. There are always options to disable the hooks in exceptional cases.