From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Tony Zorman via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#60418: [PATCH] Add :vc keyword to use-package Date: Tue, 02 May 2023 16:22:17 +0200 Message-ID: <87h6suolt2.fsf@hyperspace> References: <87zgb6uk2r.fsf@hyperspace> <87a5zt2emd.fsf@betli.tmit.bme.hu> <87fs9l9bim.fsf@posteo.net> <87y1n3zsro.fsf@posteo.net> <871qku220f.fsf@betli.tmit.bme.hu> <874jpq920b.fsf@posteo.net> <87cz4ezpwi.fsf@betli.tmit.bme.hu> <87h6tlinft.fsf@hyperspace> <87r0spa712.fsf@posteo.net> <87edopiif5.fsf@hyperspace> <87wn2bzvcp.fsf@hyperspace> <835y9vbyfr.fsf@gnu.org> <87mt36uwl8.fsf@hyperspace> <83ttxd8k1z.fsf@gnu.org> <87v8hrn56l.fsf@hyperspace> <87cz3w2lvb.fsf@posteo.net> <87jzy3ku6u.fsf@hyperspace> <87bkje93ou.fsf@posteo.net> <87y1mhihhy.fsf@hyperspace> <87ildbet2d.fsf@hyperspace> <831qjyoqj5.fsf@gnu.org> Reply-To: Tony Zorman Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="30547"; mail-complaints-to="usenet@ciao.gmane.io" Cc: philipk@posteo.net, felician.nemeth@gmail.com, 60418@debbugs.gnu.org, stefankangas@gmail.com To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue May 02 16:23:29 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ptqud-0007iO-JA for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 02 May 2023 16:23:27 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ptquG-0007g5-Mm; Tue, 02 May 2023 10:23:04 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ptquE-0007ex-Pi for bug-gnu-emacs@gnu.org; Tue, 02 May 2023 10:23:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ptquD-0008IY-SO for bug-gnu-emacs@gnu.org; Tue, 02 May 2023 10:23:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ptquD-0005jg-Np for bug-gnu-emacs@gnu.org; Tue, 02 May 2023 10:23:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Tony Zorman Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 02 May 2023 14:23:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 60418 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 60418-submit@debbugs.gnu.org id=B60418.168303735522007 (code B ref 60418); Tue, 02 May 2023 14:23:01 +0000 Original-Received: (at 60418) by debbugs.gnu.org; 2 May 2023 14:22:35 +0000 Original-Received: from localhost ([127.0.0.1]:44780 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ptqtm-0005it-Gv for submit@debbugs.gnu.org; Tue, 02 May 2023 10:22:34 -0400 Original-Received: from mout-p-101.mailbox.org ([80.241.56.151]:54400) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ptqti-0005ia-EC for 60418@debbugs.gnu.org; Tue, 02 May 2023 10:22:32 -0400 Original-Received: from smtp1.mailbox.org (smtp1.mailbox.org [IPv6:2001:67c:2050:b231:465::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-384) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-p-101.mailbox.org (Postfix) with ESMTPS id 4Q9j2k5bbXz9t1h; Tue, 2 May 2023 16:22:22 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mailbox.org; s=mail20150812; t=1683037342; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=V2ptyZGcjLLRVfneU4HtoxE622xe2JaSmETTF/rAPyM=; b=FQZqGOqkQxn8rZTGHvimuisdeFEmDSFnYf9fwAXxT84C/R2IunNho49oRygEdZ8SZ864hq 2Y2eOzZQzXn67r8iIHADwF3z7FYSi6UHC19X2v8ImxNrnavqkYVxnqSwIgn3PCvUgN32rZ AnKHIQoO+hHZhm8OlwxsvJAqSCmWIAO2sVeuVnyl7l+LINEqtsYHKIhL9n9DjK4A3pPCVg 3bm83GW7nJH0Erhvr+MsRL8k9+Ba8b2Hg+eCjzZzjlcLSrty1OGUh0FKUASi0V/V1Nxmy4 sfTunJ/mCc1JRPDKOPGNv26E4eCC6yDTzQ3eeWwYS/7fbaAcVjhT870I9c57aA== In-Reply-To: <831qjyoqj5.fsf@gnu.org> X-MBO-RS-META: 6ex6fdyxeiyrckggw3h5ja4i3rqh5sep X-MBO-RS-ID: 9006e0e2af500da1169 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:260931 Archived-At: On Tue, May 02 2023 15:40, Eli Zaretskii wrote: >> +@code{package-vc-install}. Notably -- even when not specified -- >> +@code{:rev} defaults to checking out the last release of the package. >> +You can use @code{:rev :newest} to check out the latest commit. >> + >> +For example, >> + >> +@example >> +@group >> +(use-package bbdb >> + :vc (:url "https://git.savannah.nongnu.org/git/bbdb.git" >> + :rev :newest)) >> +@end group >> +@end example >> + >> +would try -- by invoking @code{package-vc-install} -- to install the >> +latest commit of the package @code{foo} from the specified remote. > ^^^ > A typo there. > > Also, you say above "the latest release", but then "the latest > commit". These two are not the same, and in fact I think talking > about "release" here is misleading, since you actually mean "commit". > For the same reason, I think the text should explain how to indicate a > commit that is not the latest one, because that is also not > self-evident, especially since the upstream VCS is not necessarily > Git. I think the terminology of commit and release I use here are consistent, though maybe the wording is perhaps not entirely clear. If :rev is not explicitly given, then :vc falls back to calling package-vc-install (in the case of a non-local upstream) with the :last-release keyword in place of its REV argument (which is called a revision in the docs). Since package-vc.el freely calls :last-release a release of a package, I figured this terminology is appropriate here. It is only when :rev :newest is given that I talk about commits, which should also be accurate. Or perhaps you mean that I mistakenly talk about the latest release in some other place that I've overlooked just now? -- Tony Zorman | https://tony-zorman.com/