From: Michael Albinus <michael.albinus@gmx.de>
To: Spencer Baugh <sbaugh@janestreet.com>
Cc: 63539@debbugs.gnu.org
Subject: bug#63539: 29.0.90; TRAMP fails to detect shell prompts containing ]
Date: Wed, 17 May 2023 17:39:28 +0200 [thread overview]
Message-ID: <87h6sbufv3.fsf@gmx.de> (raw)
In-Reply-To: <ierzg63nguv.fsf@janestreet.com> (Spencer Baugh's message of "Wed, 17 May 2023 10:59:52 -0400")
Spencer Baugh <sbaugh@janestreet.com> writes:
Hi Spence,
>> Oh no! There are much more escape sequences but for coloring. We would
>> open a can of worms if we start to handle them in Tramp regexps.
>
> Wait, but we already have exactly this kind of regexp for escape
> characters in tramp-shell-prompt-regexp. That's where I copied
> this regexp from.
I know. But there are problems with it:
- It isn't sufficient. We have at least the zle Problem with a remote
zsh, which is also an escape sequence (I believe). So the regexp would
need to be extended, which isn't the way we should go, I believe.
- We cannot change shell-prompt-pattern just for Tramp. As said, it is
used also at other places in Emacs and in external packages, and I
don't know whether there would be collateral damages.
That's why I've proposed the alternative, filtering out escape
sequences. Using existing functions from specialized packages.
Best regards, Michael.
next prev parent reply other threads:[~2023-05-17 15:39 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-16 16:40 bug#63539: 29.0.90; TRAMP fails to detect shell prompts containing ] Spencer Baugh
2023-05-16 17:53 ` Michael Albinus
2023-05-16 19:28 ` Spencer Baugh
2023-05-16 20:06 ` Spencer Baugh
2023-05-17 14:07 ` Michael Albinus
2023-05-17 14:59 ` Spencer Baugh
2023-05-17 15:39 ` Michael Albinus [this message]
2023-05-17 16:56 ` Michael Albinus
2023-05-17 17:28 ` Michael Albinus
2023-05-17 18:08 ` Spencer Baugh
2023-05-17 18:41 ` Michael Albinus
2023-05-18 15:49 ` Michael Albinus
2023-05-20 10:18 ` Michael Albinus
2023-05-22 17:30 ` Spencer Baugh
2023-05-22 19:17 ` Michael Albinus
2023-05-22 19:45 ` Spencer Baugh
2023-05-23 13:49 ` Michael Albinus
2023-05-23 14:34 ` Spencer Baugh
2023-05-23 16:31 ` Michael Albinus
2023-05-25 7:36 ` Michael Albinus
2023-05-17 13:53 ` Michael Albinus
2023-05-17 14:04 ` Spencer Baugh
2023-05-17 14:12 ` Michael Albinus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87h6sbufv3.fsf@gmx.de \
--to=michael.albinus@gmx.de \
--cc=63539@debbugs.gnu.org \
--cc=sbaugh@janestreet.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.