From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Philip Kaludercic Newsgroups: gmane.emacs.bugs Subject: bug#63757: 29.0.91 order of package paths changed: random old versions of packages in load-path Date: Sun, 04 Jun 2023 09:19:28 +0000 Message-ID: <87h6rnoa8v.fsf@posteo.net> References: <83y1l7gzqw.fsf@gnu.org> <87ilcb2p1l.fsf@posteo.net> <87sfb8g85v.fsf@posteo.net> <83a5xf7pi5.fsf@gnu.org> <87ttvnoehl.fsf@posteo.net> <8335377iyo.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="36784"; mail-complaints-to="usenet@ciao.gmane.io" Cc: artscan@list.ru, 63757@debbugs.gnu.org, monnier@iro.umontreal.ca To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Jun 04 11:20:27 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1q5juU-0009MO-Sg for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 04 Jun 2023 11:20:27 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1q5ju8-00009H-TS; Sun, 04 Jun 2023 05:20:05 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q5ju6-000096-7t for bug-gnu-emacs@gnu.org; Sun, 04 Jun 2023 05:20:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1q5ju5-00050D-U0 for bug-gnu-emacs@gnu.org; Sun, 04 Jun 2023 05:20:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1q5ju5-0003aC-Pz for bug-gnu-emacs@gnu.org; Sun, 04 Jun 2023 05:20:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Philip Kaludercic Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 04 Jun 2023 09:20:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 63757 X-GNU-PR-Package: emacs Original-Received: via spool by 63757-submit@debbugs.gnu.org id=B63757.168587037713735 (code B ref 63757); Sun, 04 Jun 2023 09:20:01 +0000 Original-Received: (at 63757) by debbugs.gnu.org; 4 Jun 2023 09:19:37 +0000 Original-Received: from localhost ([127.0.0.1]:45017 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q5jth-0003ZR-2Y for submit@debbugs.gnu.org; Sun, 04 Jun 2023 05:19:37 -0400 Original-Received: from mout01.posteo.de ([185.67.36.65]:41309) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q5jtf-0003Z9-DJ for 63757@debbugs.gnu.org; Sun, 04 Jun 2023 05:19:36 -0400 Original-Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id D8FF4240027 for <63757@debbugs.gnu.org>; Sun, 4 Jun 2023 11:19:29 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1685870369; bh=nAaDa8qKLyngGcFSPHBuVrk8vEYOnRjWDwxseAwmMKg=; h=From:To:Cc:Subject:Autocrypt:Date:Message-ID:MIME-Version:From; b=VRLwMUjuu16QP6CCXx0VCE5CH/iIUdN8XVrf2LodEIQOqj55YUAr1DIUNy8HETmHC WOFoOZukCrpAs6I2d7dqiTbXwT9pXQXknDX5+ezThtd5v22rmsP+nnGyDhM7LnPH2U WyQoLwF3+XTYJP8DFOVvAtx+CTI/yLcfFl3CvMjGB6rd859+A9Z7hfBwrikYmo2B6a 3L9qusv/RPb9MsSkfO3dDdNOP0vDc4F2rrjmSK1Cg3tAS+u7r1bJkteT5Ggv5i+5Kt aJPg/N3CaG7ihhbbWOlMYHUpNZRcQGg/utDGbadi9Z83gOhwqTCmENRbln6stxSxVS Bx/8LrLhzUGwg== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4QYrm060btz9rxR; Sun, 4 Jun 2023 11:19:28 +0200 (CEST) In-Reply-To: <8335377iyo.fsf@gnu.org> (Eli Zaretskii's message of "Sun, 04 Jun 2023 11:03:11 +0300") Autocrypt: addr=philipk@posteo.net; keydata= mDMEZBBQQhYJKwYBBAHaRw8BAQdAHJuofBrfqFh12uQu0Yi7mrl525F28eTmwUDflFNmdui0QlBo aWxpcCBLYWx1ZGVyY2ljIChnZW5lcmF0ZWQgYnkgYXV0b2NyeXB0LmVsKSA8cGhpbGlwa0Bwb3N0 ZW8ubmV0PoiWBBMWCAA+FiEEDg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwMFCQHhM4AFCwkI BwIGFQoJCAsCBBYCAwECHgECF4AACgkQ8xYDWXahwulikAEA77hloUiSrXgFkUVJhlKBpLCHUjA0 mWZ9j9w5d08+jVwBAK6c4iGP7j+/PhbkxaEKa4V3MzIl7zJkcNNjHCXmvFcEuDgEZBBQQhIKKwYB BAGXVQEFAQEHQI5NLiLRjZy3OfSt1dhCmFyn+fN/QKELUYQetiaoe+MMAwEIB4h+BBgWCAAmFiEE Dg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwwFCQHhM4AACgkQ8xYDWXahwukm+wEA8cml4JpK NeAu65rg+auKrPOP6TP/4YWRCTIvuYDm0joBALw98AMz7/qMHvSCeU/hw9PL6u6R2EScxtpKnWof z4oM X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:262926 Archived-At: --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Eli Zaretskii writes: >> From: Philip Kaludercic >> Cc: =D0=95=D0=B2=D0=B3=D0=B5=D0=BD=D0=B8=D0=B9 =D0=91=D0=BE=D0=B9=D0=BA= =D0=BE=D0=B2 , >> monnier@iro.umontreal.ca, >> 63757@debbugs.gnu.org >> Date: Sun, 04 Jun 2023 07:47:50 +0000 >>=20 >> Eli Zaretskii writes: >>=20 >> > Is this problem new in Emacs 29, or did it exist in Emacs 28 as well? >> > If it is new, which change(s) caused the incorrect ordering of >> > versions in Emacs 29? >>=20 >> It is new, and the simplest solution that should revert the issue could >> be just to have `package-load-all-descriptors' sort the files when >> loading descriptors. > > Can you show a patch for this, please? Whoops, I forgot to attach a diff: --=-=-= Content-Type: text/plain Content-Disposition: inline diff --git a/lisp/emacs-lisp/package.el b/lisp/emacs-lisp/package.el index 1ee39f87529..0145306dc4e 100644 --- a/lisp/emacs-lisp/package.el +++ b/lisp/emacs-lisp/package.el @@ -898,14 +898,22 @@ package-activate-1 (defun package--get-activatable-pkg (pkg-name) ;; Is "activatable" a word? - (let ((pkg-descs (cdr (assq pkg-name package-alist)))) + (let ((pkg-descs (sort (cdr (assq pkg-name package-alist)) + (lambda (p1 p2) + (let ((v1 (package-desc-version p1)) + (v2 (package-desc-version p2))) + (or + ;; Prefer source packages. + (eq (package-desc-kind p1) 'vc) + (not (eq (package-desc-kind p2) 'vc)) + ;; Prefer builtin packages. + (package-disabled-p p1 v1) + (not (package-disabled-p p2 v2)))))))) ;; Check if PACKAGE is available in `package-alist'. (while (when pkg-descs (let ((available-version (package-desc-version (car pkg-descs)))) - (or (package-disabled-p pkg-name available-version) - ;; Prefer a builtin package. - (package-built-in-p pkg-name available-version)))) + (package-disabled-p pkg-name available-version))) (setq pkg-descs (cdr pkg-descs))) (car pkg-descs))) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable >> I am not sure if the issue that Stefan raised, >> with `sort' in `package--get-activatable-pkg' destructively modifying >> `package-alist', but if anything that has been an issue before Emacs 29 >> as well. > > =D0=95=D0=B2=D0=B3=D0=B5=D0=BD=D0=B8=D0=B9 says that the call to 'sort' i= n package--get-activatable-pkg > didn't exist before commit fb87d500. That is true, and perhaps that could be reverted to some degree as well. --=-=-=--