From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Joseph Turner via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#65649: [PATCH] package-vc: Continue installing package when documentation build fails Date: Sat, 02 Sep 2023 09:49:24 -0700 Message-ID: <87h6ocms72.fsf@breatheoutbreathe.in> References: <87v8cvvi6r.fsf@breatheoutbreathe.in> <87r0njvhyo.fsf@breatheoutbreathe.in> <87msy7vhum.fsf@breatheoutbreathe.in> <87pm33r87q.fsf@posteo.net> <87sf7yoq9p.fsf@breatheoutbreathe.in> <87fs3yvxve.fsf@posteo.net> <87ttsdmpwm.fsf@breatheoutbreathe.in> <877cp8g4sy.fsf@posteo.net> Reply-To: Joseph Turner Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="11070"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 65649@debbugs.gnu.org To: Philip Kaludercic Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Sep 02 18:55:05 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qcTtp-0002gg-0x for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 02 Sep 2023 18:55:05 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qcTte-0000KT-P2; Sat, 02 Sep 2023 12:54:54 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qcTtd-0000Jn-D8 for bug-gnu-emacs@gnu.org; Sat, 02 Sep 2023 12:54:53 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qcTtd-0004Pa-5Q for bug-gnu-emacs@gnu.org; Sat, 02 Sep 2023 12:54:53 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qcTtm-0004oJ-Sx for bug-gnu-emacs@gnu.org; Sat, 02 Sep 2023 12:55:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Joseph Turner Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 02 Sep 2023 16:55:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 65649 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 65649-submit@debbugs.gnu.org id=B65649.169367368118447 (code B ref 65649); Sat, 02 Sep 2023 16:55:02 +0000 Original-Received: (at 65649) by debbugs.gnu.org; 2 Sep 2023 16:54:41 +0000 Original-Received: from localhost ([127.0.0.1]:38508 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qcTtR-0004nS-6U for submit@debbugs.gnu.org; Sat, 02 Sep 2023 12:54:41 -0400 Original-Received: from out-233.mta0.migadu.com ([91.218.175.233]:34322) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qcTtO-0004nK-Mh for 65649@debbugs.gnu.org; Sat, 02 Sep 2023 12:54:40 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=breatheoutbreathe.in; s=key1; t=1693673668; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=XTFHkRdNo01f+yFo3vwByDz6N4GtAQsxM9fyZ08Sv4c=; b=H+prYcL+28Pfsts2yi+i43a4Q8CIw7nggZuyslDuOd8gNnT/nobBAtljnjNrNBBSOTuPIV BhqD8Le+WluMWl5w1ROUPgo8vXnPwVo+qq+QIVdufpCiYs4dNeY/5idU85z88ZkdPVNWrb ulZgSyRErd82kTbsqvMXzB9y6mbRnlU= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. In-reply-to: <877cp8g4sy.fsf@posteo.net> X-Migadu-Flow: FLOW_OUT X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:269029 Archived-At: Philip Kaludercic writes: > I think it would be better to wrap only the org code in the > `condition-case' body, ideally with a more specific error type (if that > doesn't exist, that is something we could mention to the Org > maintainers). The reason I wrapped both the org-export and makeinfo logic in condition-case is so that the makeinfo logic does not run when the org-export logic fails. Is there a better way? We could let-bind a flag like failed-org-export-p, then set it to t in the condition case handler, then only run makeinfo when failed-org-export-p is nil. Seems a bit ugly. The only define-error in org-mode that's relevant to org-export is not general enough: (define-error 'org-link-broken "Unable to resolve link; aborting")