From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Tony Zorman Newsgroups: gmane.emacs.devel Subject: Re: package-vc support for :files keyword Date: Mon, 25 Sep 2023 15:32:26 +0200 Message-ID: <87h6niml91.fsf@hyperspace> References: <87ttrshrib.fsf@hyperspace> <871qev6e53.fsf@posteo.net> <87r0mviltd.fsf@hyperspace> <871qevbhru.fsf@posteo.net> <87o7hzi82q.fsf@hyperspace> <87pm2ebldd.fsf@posteo.net> <87o7hyl01m.fsf@hyperspace> <87y1h18flc.fsf@posteo.net> <87jzsgm82h.fsf@hyperspace> <87wmwfbq2o.fsf@posteo.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="16889"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Philip Kaludercic Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Sep 26 14:41:53 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ql7Nw-0004BV-Aw for ged-emacs-devel@m.gmane-mx.org; Tue, 26 Sep 2023 14:41:52 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ql7N6-0006VL-RU; Tue, 26 Sep 2023 08:41:00 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qklhg-0000LF-DV for emacs-devel@gnu.org; Mon, 25 Sep 2023 09:32:48 -0400 Original-Received: from mout-p-101.mailbox.org ([2001:67c:2050:0:465::101]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_CHACHA20_POLY1305:256) (Exim 4.90_1) (envelope-from ) id 1qklhb-0001Jw-5l for emacs-devel@gnu.org; Mon, 25 Sep 2023 09:32:44 -0400 Original-Received: from smtp202.mailbox.org (smtp202.mailbox.org [10.196.197.202]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-384) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-p-101.mailbox.org (Postfix) with ESMTPS id 4RvP1m6RLXz9sSN; Mon, 25 Sep 2023 15:32:28 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mailbox.org; s=mail20150812; t=1695648748; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=PNK2w1/2a/Y1bwOxynGcdNRb5cTyxtUx8ZHmBYWxhkw=; b=WRdycyBhK7tTpO7C3hrHX89Ln9pityWSE4tDrOYAOzEbBWWxTWX4jX+2alEcXvQ1qXPBqE Hj1m/zne1Iqz/OhzBIUlaDcV/AEPmtQHNbF3zzWeyJIiv0zkMsDrSV7kvz9t1NAGEDnMiV Jt/0KRqvdNzHgVIT7s3nLxeGTPnLLXrOj82Wfao8HJGRne4UzWABPKUui4DGNWDuqZi2aA rmmoULG/zphVYsEhBUwSUIKpHcaO5dYigEb0YZ4zwUkS8lhxWMcYljaWddjA3SpJIt5zDE TovjttQjpKdRerbHFMM96OKxHuXtsnHN/yaW7xRqnFL++KFV2KkoiHmu6HtXNQ== In-Reply-To: <87wmwfbq2o.fsf@posteo.net> X-MBO-RS-ID: 70dc391ebe563807494 X-MBO-RS-META: 769ckybx6skruaokbh3ubjd44ajzwxir Received-SPF: pass client-ip=2001:67c:2050:0:465::101; envelope-from=tonyzorman@mailbox.org; helo=mout-p-101.mailbox.org X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Mailman-Approved-At: Tue, 26 Sep 2023 08:40:58 -0400 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:311066 Archived-At: On Sun, Sep 24 2023 16:31, Philip Kaludercic wrote: > Tony Zorman writes: > >> On Wed, Sep 20 2023 07:32, Philip Kaludercic wrote: >>> + (unless (string-match-p ignored-files file) >> >> One thing that did jump out to me just now, which I hadn't considered >> before: when ignored-files is the empty string, this will always match >> any file=E2=80=94not what we want :) > > Do you mean because the empty glob expression doesn't match everything, > but the empty regular expression does? > > The easiest solution seems to be to just check if the empty string is > listed and handle that separately (whatever the correct behaviour is in > that case), but on the other hand, why should a user list an empty > string in the list of ignored files? The point I was making was that `(mapconcat (=CE=BB=E2=80=A6) nil) =E2=89= =A1 ""`, since mapconcat always returns a string. Even if there were no :ignored-files listed, the ignored-files variable would then be the empty string, matching each and every file. --=20 Tony Zorman | https://tony-zorman.com/