From mboxrd@z Thu Jan  1 00:00:00 1970
Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail
From: Thierry Volpiatto <thievol@posteo.net>
Newsgroups: gmane.emacs.bugs
Subject: bug#66394: 29.1; Make register-read-with-preview more useful
Date: Fri, 27 Oct 2023 04:24:23 +0000
Message-ID: <87h6mcr8ol.fsf@posteo.net>
References: <87il7ib6cu.fsf@posteo.net> <87sf67qqmp.fsf@web.de>
 <875y3386ep.fsf@posteo.net> <87a5sddh14.fsf@web.de>
 <8734y5vnj7.fsf@posteo.net> <87bkcslr18.fsf@web.de>
 <87y1fwtyrl.fsf@posteo.net> <87y1fut1wp.fsf@web.de>
 <87ttqgpjiz.fsf@posteo.net> <87wmvbibpr.fsf@web.de>
 <877cnb2n63.fsf@posteo.net> <8734xyc8z0.fsf@web.de>
 <87zg05rewi.fsf@posteo.net> <87ttqcg8gw.fsf@web.de>
Mime-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
 micalg=pgp-sha512; protocol="application/pgp-signature"
Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214";
	logging-data="36378"; mail-complaints-to="usenet@ciao.gmane.io"
Cc: 66394@debbugs.gnu.org
To: Michael Heerdegen <michael_heerdegen@web.de>
Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Oct 27 06:28:48 2023
Return-path: <bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org>
Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org
Original-Received: from lists.gnu.org ([209.51.188.17])
	by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org>)
	id 1qwESm-0009IN-78
	for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 27 Oct 2023 06:28:48 +0200
Original-Received: from localhost ([::1] helo=lists1p.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.90_1)
	(envelope-from <bug-gnu-emacs-bounces@gnu.org>)
	id 1qwESW-0004ko-U7; Fri, 27 Oct 2023 00:28:32 -0400
Original-Received: from eggs.gnu.org ([2001:470:142:3::10])
 by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
 id 1qwESV-0004kY-2m
 for bug-gnu-emacs@gnu.org; Fri, 27 Oct 2023 00:28:31 -0400
Original-Received: from debbugs.gnu.org ([2001:470:142:5::43])
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
 (Exim 4.90_1) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
 id 1qwESU-0004Tg-QX
 for bug-gnu-emacs@gnu.org; Fri, 27 Oct 2023 00:28:30 -0400
Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1qwESz-0006a8-Nf
 for bug-gnu-emacs@gnu.org; Fri, 27 Oct 2023 00:29:01 -0400
X-Loop: help-debbugs@gnu.org
Resent-From: Thierry Volpiatto <thievol@posteo.net>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@gnu.org
Resent-Date: Fri, 27 Oct 2023 04:29:01 +0000
Resent-Message-ID: <handler.66394.B66394.169838092525276@debbugs.gnu.org>
Resent-Sender: help-debbugs@gnu.org
X-GNU-PR-Message: followup 66394
X-GNU-PR-Package: emacs
Original-Received: via spool by 66394-submit@debbugs.gnu.org id=B66394.169838092525276
 (code B ref 66394); Fri, 27 Oct 2023 04:29:01 +0000
Original-Received: (at 66394) by debbugs.gnu.org; 27 Oct 2023 04:28:45 +0000
Original-Received: from localhost ([127.0.0.1]:34878 helo=debbugs.gnu.org)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <debbugs-submit-bounces@debbugs.gnu.org>)
 id 1qwESi-0006Zc-Qn
 for submit@debbugs.gnu.org; Fri, 27 Oct 2023 00:28:45 -0400
Original-Received: from mout02.posteo.de ([185.67.36.66]:56449)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <thievol@posteo.net>) id 1qwESd-0006ZI-HD
 for 66394@debbugs.gnu.org; Fri, 27 Oct 2023 00:28:43 -0400
Original-Received: from submission (posteo.de [185.67.36.169]) 
 by mout02.posteo.de (Postfix) with ESMTPS id D192E240104
 for <66394@debbugs.gnu.org>; Fri, 27 Oct 2023 06:28:01 +0200 (CEST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017;
 t=1698380881; bh=NSTbRSPZoKjGEZ+VQ5aKOY8p+uzkH0SV+uC/nx7uQYw=;
 h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:Autocrypt:OpenPGP:
 From;
 b=VoXp3hBS9Ro0BtUcmk/D4nuc0DvdXLAIJTcmRwrErwu3wiigUjBFN3bSQ9WzkHGDe
 8i3zycKPA9dlaQrDwjeM6qGazFRLpinUHTKdDbDEF+WPZFTx9nyogt2QZeeiu/+hkb
 b6DvKckIEze3X82Pweo46zBN4k/j7KF4WXQxUB74ehnpRTVtb1WOEORCvaZKSD++JC
 EtanD/tORJb6ycK4fpP/1doTJeH/Ukv2eG6aT9Sj66OWYR+oMz+p/PVdN8AKAii1qr
 fFxapr3GbgLgtIZpI5JTEnv/xAzO6HXAISJzQOYPBI+h3Z6Wscyyi3Svcwfq2gkUpH
 VRm9Iprhb6hqg==
Original-Received: from customer (localhost [127.0.0.1])
 by submission (posteo.de) with ESMTPSA id 4SGqQm4s5cz6tm4;
 Fri, 27 Oct 2023 06:28:00 +0200 (CEST)
In-reply-to: <87ttqcg8gw.fsf@web.de>
Autocrypt: addr=thievol@posteo.net; prefer-encrypt=mutual;
 keydata=xsDNBF8ylcIBDADG+hy+zR6L4/vbdDDZuSaMmSrU3A5QZJpeBCvxTr7MpzzruZbhLPW1K3R6N2MA
 edi8Y+C8o27FVRIjpdbaKMGu9je7JV/TbUQYo3SOwCK1vM4LUn4V6ZLzSYkuiEt4eyMoiDdyvN0p
 kcK6P9x9DCetcEVszXzQg+yzCVrQ2hXWDXWT4M18EC3wtO7RHPouMqGiwBFhBAYErCqFWFxQHkfb
 tG/4yGyJ58rglb65O3qijjMWvYwcWZun9/7qm8Z4/4mHopmo2zgU+OrptnLSZfkZGz3Y7Uf452xQ
 GVq0Fv75NPvQru7y+DYVhuVXXyAmGxt+vf4rIiixMBbhKEPjcxEPAa2LTzex2IsTZR+QVG9uDnqC
 WcgaOEQ58fzXNvNhtwwF/Rgio2XWAJVdmFWS59/k9W58CIUSNKBMZh2XeGdEmtHvDtCxW3z6FJha
 36RzOM3fMNNiAGdFZJA84gcdloJR+sHCDTTPT3784fjr+V8An7sI581NGFzkRQqPvEQCZbUAEQEA
 Ac0SdGhpZXZvbEBwb3N0ZW8ubmV0wsEOBBMBCgA4AhsDBQsJCAcCBhUKCQgLAgQWAgMBAh4BAheA
 FiEEI9twfRN7r3nig/xwDsVtFB0W75MFAmL3HCoACgkQDsVtFB0W75OVEAv/f6XxmtIFz08fUb8h
 Bp/zJP6IC4/rhhh+0GMRIRzLN8DK0jV8JCzYdFHiRJOy2lNIOpmrrCmjRRxferc2G42+ePFIsslx
 hU46VSz1Z83NwIG3mpdYNV5WUTUdgzxExHTNTFCd7NKv0nlHKQaA 
OpenPGP: url=https://posteo.de/keys/thievol@posteo.net.asc; preference=encrypt
X-BeenThere: debbugs-submit@debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
X-BeenThere: bug-gnu-emacs@gnu.org
List-Id: "Bug reports for GNU Emacs,
 the Swiss army knife of text editors" <bug-gnu-emacs.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/bug-gnu-emacs>,
 <mailto:bug-gnu-emacs-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/bug-gnu-emacs>
List-Post: <mailto:bug-gnu-emacs@gnu.org>
List-Help: <mailto:bug-gnu-emacs-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/bug-gnu-emacs>,
 <mailto:bug-gnu-emacs-request@gnu.org?subject=subscribe>
Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org
Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org
Xref: news.gmane.io gmane.emacs.bugs:273335
Archived-At: <http://permalink.gmane.org/gmane.emacs.bugs/273335>

--=-=-=
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable


Michael Heerdegen <michael_heerdegen@web.de> writes:

> Thierry Volpiatto <thievol@posteo.net> writes:
>
>> Why do you need another argument as long as you use `this-command`?
>> You can use e.g. (pcase this-command ('foo #'foo-p) etc...)
>
> I doubt all potential uses will use `this-command'.
>
> It's cleaner if the command that knows what it wants passes the
> information via argument than to make the other function derive it
> indirectly from the context (functional style).

It is what I did initially after realizing it is simpler to use
this-command from register-read-with-preview.

> Maybe in the future we might need to pass other predicates as well.
> What when a user wants to add another register command?

You can with the current register-preview.el add a new command and
control filtering of this command.

=2D-=20
Thierry

--=-=-=
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQHHBAEBCgAxFiEEI9twfRN7r3nig/xwDsVtFB0W75MFAmU7PEoTHHRoaWV2b2xA
cG9zdGVvLm5ldAAKCRAOxW0UHRbvk/5NC/9Acyiv1z4qlmazVYH4gEgNxXlgvhWG
iiBL7qsEGKGwATK/Ii3islIloRzD33FuxWh93oAyEBR/6FKYtN4qAVm2+Mb0OZtv
h7aDsNPnro6ehEClJFxwAbErOqmh8OPNGIESmz5XfXTHRFv7kL5NRuUW/vCGL/z1
5dYWQxeP93CxWmDQ/MzTAAgiYPDVLnJqYdTUbTe4JoySb1OIeRZL9aJCST3U1ApQ
wTjwuB2/VIVZT0eiWvsTZKjcYtY3IlK91XsON3pii3P+Q/E5aDInBBJY+eqlgd82
ylsqGPSv4KXfHKZ2BH6h6RR9HsEHconG3cm3BqM6d1Zy3e6vjTckCprJeY3JHHHk
xLo+t5ZBkxuku/nVrx8RjaeY3BaBImoukZXo7MkjNd4Pf6l9VfksciKBY9dkWW4O
uuk7nIn2eQaYk+sema4a09ZiHdQGo47QpUwn0PtFgggFExLegH1BSat7bmg2cI33
PLOtZIJxZ5fHuYTH1f77Xq+aQ9/8UynKNkk=
=mXK4
-----END PGP SIGNATURE-----
--=-=-=--