From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Daniel Mendler via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#66554: [PATCH] Add the public API of Compat to the core Date: Thu, 11 Jan 2024 18:58:19 +0100 Message-ID: <87h6jjah1g.fsf@daniel-mendler.de> References: <87pm1ggrdx.fsf@posteo.net> <87bk9scucg.fsf@daniel-mendler.de> <87y1cwpanh.fsf@posteo.net> <877ckgpa45.fsf@daniel-mendler.de> <87mstbpyd7.fsf@posteo.net> Reply-To: Daniel Mendler Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="32091"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: 66554@debbugs.gnu.org, eliz@gnu.org, Stefan Kangas , Stefan Monnier To: Philip Kaludercic Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Jan 11 18:59:33 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rNzL2-000886-NV for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 11 Jan 2024 18:59:32 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rNzKd-0005Du-Pt; Thu, 11 Jan 2024 12:59:07 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rNzKb-0005D7-Ev for bug-gnu-emacs@gnu.org; Thu, 11 Jan 2024 12:59:05 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rNzKb-0004kN-76 for bug-gnu-emacs@gnu.org; Thu, 11 Jan 2024 12:59:05 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rNzKY-0002k2-Lt for bug-gnu-emacs@gnu.org; Thu, 11 Jan 2024 12:59:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Daniel Mendler Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 11 Jan 2024 17:59:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 66554 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 66554-submit@debbugs.gnu.org id=B66554.170499590810488 (code B ref 66554); Thu, 11 Jan 2024 17:59:02 +0000 Original-Received: (at 66554) by debbugs.gnu.org; 11 Jan 2024 17:58:28 +0000 Original-Received: from localhost ([127.0.0.1]:33833 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rNzJz-0002j5-Fo for submit@debbugs.gnu.org; Thu, 11 Jan 2024 12:58:27 -0500 Original-Received: from server.qxqx.de ([2a01:4f8:c012:9177::1]:58803 helo=mail.qxqx.de) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rNzJx-0002it-55 for 66554@debbugs.gnu.org; Thu, 11 Jan 2024 12:58:26 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=daniel-mendler.de; s=key; h=Content-Type:MIME-Version:Message-ID:Date: References:In-Reply-To:Subject:Cc:To:From:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=e55tOw2YGPTOBQHlNMNwZweelIqnUl1bPV9j91qkwIk=; b=TW5VdF84EIRpm+0M29WzmtLR4r sRpqRJD8521pKd8o+fstpjwZprv4qszBh68GC8DblSOBB+6KrGPnLSns8b6ny7efNpw2pijkZ7/c+ JToR/slSXv7SOU0aBr+k6kf8ScKh20Ajg9FoaQ4cALq4B8cc+FDAFu5F16gBSQCYpY90=; In-Reply-To: <87mstbpyd7.fsf@posteo.net> (Philip Kaludercic's message of "Thu, 11 Jan 2024 17:35:00 +0000") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:277923 Archived-At: Philip Kaludercic writes: >>> If I am not mistaken, all we would have to do is to adjust the version >>> number in the patch to the current Emacs version -- and update it >>> whenever Emacs is updated. I have a slight concern that this could be >>> easily forgotten, if it isn't hooked into some update scripts. >> >> Okay, I see. The specified version should probably be something like >> 30.1.999 to make sure that packages requiring any Compat 30.1.x version >> will not download the ELPA package? > > Because of > > (version< "30.1" "30.1.1") > > we can just set it to the actual Emacs version. No. We want a version larger than any Compat version corresponding to the current Emacs version. For example when there is compat-31.1.1.7 on ELPA and Magit depends on compat>=31.1 and Magit is installed on an Emacs 31.1, Compat should not be installed, since the builtin Compat already satisfies the dependency. However if Magit is installed on an Emacs 30.2, compat-31.1.1.7 should be installed. This means the internal Compat version on Emacs 30.1 should be like 30.1.9999, or another large enough version. >> Is there a place where we could add a warning to make sure that >> bumping the version won't be forgotten? > > I think that admin/admin.el's `set-version' could be used like this: > >> I don't mind, but it sounds like the details of adding compat.el to >> core are not yet clear to all, and are still being discussed. Also, >> it sounds like we would need to modify compat.el for every release or >> something? if so, this should be in make-tarball.txt. > > As mentioned above, I think this could be automated. I agree, it would be good to automate the version bump, such that it cannot be forgotten. >> It might be also a good idea to mention this in the ELisp manual >> somewhere. > > This being "Compat"? It makes sense to also mention Compat in the Elisp manual and refer to the Compat manual on ELPA. There we already document Compat usage for Emacs core packages, which should be updated accordingly (https://elpa.gnu.org/packages/doc/compat.html#Usage). Daniel