From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?utf-8?Q?Dagfinn_Ilmari_Manns=C3=A5ker?= Newsgroups: gmane.emacs.devel Subject: Re: master 40629706b1f 1/2: Avoid unnecessary escaping in 'url-build-query-string' Date: Tue, 23 Apr 2024 17:07:31 +0100 Message-ID: <87h6fshxks.fsf@wibble.ilmari.org> References: <171343493172.17932.11313573194838208920@vcs2.savannah.gnu.org> <20240418100853.D8466C1FB57@vcs2.savannah.gnu.org> <874jbxy073.fsf@pub.pink> <868r19bet3.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="3671"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) Cc: john muhl , emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Apr 24 06:59:50 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rzUjV-0000lQ-LA for ged-emacs-devel@m.gmane-mx.org; Wed, 24 Apr 2024 06:59:50 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rzUit-0007Yn-OZ; Wed, 24 Apr 2024 00:59:12 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rzIgG-000179-Ha for emacs-devel@gnu.org; Tue, 23 Apr 2024 12:07:41 -0400 Original-Received: from fout4-smtp.messagingengine.com ([103.168.172.147]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rzIgE-0004bw-9C; Tue, 23 Apr 2024 12:07:40 -0400 Original-Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailfout.nyi.internal (Postfix) with ESMTP id E21EA13800DF; Tue, 23 Apr 2024 12:07:34 -0400 (EDT) Original-Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Tue, 23 Apr 2024 12:07:34 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ilmari.org; h=cc :cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:subject :subject:to:to; s=fm2; t=1713888454; x=1713974854; bh=0WfAYi85eT rRe/m4fdan9Kww5gIuoZ1U9pB6PZF/qYs=; b=Nvd7oBxs4wOuCT7AAD8DXHUiAF PBjMhf6NgdU0Z0seIjJ5yHoYc/ifoeePLVagVWMThu3FpvVcdDFNfC9wYpNZgVvH sJECTaEVPrWqpjBud2YuHEPa7lbF+y48d5alEfBmu5hM+fAGJtf6VwG3UTOYL6a3 sNVV9wx3gXWLxIa3KHqu4WjDsh2Px0wsGhXUnUhBbh7FMQWDcMP2na0OlSERp0qs klWYFW9/LnEMGE4SUGZtrlgbDPFkWORygwkRtMNgeJWdEZNcP0N48PTnc7iV1VQ/ YfT1TIsF1JUvlUmTxD8JgPrPZE961GnN+ALiOLMlgpNQM2mVeTPjb9824+4A== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm3; t=1713888454; x=1713974854; bh=0WfAYi85eTrRe/m4fdan9Kww5gIu oZ1U9pB6PZF/qYs=; b=VX5ghaduOLi/B5cz778A8pn1Akm6v9ZFwKcts/cHmqNR qmJhUEYRtBV75/b6l8comGASFEurLfuOZLH4kenh7BH/xs5hq1fhr1JXgg2YCMT5 JZ5LF1A7kXYFHdSFxfiRGHY+Z/wMDSMglS1MoPHYLxE1EQUmehCw/l4aL5TkyOab fge1awZfM06Tak1mD9wMrbKQHd4kGfnjJBURycQCXOnqOtjeb5yRgvrXO5bLR1oj kKGb1j+LpAPXH5LkdoAI78IqVUHyOlnGqXINSY2eo7gncpIodSu2K2dy5qg8g+JI h/hemjrLLIFDZvwV+peL7Kw0tgcTfJF537KvM9ba7g== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvledrudeluddgleekucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufhffjgfkfgggtgesthdtredttderjeenucfhrhhomhepffgrghhf ihhnnhcukfhlmhgrrhhiucforghnnhhsnohkvghruceoihhlmhgrrhhisehilhhmrghrih drohhrgheqnecuggftrfgrthhtvghrnhepkeeljeeufefhffekhfektdefleeuvdeiiefh heeffeefgeegudffudehjeejiefgnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrg hmpehmrghilhhfrhhomhepihhlmhgrrhhisehilhhmrghrihdrohhrgh X-ME-Proxy: Feedback-ID: i1ff147bf:Fastmail Original-Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 23 Apr 2024 12:07:33 -0400 (EDT) In-Reply-To: <868r19bet3.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 19 Apr 2024 17:35:52 +0300") Received-SPF: pass client-ip=103.168.172.147; envelope-from=ilmari@ilmari.org; helo=fout4-smtp.messagingengine.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Mailman-Approved-At: Wed, 24 Apr 2024 00:59:10 -0400 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:318017 Archived-At: Eli Zaretskii writes: >> From: john muhl >> Cc: Eli Zaretskii , emacs-devel@gnu.org >> Date: Thu, 18 Apr 2024 11:01:56 -0500 >> >> Bisect says this commit caused the gravatar tests to start failing. >> >> make test/lisp/image/gravatar-tests.log > > Thanks. Ilmari, could you please look into this? The question is > whether we need to adapt the gravatar tests, or fine-tune your changes > to url-utils. I think the gravatar test should be adjusted. Both the old and the new form are valid, and this over-escaping is exactly what my change was intended to address. However, I appear to have exhausted the acceptable amount contribution without doing the copyright assignment dance, which I have no time for, so someone else will have to make the actual change. - ilmari