all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: "Dagfinn Ilmari Mannsåker" <ilmari@ilmari.org>
To: Eli Zaretskii <eliz@gnu.org>
Cc: john muhl <jm@pub.pink>,  emacs-devel@gnu.org
Subject: Re: master 40629706b1f 1/2: Avoid unnecessary escaping in 'url-build-query-string'
Date: Tue, 23 Apr 2024 17:07:31 +0100	[thread overview]
Message-ID: <87h6fshxks.fsf@wibble.ilmari.org> (raw)
In-Reply-To: <868r19bet3.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 19 Apr 2024 17:35:52 +0300")

Eli Zaretskii <eliz@gnu.org> writes:

>> From: john muhl <jm@pub.pink>
>> Cc: Eli Zaretskii <eliz@gnu.org>, emacs-devel@gnu.org
>> Date: Thu, 18 Apr 2024 11:01:56 -0500
>> 
>> Bisect says this commit caused the gravatar tests to start failing.
>> 
>>   make test/lisp/image/gravatar-tests.log
>
> Thanks.  Ilmari, could you please look into this?  The question is
> whether we need to adapt the gravatar tests, or fine-tune your changes
> to url-utils.

I think the gravatar test should be adjusted. Both the old and the new
form are valid, and this over-escaping is exactly what my change was
intended to address.

However, I appear to have exhausted the acceptable amount contribution
without doing the copyright assignment dance, which I have no time for,
so someone else will have to make the actual change.

- ilmari



  reply	other threads:[~2024-04-23 16:07 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <171343493172.17932.11313573194838208920@vcs2.savannah.gnu.org>
     [not found] ` <20240418100853.D8466C1FB57@vcs2.savannah.gnu.org>
2024-04-18 16:01   ` master 40629706b1f 1/2: Avoid unnecessary escaping in 'url-build-query-string' john muhl
2024-04-19 14:35     ` Eli Zaretskii
2024-04-23 16:07       ` Dagfinn Ilmari Mannsåker [this message]
2024-04-23 16:19         ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87h6fshxks.fsf@wibble.ilmari.org \
    --to=ilmari@ilmari.org \
    --cc=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=jm@pub.pink \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.