all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Manuel Giraud via "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
To: Eli Zaretskii <eliz@gnu.org>
Cc: basil@contovou.net, 71264@debbugs.gnu.org
Subject: bug#71264: 30.0.50; Dired deletion moves point under auto-revert
Date: Sat, 08 Jun 2024 18:11:53 +0200	[thread overview]
Message-ID: <87h6e3wh12.fsf@ledu-giraud.fr> (raw)
In-Reply-To: <87r0d9m5af.fsf@ledu-giraud.fr> (Manuel Giraud's message of "Fri,  07 Jun 2024 12:11:04 +0200")

[-- Attachment #1: Type: text/plain, Size: 105 bytes --]

Hi,

I don't know if this is the right approach but the following patch gives
me the expected behaviour.

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-Prevent-auto-revert-when-deleting-entry-bug-71264.patch --]
[-- Type: text/x-patch, Size: 1111 bytes --]

From 4aa18aa0e60a8af0bbc8d333fc5e07caf6b3ab0a Mon Sep 17 00:00:00 2001
From: Manuel Giraud <manuel@ledu-giraud.fr>
Date: Sat, 8 Jun 2024 18:08:28 +0200
Subject: [PATCH] Prevent auto-revert when deleting entry(bug#71264)

* lisp/dired.el (dired-internal-do-deletions): Temporarily
  prevent auto-revert.
---
 lisp/dired.el | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/lisp/dired.el b/lisp/dired.el
index c51e5e42c29..67683c4ab93 100644
--- a/lisp/dired.el
+++ b/lisp/dired.el
@@ -4015,7 +4015,11 @@ dired-internal-do-deletions
               (dired-move-to-filename)
 	      (let ((inhibit-read-only t))
 		(condition-case err
-		    (let ((fn (car (car l))))
+		    (let ((fn (car (car l)))
+                          ;; Temporarily prevent auto-revert while
+                          ;; deleting entry in the dired buffer.
+                          (auto-revert-mode nil)
+                          (dired-auto-revert-buffer nil))
 		      (dired-delete-file fn dired-recursive-deletes trash)
 		      ;; if we get here, removing worked
 		      (setq succ (1+ succ))
-- 
2.45.1


[-- Attachment #3: Type: text/plain, Size: 18 bytes --]

-- 
Manuel Giraud

  reply	other threads:[~2024-06-08 16:11 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-29 21:48 bug#71264: 30.0.50; Dired deletion moves point under auto-revert Basil L. Contovounesios
2024-05-31  9:29 ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-05-31  9:42   ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-05-31 12:10     ` Basil L. Contovounesios
2024-05-31 12:54       ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-05-31 15:48         ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-06-01 17:19       ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-06-01 17:59         ` Eli Zaretskii
2024-06-02 14:59           ` Basil L. Contovounesios
2024-06-02 15:23             ` Eli Zaretskii
2024-06-02 17:02               ` Basil L. Contovounesios
2024-06-03 18:53                 ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-06-03 19:02                   ` Eli Zaretskii
2024-06-03 20:00                     ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-06-04 14:26                       ` Eli Zaretskii
2024-06-04 19:51                         ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-06-07 10:11                           ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-06-08 16:11                             ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors [this message]
2024-06-15  8:52                               ` Eli Zaretskii
2024-06-17  9:29                                 ` Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-06-22  8:53                                   ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87h6e3wh12.fsf@ledu-giraud.fr \
    --to=bug-gnu-emacs@gnu.org \
    --cc=71264@debbugs.gnu.org \
    --cc=basil@contovou.net \
    --cc=eliz@gnu.org \
    --cc=manuel@ledu-giraud.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.